From 5ffe597dbeea869d6919e57a6a0f346364f8c14f Mon Sep 17 00:00:00 2001 From: SMT Date: Thu, 10 Sep 2026 12:28:15 -0700 Subject: [PATCH 1/3] Bump actions/checkout to v5; fix a stale test label MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CI annotates every run with "Node.js 20 is deprecated" for actions/checkout@v4. codex-code-review.yml was already on v5; this brings the other three workflows in line. Also corrects the BashBare label, which still said "bash --norc" after that variant moved to --noprofile --rcfile. 🤖 Built with SMT --- .github/workflows/ci.yml | 2 +- .github/workflows/claude-code-review.yml | 2 +- .github/workflows/release.yml | 8 ++++---- tests/tmux_e2e.rs | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3b904a8..23dc458 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: timeout-minutes: 15 steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: dtolnay/rust-toolchain@stable with: diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml index 0debd21..d30796a 100644 --- a/.github/workflows/claude-code-review.yml +++ b/.github/workflows/claude-code-review.yml @@ -28,7 +28,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v4 + uses: actions/checkout@v5 with: ref: refs/pull/${{ github.event.pull_request.number }}/merge fetch-depth: 0 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 12f401b..58a59d6 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -20,7 +20,7 @@ jobs: runs-on: ubuntu-latest timeout-minutes: 15 steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: dtolnay/rust-toolchain@stable with: components: rustfmt, clippy @@ -51,7 +51,7 @@ jobs: runs-on: ${{ matrix.os }} timeout-minutes: 20 steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: dtolnay/rust-toolchain@stable with: @@ -119,7 +119,7 @@ jobs: needs: release runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: actions/setup-node@v4 with: node-version: "20" @@ -139,7 +139,7 @@ jobs: needs: release runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: actions/download-artifact@v4 with: path: dist/ diff --git a/tests/tmux_e2e.rs b/tests/tmux_e2e.rs index 516ee80..08c5959 100644 --- a/tests/tmux_e2e.rs +++ b/tests/tmux_e2e.rs @@ -118,7 +118,7 @@ impl Shell { match self { Shell::Zsh => "zsh", Shell::Bash => "bash", - Shell::BashBare => "bash --norc", + Shell::BashBare => "bash (no rc)", } } From 0073d7e63a9d234447bec30f5a688433cde96be5 Mon Sep 17 00:00:00 2001 From: SMT Date: Thu, 10 Sep 2026 12:31:31 -0700 Subject: [PATCH 2/3] TEMP: print author_association to diagnose the skipped review gate MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🤖 Built with SMT --- .github/workflows/claude-code-review.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml index d30796a..78b31b6 100644 --- a/.github/workflows/claude-code-review.yml +++ b/.github/workflows/claude-code-review.yml @@ -5,6 +5,17 @@ on: types: [opened, synchronize, ready_for_review, reopened] jobs: + # TEMPORARY: prints what the gate actually sees. Remove before merge. + debug-gate: + runs-on: ubuntu-latest + permissions: {} + steps: + - run: | + echo "author_association=[${{ github.event.pull_request.author_association }}]" + echo "actor=${{ github.actor }}" + echo "event=${{ github.event_name }}" + echo "draft=${{ github.event.pull_request.draft }}" + # The agent runs with a READ-ONLY token. PR title/diff are untrusted and are # fed to the model, so even if a malicious PR injects instructions, the agent # has no write capability. Posting is done by a separate, model-free job. From 9bacb6983a2192a4d3a458c76ee2c4e6d46d77ed Mon Sep 17 00:00:00 2001 From: SMT Date: Thu, 10 Sep 2026 12:36:14 -0700 Subject: [PATCH 3/3] Remove the temporary gate-diagnostic job MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit author_association was NONE because guohai had no direct collaborator relationship with this repo and org membership is private. Fixed by adding the direct collaborator entry, matching Vox. 🤖 Built with SMT --- .github/workflows/claude-code-review.yml | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml index 78b31b6..d30796a 100644 --- a/.github/workflows/claude-code-review.yml +++ b/.github/workflows/claude-code-review.yml @@ -5,17 +5,6 @@ on: types: [opened, synchronize, ready_for_review, reopened] jobs: - # TEMPORARY: prints what the gate actually sees. Remove before merge. - debug-gate: - runs-on: ubuntu-latest - permissions: {} - steps: - - run: | - echo "author_association=[${{ github.event.pull_request.author_association }}]" - echo "actor=${{ github.actor }}" - echo "event=${{ github.event_name }}" - echo "draft=${{ github.event.pull_request.draft }}" - # The agent runs with a READ-ONLY token. PR title/diff are untrusted and are # fed to the model, so even if a malicious PR injects instructions, the agent # has no write capability. Posting is done by a separate, model-free job.