Skip to content

Commit 56b93f8

Browse files
vkuceravkucera
committed
Fix runtime/explicit
1 parent 1c88f9b commit 56b93f8

9 files changed

Lines changed: 24 additions & 23 deletions

File tree

‎ALICE3/Tasks/alice3DqEfficiency.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -775,7 +775,7 @@ struct Alice3DqEfficiencyAnalysisSameEventPairing {
775775
std::vector<MCSignal*> fGenMCSignals;
776776

777777
std::vector<AnalysisCompositeCut> fPairCuts;
778-
AnalysisCompositeCut fMCGenAccCut;
778+
AnalysisCompositeCut fMCGenAccCut{};
779779
bool fUseMCGenAccCut = false;
780780

781781
uint32_t fTrackFilterMask = 0; // mask for the track cuts required in this task to be applied on the barrel cuts produced upstream

‎PWGCF/TwoParticleCorrelations/Core/EventSelectionFilterAndAnalysis.h‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ class EventSelectionFilterAndAnalysis : public SelectionFilterAndAnalysis
8484

8585
private:
8686
struct ComplexBrickHelper {
87+
virtual ~ComplexBrickHelper() = default;
8788
CutBrick<float>* mBrick = nullptr;
8889
int mDefaultEstimatorIndex = -1;
8990
std::vector<int> mAlternateEstimatorIndex = std::vector<int>{};
@@ -95,15 +96,15 @@ class EventSelectionFilterAndAnalysis : public SelectionFilterAndAnalysis
9596
void armedBrick(uint64_t&, uint64_t&, uint64_t&, int&);
9697
};
9798
struct MultiplicityBrick : public ComplexBrickHelper {
98-
virtual void initialize();
99+
void initialize() override;
99100
std::vector<float> GetMultiplicities();
100101
int GetArmedIndex() { return mBrick->getArmedIndex(); }
101-
virtual bool Filter(uint64_t& mask, int& bit, CutBrick<float>* brick, int index);
102+
bool Filter(uint64_t& mask, int& bit, CutBrick<float>* brick, int index) override;
102103
};
103104
struct PileUpRejBrick : public ComplexBrickHelper {
104-
virtual void initialize();
105+
void initialize() override;
105106
std::vector<float> mIndepVar = std::vector<float>{};
106-
virtual bool Filter(uint64_t& mask, int& bit, CutBrick<float>* brick, int index);
107+
bool Filter(uint64_t& mask, int& bit, CutBrick<float>* brick, int index) override;
107108
};
108109

109110
static bool filterBrickValue(uint64_t& mask, int& bit, CutBrick<float>* brick, float value);

‎PWGCF/TwoParticleCorrelations/Core/SkimmingConfigurableCuts.h‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ class CutBrickLimit : public CutBrick<TValueToFilter>
110110
public:
111111
CutBrickLimit();
112112
CutBrickLimit(const char*, const TValueToFilter&);
113-
CutBrickLimit(const TString&);
113+
explicit CutBrickLimit(const TString&);
114114
~CutBrickLimit() override = default;
115115
CutBrickLimit(const CutBrickLimit&) = delete;
116116
CutBrickLimit& operator=(const CutBrickLimit&) = delete;
@@ -154,7 +154,7 @@ class CutBrickFnLimit : public CutBrickLimit<TValueToFilter>
154154
public:
155155
CutBrickFnLimit();
156156
CutBrickFnLimit(const char*, const TF1&);
157-
CutBrickFnLimit(const TString&);
157+
explicit CutBrickFnLimit(const TString&);
158158
~CutBrickFnLimit() override = default;
159159
CutBrickFnLimit(const CutBrickFnLimit&) = delete;
160160
CutBrickFnLimit& operator=(const CutBrickFnLimit&) = delete;
@@ -181,7 +181,7 @@ class CutBrickThreshold : public CutBrick<TValueToFilter>
181181
public:
182182
CutBrickThreshold();
183183
CutBrickThreshold(const char*, const TValueToFilter&);
184-
CutBrickThreshold(const TString&);
184+
explicit CutBrickThreshold(const TString&);
185185
~CutBrickThreshold() override = default;
186186
CutBrickThreshold(const CutBrickThreshold&) = delete;
187187
CutBrickThreshold& operator=(const CutBrickThreshold&) = delete;
@@ -225,7 +225,7 @@ class CutBrickFnThreshold : public CutBrickThreshold<TValueToFilter>
225225
public:
226226
CutBrickFnThreshold();
227227
CutBrickFnThreshold(const char*, const TF1&);
228-
CutBrickFnThreshold(const TString&);
228+
explicit CutBrickFnThreshold(const TString&);
229229
~CutBrickFnThreshold() override = default;
230230
CutBrickFnThreshold(const CutBrickFnThreshold&) = delete;
231231
CutBrickFnThreshold& operator=(const CutBrickFnThreshold&) = delete;
@@ -252,7 +252,7 @@ class CutBrickRange : public CutBrick<TValueToFilter>
252252
public:
253253
CutBrickRange();
254254
CutBrickRange(const char*, const TValueToFilter&, const TValueToFilter&);
255-
CutBrickRange(const TString&);
255+
explicit CutBrickRange(const TString&);
256256
~CutBrickRange() override = default;
257257
CutBrickRange(const CutBrickRange&) = delete;
258258
CutBrickRange& operator=(const CutBrickRange&) = delete;
@@ -297,7 +297,7 @@ class CutBrickFnRange : public CutBrickRange<TValueToFilter>
297297
public:
298298
CutBrickFnRange();
299299
CutBrickFnRange(const char*, const TF1&, const TF1&);
300-
CutBrickFnRange(const TString&);
300+
explicit CutBrickFnRange(const TString&);
301301
~CutBrickFnRange() override = default;
302302
CutBrickFnRange(const CutBrickFnRange&) = delete;
303303
CutBrickFnRange& operator=(const CutBrickFnRange&) = delete;
@@ -326,7 +326,7 @@ class CutBrickExtToRange : public CutBrick<TValueToFilter>
326326
public:
327327
CutBrickExtToRange();
328328
CutBrickExtToRange(const char*, const TValueToFilter&, const TValueToFilter&);
329-
CutBrickExtToRange(const TString&);
329+
explicit CutBrickExtToRange(const TString&);
330330
~CutBrickExtToRange() override = default;
331331
CutBrickExtToRange(const CutBrickExtToRange&) = delete;
332332
CutBrickExtToRange& operator=(const CutBrickExtToRange&) = delete;
@@ -371,7 +371,7 @@ class CutBrickFnExtToRange : public CutBrickExtToRange<TValueToFilter>
371371
public:
372372
CutBrickFnExtToRange();
373373
CutBrickFnExtToRange(const char*, const TF1&, const TF1&);
374-
CutBrickFnExtToRange(const TString&);
374+
explicit CutBrickFnExtToRange(const TString&);
375375
~CutBrickFnExtToRange() override = default;
376376
CutBrickFnExtToRange(const CutBrickFnExtToRange&) = delete;
377377
CutBrickFnExtToRange& operator=(const CutBrickFnExtToRange&) = delete;
@@ -402,7 +402,7 @@ class CutBrickSelectorMultipleRanges : public CutBrick<TValueToFilter>
402402
public:
403403
CutBrickSelectorMultipleRanges();
404404
CutBrickSelectorMultipleRanges(const char*, const std::vector<TValueToFilter>&);
405-
CutBrickSelectorMultipleRanges(const TString&);
405+
explicit CutBrickSelectorMultipleRanges(const TString&);
406406
~CutBrickSelectorMultipleRanges() override = default;
407407
CutBrickSelectorMultipleRanges(const CutBrickSelectorMultipleRanges&) = delete;
408408
CutBrickSelectorMultipleRanges& operator=(const CutBrickSelectorMultipleRanges&) = delete;
@@ -432,7 +432,7 @@ class CutWithVariations : public CutBrick<TValueToFilter>
432432
/// Default constructor
433433
CutWithVariations();
434434
CutWithVariations(const char*, const char*, bool);
435-
CutWithVariations(const TString&);
435+
explicit CutWithVariations(const TString&);
436436
~CutWithVariations() override = default;
437437
CutWithVariations(const CutWithVariations&) = delete;
438438
CutWithVariations& operator=(const CutWithVariations&) = delete;
@@ -510,7 +510,7 @@ class TrackSelectionBrick : public SpecialCutBrick
510510
{
511511
public:
512512
TrackSelectionBrick() = default;
513-
TrackSelectionBrick(const TString&);
513+
explicit TrackSelectionBrick(const TString&);
514514
~TrackSelectionBrick() override = default;
515515

516516
enum class TrackCuts : int {

‎PWGDQ/Core/AnalysisCompositeCut.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
class AnalysisCompositeCut : public AnalysisCut
2828
{
2929
public:
30-
AnalysisCompositeCut(bool useAND = kTRUE);
30+
explicit AnalysisCompositeCut(bool useAND = kTRUE);
3131
AnalysisCompositeCut(const char* name, const char* title, bool useAND = kTRUE);
3232
AnalysisCompositeCut(const AnalysisCompositeCut& c);
3333
AnalysisCompositeCut& operator=(const AnalysisCompositeCut& c);

‎PWGDQ/Tasks/dqEfficiency.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1369,7 +1369,7 @@ struct AnalysisDileptonTrackTrack {
13691369
float* fValuesQuadruplet = nullptr;
13701370

13711371
std::vector<TString> fQuadrupletCutNames;
1372-
AnalysisCompositeCut fDileptonCut;
1372+
AnalysisCompositeCut fDileptonCut{};
13731373
std::vector<AnalysisCompositeCut> fQuadrupletCuts;
13741374
TString fTrackCutName1;
13751375
TString fTrackCutName2;

‎PWGDQ/Tasks/tableReader.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2117,7 +2117,7 @@ struct AnalysisDileptonTrackTrack {
21172117
TString fTrackCutName1;
21182118
TString fTrackCutName2;
21192119
bool fIsSameTrackCut = false;
2120-
AnalysisCompositeCut fDileptonCut;
2120+
AnalysisCompositeCut fDileptonCut{};
21212121
std::vector<TString> fQuadrupletCutNames;
21222122
std::vector<AnalysisCompositeCut> fQuadrupletCuts;
21232123

‎PWGDQ/Tasks/tableReader_withAssoc.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4751,7 +4751,7 @@ struct AnalysisDileptonTrackTrack {
47514751
TString fTrackCutName1;
47524752
TString fTrackCutName2;
47534753
bool fIsSameTrackCut = false;
4754-
AnalysisCompositeCut fDileptonCut;
4754+
AnalysisCompositeCut fDileptonCut{};
47554755
std::vector<TString> fQuadrupletCutNames;
47564756
std::vector<AnalysisCompositeCut> fQuadrupletCuts;
47574757

‎PWGDQ/Tasks/tableReader_withAssoc_direct.cxx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1362,7 +1362,7 @@ struct AnalysisSameEventPairing {
13621362
std::map<int, std::vector<TString>> fTrackMuonHistNames; // for electron-muon pairs: key = iTrack * fNCutsMuon + iMuon
13631363

13641364
std::vector<AnalysisCompositeCut> fPairCuts;
1365-
AnalysisCompositeCut fMCGenAccCut;
1365+
AnalysisCompositeCut fMCGenAccCut{};
13661366
// bool fUseMCGenAccCut = false;
13671367

13681368
uint32_t fTrackFilterMask = 0; // mask for the track cuts required in this task to be applied on the barrel cuts produced upstream
@@ -1861,7 +1861,7 @@ struct AnalysisSameEventPairing {
18611861
for (unsigned int iPairCut = 0; iPairCut < fPairCuts.size(); iPairCut++) {
18621862
AnalysisCompositeCut cut = fPairCuts.at(iPairCut);
18631863
if (!cut.IsSelected(static_cast<float*>(VarManager::fgValues))) {
1864-
continue; // apply pair cuts
1864+
continue; // apply pair cuts
18651865
}
18661866
if (sign1 * sign2 < 0) { // opposite sign pairs
18671867
fHistMan->FillHistClass(histNames[ncuts + icut * fPairCuts.size() + iPairCut][0].Data(), static_cast<float*>(VarManager::fgValues));

‎PWGLF/TableProducer/Common/lfTPCPID.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ const std::string defaultOptions[nSpecies][nOptions]{{"", "", "false", "false"},
8989
// Structure to hold the parameters
9090
struct bbParams {
9191
const std::string name;
92-
bbParams(const std::string& n) : name(n) {}
92+
explicit bbParams(const std::string& n) : name(n) {}
9393
// Parameters for the Bethe-Bloch parametrization
9494
float bb1 = 0.03209809958934784f; // Aleph Bethe Bloch parameter 1
9595
float bb2 = 19.9768009185791f; // Aleph Bethe Bloch parameter 2

0 commit comments

Comments
 (0)