Skip to content

[GP-02] Allow specific extra-input in library parsing #263

Description

@tbittar

Affected Component

Library resolution (libs/)

Type of Change

Minor: bug fix or backward-compatible new feature (e.g. new operator)

Description

For the context see AntaresSimulatorTeam/AntaresLegacyModels-to-GEMS-Converter#90
The goal is to have a library both usable in GEMS studies and in hybrid studies without format change (as this file is a "cold" file, not updated in every study)

The parsing of library in gems_craft should allow the specific extra-inputs linked to the port declaration in the hybrid case, namely area-connection and all its subflelds (see the HybridPortTypeSchema)

In the full GEMS case, these extra-inputs are discarded directly, no verification of theses field value is needed. all other extra-inputs keeps being strictly forbidden

Results Impact

no impact on previous results

Validation Strategy

A library for hybrid studies should be parsed without errors in the full GEMS case

Process Checklist

Step 1 — Issue Creation

  • Issue created and linked to process GP-02

Step 2 — Triage

  • Process confirmed applicable
  • Assigned to responsible contributor
  • Priority and milestone set (if applicable)

Step 3 — Impact Analysis ⚠️ extended results analysis required

  • Affected modules identified
  • Results impact explicitly stated: change intended / no change intended
  • If results expected to change: before/after difference described and justified
  • Breaking vs backward-compatible change determined

Step 4 — Implementation

  • Code changes implemented
  • Backward compatibility maintained unless explicitly intended as breaking

Step 5 — Testing & Validation

  • If results expected to change: reference studies updated with new expected values
  • If results must not change: solver equivalence confirmed via tests
  • Unit tests cover changed components

Step 6 — CI Validation

  • Type checking passes (mypy)
  • Formatting passes (black, isort)
  • All tests pass in CI (pytest)

Step 7 — Review & Merge

  • PR reviewed; documentation changes included

Step 8 — Versioning

  • pyproject.toml version bumped

Step 9 — Supporting Files

  • AGENTS.md reviewed for impact and updated if needed

Step 10 — Release

  • If a release is needed: follow the release process in the Developer Guidelines

Metadata

Metadata

Assignees

No one assigned

    Labels

    GP-02Internal GemsPy bug fixes, features, or improvements (not driven by a GEMS Language release)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions