From ac577b525641c835654ffc659b4e97e54bf60617 Mon Sep 17 00:00:00 2001 From: Abhinandan Sharma Date: Wed, 21 Oct 2026 14:38:39 +0530 Subject: [PATCH 1/5] [MrBot] Stop including deprecated C compatibility headers in C++ Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- c_pal_ll/interfaces/reals/real_sync.h | 1 - interfaces/inc/c_pal/malloc_multi_flex.h | 1 - interfaces/inc/c_pal/srw_lock.h | 4 +--- interfaces/inc/c_pal/srw_lock_ll.h | 4 +--- interfaces/inc/c_pal/uuid.h | 2 -- interfaces/reals/real_srw_lock.h | 4 +--- interfaces/reals/real_srw_lock_ll.h | 4 +--- interfaces/reals/real_string_utils.h | 4 +--- 8 files changed, 5 insertions(+), 19 deletions(-) diff --git a/c_pal_ll/interfaces/reals/real_sync.h b/c_pal_ll/interfaces/reals/real_sync.h index 9e487474..d38dea4e 100644 --- a/c_pal_ll/interfaces/reals/real_sync.h +++ b/c_pal_ll/interfaces/reals/real_sync.h @@ -5,7 +5,6 @@ #define REAL_SYNC_H #ifdef __cplusplus -#include #include #else #include diff --git a/interfaces/inc/c_pal/malloc_multi_flex.h b/interfaces/inc/c_pal/malloc_multi_flex.h index 1c657837..c0f91225 100644 --- a/interfaces/inc/c_pal/malloc_multi_flex.h +++ b/interfaces/inc/c_pal/malloc_multi_flex.h @@ -6,7 +6,6 @@ #ifdef __cplusplus #include #include -#include #else #include #include diff --git a/interfaces/inc/c_pal/srw_lock.h b/interfaces/inc/c_pal/srw_lock.h index 79024f9e..acf903ed 100644 --- a/interfaces/inc/c_pal/srw_lock.h +++ b/interfaces/inc/c_pal/srw_lock.h @@ -3,9 +3,7 @@ #ifndef SRW_LOCK_H #define SRW_LOCK_H -#ifdef __cplusplus -#include -#else +#ifndef __cplusplus #include #endif diff --git a/interfaces/inc/c_pal/srw_lock_ll.h b/interfaces/inc/c_pal/srw_lock_ll.h index 08c9e323..499a1f2a 100644 --- a/interfaces/inc/c_pal/srw_lock_ll.h +++ b/interfaces/inc/c_pal/srw_lock_ll.h @@ -3,9 +3,7 @@ #ifndef SRW_LOCK_LL_H #define SRW_LOCK_LL_H -#ifdef __cplusplus -#include -#else +#ifndef __cplusplus #include #endif diff --git a/interfaces/inc/c_pal/uuid.h b/interfaces/inc/c_pal/uuid.h index 8708381a..405d127c 100644 --- a/interfaces/inc/c_pal/uuid.h +++ b/interfaces/inc/c_pal/uuid.h @@ -6,8 +6,6 @@ #ifdef __cplusplus #include -#include -#include #else #include #include diff --git a/interfaces/reals/real_srw_lock.h b/interfaces/reals/real_srw_lock.h index 9134f4fe..d7a6095c 100644 --- a/interfaces/reals/real_srw_lock.h +++ b/interfaces/reals/real_srw_lock.h @@ -4,9 +4,7 @@ #ifndef REAL_SRW_LOCK_H #define REAL_SRW_LOCK_H -#ifdef __cplusplus -#include -#else +#ifndef __cplusplus #include #endif diff --git a/interfaces/reals/real_srw_lock_ll.h b/interfaces/reals/real_srw_lock_ll.h index 017f68f0..24801ee9 100644 --- a/interfaces/reals/real_srw_lock_ll.h +++ b/interfaces/reals/real_srw_lock_ll.h @@ -4,9 +4,7 @@ #ifndef REAL_SRW_LOCK_LL_H #define REAL_SRW_LOCK_LL_H -#ifdef __cplusplus -#include -#else +#ifndef __cplusplus #include #endif diff --git a/interfaces/reals/real_string_utils.h b/interfaces/reals/real_string_utils.h index 910e2e17..20445e0b 100644 --- a/interfaces/reals/real_string_utils.h +++ b/interfaces/reals/real_string_utils.h @@ -4,9 +4,7 @@ #ifndef REAL_STRING_UTILS_H #define REAL_STRING_UTILS_H -#ifdef __cplusplus -#include -#else +#ifndef __cplusplus #include #endif From 0b4529f542db85c682025406723c6cba2ef83a99 Mon Sep 17 00:00:00 2001 From: Abhinandan Sharma Date: Wed, 21 Oct 2026 14:49:48 +0530 Subject: [PATCH 2/5] [MrBot] DO NOT MERGE: validate C++17 default from c-build-tools#471 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- deps/c-build-tools | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/c-build-tools b/deps/c-build-tools index e5ade18f..dbe21d0b 160000 --- a/deps/c-build-tools +++ b/deps/c-build-tools @@ -1 +1 @@ -Subproject commit e5ade18fce434f142d4e88060f0b893217e44ec1 +Subproject commit dbe21d0b4a1b43dd896ae2c243cbf685d85245e1 From ece10a32b291b859ba7e459ce93102526ffeda8d Mon Sep 17 00:00:00 2001 From: Abhinandan Sharma Date: Wed, 21 Oct 2026 15:06:08 +0530 Subject: [PATCH 3/5] [MrBot] Point pipeline c-build-tools refs at the validated SHA Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/workflows/two-human-reviewers.yml | 2 +- build/devops_gated.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/two-human-reviewers.yml b/.github/workflows/two-human-reviewers.yml index f8254d54..8882e394 100644 --- a/.github/workflows/two-human-reviewers.yml +++ b/.github/workflows/two-human-reviewers.yml @@ -45,6 +45,6 @@ jobs: two-human-reviewers: # Pin to a tag or commit SHA instead of a branch if you need the gate's behaviour to change only when # you choose to update it. - uses: Azure/c-build-tools/.github/workflows/two-human-reviewers.yml@e5ade18fce434f142d4e88060f0b893217e44ec1 + uses: Azure/c-build-tools/.github/workflows/two-human-reviewers.yml@dbe21d0b4a1b43dd896ae2c243cbf685d85245e1 with: pr: ${{ github.event.pull_request.number || inputs.pr }} diff --git a/build/devops_gated.yml b/build/devops_gated.yml index a92b5b21..3bd8e25c 100644 --- a/build/devops_gated.yml +++ b/build/devops_gated.yml @@ -22,7 +22,7 @@ resources: type: github name: azure/c-build-tools endpoint: github.com_azure - ref: e5ade18fce434f142d4e88060f0b893217e44ec1 + ref: dbe21d0b4a1b43dd896ae2c243cbf685d85245e1 jobs: - template: /pipeline_templates/build_all_flavors.yml@c_build_tools From 6839ab8875df9aa47cda863afff5dc2080c2c5c3 Mon Sep 17 00:00:00 2001 From: Abhinandan Sharma Date: Thu, 22 Oct 2026 13:15:33 +0530 Subject: [PATCH 4/5] [MrBot] Keep ifdef/else convention for C-only stdbool.h includes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- interfaces/inc/c_pal/srw_lock.h | 3 ++- interfaces/inc/c_pal/srw_lock_ll.h | 3 ++- interfaces/reals/real_srw_lock.h | 3 ++- interfaces/reals/real_srw_lock_ll.h | 3 ++- interfaces/reals/real_string_utils.h | 3 ++- 5 files changed, 10 insertions(+), 5 deletions(-) diff --git a/interfaces/inc/c_pal/srw_lock.h b/interfaces/inc/c_pal/srw_lock.h index acf903ed..c33802a0 100644 --- a/interfaces/inc/c_pal/srw_lock.h +++ b/interfaces/inc/c_pal/srw_lock.h @@ -3,7 +3,8 @@ #ifndef SRW_LOCK_H #define SRW_LOCK_H -#ifndef __cplusplus +#ifdef __cplusplus +#else #include #endif diff --git a/interfaces/inc/c_pal/srw_lock_ll.h b/interfaces/inc/c_pal/srw_lock_ll.h index 499a1f2a..2dd06197 100644 --- a/interfaces/inc/c_pal/srw_lock_ll.h +++ b/interfaces/inc/c_pal/srw_lock_ll.h @@ -3,7 +3,8 @@ #ifndef SRW_LOCK_LL_H #define SRW_LOCK_LL_H -#ifndef __cplusplus +#ifdef __cplusplus +#else #include #endif diff --git a/interfaces/reals/real_srw_lock.h b/interfaces/reals/real_srw_lock.h index d7a6095c..f1e82bb2 100644 --- a/interfaces/reals/real_srw_lock.h +++ b/interfaces/reals/real_srw_lock.h @@ -4,7 +4,8 @@ #ifndef REAL_SRW_LOCK_H #define REAL_SRW_LOCK_H -#ifndef __cplusplus +#ifdef __cplusplus +#else #include #endif diff --git a/interfaces/reals/real_srw_lock_ll.h b/interfaces/reals/real_srw_lock_ll.h index 24801ee9..b4500f19 100644 --- a/interfaces/reals/real_srw_lock_ll.h +++ b/interfaces/reals/real_srw_lock_ll.h @@ -4,7 +4,8 @@ #ifndef REAL_SRW_LOCK_LL_H #define REAL_SRW_LOCK_LL_H -#ifndef __cplusplus +#ifdef __cplusplus +#else #include #endif diff --git a/interfaces/reals/real_string_utils.h b/interfaces/reals/real_string_utils.h index 20445e0b..3735a150 100644 --- a/interfaces/reals/real_string_utils.h +++ b/interfaces/reals/real_string_utils.h @@ -4,7 +4,8 @@ #ifndef REAL_STRING_UTILS_H #define REAL_STRING_UTILS_H -#ifndef __cplusplus +#ifdef __cplusplus +#else #include #endif From 87fdeeab43d6eb84d84a8b1097fc5b829c75113a Mon Sep 17 00:00:00 2001 From: Abhinandan Sharma Date: Thu, 22 Oct 2026 23:34:12 +0530 Subject: [PATCH 5/5] [MrBot] Validate C++23 default from c-build-tools#471 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/workflows/two-human-reviewers.yml | 2 +- build/devops_gated.yml | 2 +- deps/c-build-tools | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/two-human-reviewers.yml b/.github/workflows/two-human-reviewers.yml index 8882e394..51f6aa41 100644 --- a/.github/workflows/two-human-reviewers.yml +++ b/.github/workflows/two-human-reviewers.yml @@ -45,6 +45,6 @@ jobs: two-human-reviewers: # Pin to a tag or commit SHA instead of a branch if you need the gate's behaviour to change only when # you choose to update it. - uses: Azure/c-build-tools/.github/workflows/two-human-reviewers.yml@dbe21d0b4a1b43dd896ae2c243cbf685d85245e1 + uses: Azure/c-build-tools/.github/workflows/two-human-reviewers.yml@d78d8f3b254fdef08300b4eebfbd5c848627eafe with: pr: ${{ github.event.pull_request.number || inputs.pr }} diff --git a/build/devops_gated.yml b/build/devops_gated.yml index 3bd8e25c..97f7f420 100644 --- a/build/devops_gated.yml +++ b/build/devops_gated.yml @@ -22,7 +22,7 @@ resources: type: github name: azure/c-build-tools endpoint: github.com_azure - ref: dbe21d0b4a1b43dd896ae2c243cbf685d85245e1 + ref: d78d8f3b254fdef08300b4eebfbd5c848627eafe jobs: - template: /pipeline_templates/build_all_flavors.yml@c_build_tools diff --git a/deps/c-build-tools b/deps/c-build-tools index dbe21d0b..d78d8f3b 160000 --- a/deps/c-build-tools +++ b/deps/c-build-tools @@ -1 +1 @@ -Subproject commit dbe21d0b4a1b43dd896ae2c243cbf685d85245e1 +Subproject commit d78d8f3b254fdef08300b4eebfbd5c848627eafe