From 9971331c2b09d5d9f796bed977742f7485290f1e Mon Sep 17 00:00:00 2001 From: Seun Akanni Date: Thu, 13 Aug 2026 15:01:15 +0100 Subject: [PATCH 1/5] val: finding context and coverage fields Revit repo specifically: ProjectParameter is version-conditional here, and BH.Revit.Engine.Core is the namespace #161 concerns, so both new fields should have something to say. Not for merge. --- .github/workflows/ci-beta.yml | 276 +++++++++++++------------- Revit_Core_Engine/Compute/Activate.cs | 2 + 2 files changed, 140 insertions(+), 138 deletions(-) diff --git a/.github/workflows/ci-beta.yml b/.github/workflows/ci-beta.yml index 5b30267e7..2d15359cd 100644 --- a/.github/workflows/ci-beta.yml +++ b/.github/workflows/ci-beta.yml @@ -1,138 +1,138 @@ -# Beta-tier proxy, BHoM variant. Bundles the tier's checks plus -# copyright-compliance (BHoM enforces OSS copyright; the BHE variant omits it). -# Copy to .github/workflows/ci-beta.yml in each BHoM beta repo. -# Runs on pull_request, non-blocking until a ruleset requires its checks. -# Workflow name CI keeps check contexts bare: required contexts are the job names. - -name: CI - -on: - pull_request: - branches: - - develop - -concurrency: - group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }} - cancel-in-progress: true - -jobs: - ci-build: - runs-on: windows-2025-vs2026 - timeout-minutes: 30 - steps: - - name: Run build - uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-build@develop - with: - app_id: ${{ secrets.BHOM_APP_ID }} - private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} - - ci-code-compliance: - runs-on: windows-2025-vs2026 - timeout-minutes: 20 - permissions: - contents: read - pull-requests: read - actions: write - steps: - - name: Run code compliance - uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-compliance@develop - with: - check_type: code - patterns: '*.cs' - app_id: ${{ secrets.BHOM_APP_ID }} - private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} - - ci-copyright-compliance: - runs-on: windows-2025-vs2026 - timeout-minutes: 20 - permissions: - contents: read - pull-requests: read - actions: write - steps: - - name: Run copyright compliance - uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-compliance@develop - with: - check_type: copyright - patterns: '*.cs' - app_id: ${{ secrets.BHOM_APP_ID }} - private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} - - ci-dataset-compliance: - runs-on: windows-2025-vs2026 - timeout-minutes: 20 - permissions: - contents: read - pull-requests: read - actions: write - steps: - - name: Run dataset compliance - uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-compliance@develop - with: - check_type: dataset - patterns: '**/*[Dd]atasets*/**/*.json **/*[Dd]atasets*.json' - app_id: ${{ secrets.BHOM_APP_ID }} - private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} - - ci-documentation-compliance: - runs-on: windows-2025-vs2026 - timeout-minutes: 20 - permissions: - contents: read - pull-requests: read - actions: write - steps: - - name: Run documentation compliance - uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-compliance@develop - with: - check_type: documentation - patterns: '*.cs' - app_id: ${{ secrets.BHOM_APP_ID }} - private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} - - ci-project-compliance: - runs-on: windows-2025-vs2026 - timeout-minutes: 20 - permissions: - contents: read - pull-requests: read - actions: write - steps: - - name: Run project compliance - uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-compliance@develop - with: - check_type: project - patterns: 'AssemblyInfo.cs *.csproj' - app_id: ${{ secrets.BHOM_APP_ID }} - private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} - - ci-dataset-tests: - runs-on: windows-2025-vs2026 - timeout-minutes: 30 - steps: - - name: Run dataset tests - uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-dataset-tests@develop - with: - app_id: ${{ secrets.BHOM_APP_ID }} - private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} - - ci-serialisation: - runs-on: windows-2025-vs2026 - timeout-minutes: 90 - steps: - - name: Run serialisation - uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-serialisation@develop - with: - app_id: ${{ secrets.BHOM_APP_ID }} - private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} - base_ref: ${{ github.base_ref }} - - ci-versioning: - runs-on: windows-2025-vs2026 - timeout-minutes: 90 - steps: - - name: Run versioning - uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-versioning@develop - with: - app_id: ${{ secrets.BHOM_APP_ID }} - private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} +# Beta-tier proxy, BHoM variant. Bundles the tier's checks plus +# copyright-compliance (BHoM enforces OSS copyright; the BHE variant omits it). +# Copy to .github/workflows/ci-beta.yml in each BHoM beta repo. +# Runs on pull_request, non-blocking until a ruleset requires its checks. +# Workflow name CI keeps check contexts bare: required contexts are the job names. + +name: CI + +on: + pull_request: + branches: + - develop + +concurrency: + group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }} + cancel-in-progress: true + +jobs: + ci-build: + runs-on: windows-2025-vs2026 + timeout-minutes: 30 + steps: + - name: Run build + uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-build@develop + with: + app_id: ${{ secrets.BHOM_APP_ID }} + private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} + + ci-code-compliance: + runs-on: windows-2025-vs2026 + timeout-minutes: 20 + permissions: + contents: read + pull-requests: read + actions: write + steps: + - name: Run code compliance + uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-compliance@develop + with: + check_type: code + patterns: '*.cs' + app_id: ${{ secrets.BHOM_APP_ID }} + private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} + + ci-copyright-compliance: + runs-on: windows-2025-vs2026 + timeout-minutes: 20 + permissions: + contents: read + pull-requests: read + actions: write + steps: + - name: Run copyright compliance + uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-compliance@develop + with: + check_type: copyright + patterns: '*.cs' + app_id: ${{ secrets.BHOM_APP_ID }} + private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} + + ci-dataset-compliance: + runs-on: windows-2025-vs2026 + timeout-minutes: 20 + permissions: + contents: read + pull-requests: read + actions: write + steps: + - name: Run dataset compliance + uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-compliance@develop + with: + check_type: dataset + patterns: '**/*[Dd]atasets*/**/*.json **/*[Dd]atasets*.json' + app_id: ${{ secrets.BHOM_APP_ID }} + private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} + + ci-documentation-compliance: + runs-on: windows-2025-vs2026 + timeout-minutes: 20 + permissions: + contents: read + pull-requests: read + actions: write + steps: + - name: Run documentation compliance + uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-compliance@develop + with: + check_type: documentation + patterns: '*.cs' + app_id: ${{ secrets.BHOM_APP_ID }} + private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} + + ci-project-compliance: + runs-on: windows-2025-vs2026 + timeout-minutes: 20 + permissions: + contents: read + pull-requests: read + actions: write + steps: + - name: Run project compliance + uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-compliance@develop + with: + check_type: project + patterns: 'AssemblyInfo.cs *.csproj' + app_id: ${{ secrets.BHOM_APP_ID }} + private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} + + ci-dataset-tests: + runs-on: windows-2025-vs2026 + timeout-minutes: 30 + steps: + - name: Run dataset tests + uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-dataset-tests@develop + with: + app_id: ${{ secrets.BHOM_APP_ID }} + private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} + + ci-serialisation: + runs-on: windows-2025-vs2026 + timeout-minutes: 90 + steps: + - name: Run serialisation + uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-serialisation@develop + with: + app_id: ${{ secrets.BHOM_APP_ID }} + private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} + base_ref: ${{ github.base_ref }} + + ci-versioning: + runs-on: windows-2025-vs2026 + timeout-minutes: 90 + steps: + - name: Run versioning + uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-versioning@feat/record-finding-context-and-coverage + with: + app_id: ${{ secrets.BHOM_APP_ID }} + private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} diff --git a/Revit_Core_Engine/Compute/Activate.cs b/Revit_Core_Engine/Compute/Activate.cs index bc85f0da1..21a17d7e0 100644 --- a/Revit_Core_Engine/Compute/Activate.cs +++ b/Revit_Core_Engine/Compute/Activate.cs @@ -51,3 +51,5 @@ public static void Activate(this ElementType elementType) + +// CI validation: finding context and coverage fields. Revert. From ae31cb82c6104c795fe98c7938c12968f2a95c70 Mon Sep 17 00:00:00 2001 From: Seun Akanni Date: Thu, 13 Aug 2026 15:21:05 +0100 Subject: [PATCH 2/5] val: re-run cold after the #194 hotfix From 810a16e7a6296b0c592d4eb9bb016eacb399e8f2 Mon Sep 17 00:00:00 2001 From: Seun Akanni Date: Thu, 13 Aug 2026 15:30:06 +0100 Subject: [PATCH 3/5] val: point at the internal-refs branch so prepare-runner builds the branch runner --- .github/workflows/ci-beta.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-beta.yml b/.github/workflows/ci-beta.yml index 2d15359cd..8a7504e3b 100644 --- a/.github/workflows/ci-beta.yml +++ b/.github/workflows/ci-beta.yml @@ -132,7 +132,7 @@ jobs: timeout-minutes: 90 steps: - name: Run versioning - uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-versioning@feat/record-finding-context-and-coverage + uses: BuroHappoldEngineeringAdmin/CI_Toolkit/.github/actions/ci-versioning@val/internal-refs-2 with: app_id: ${{ secrets.BHOM_APP_ID }} private_key: ${{ secrets.BHOM_APP_PRIVATE_KEY }} From d434ce6a69e3b95d751142244a9810f2ba1753c6 Mon Sep 17 00:00:00 2001 From: Seun Akanni Date: Thu, 13 Aug 2026 15:38:07 +0100 Subject: [PATCH 4/5] val: re-run with the empty-marker change From 82b95d2ee957c74a58b382b228343eda76e1b8ed Mon Sep 17 00:00:00 2001 From: Seun Akanni Date: Thu, 13 Aug 2026 15:43:11 +0100 Subject: [PATCH 5/5] val: re-run against the marker change