Skip to content

hardening(mactrack_view_macs): restrict unserialize() to scalar types to prevent object injection #316

Description

@somethingwithproof

Summary

mactrack_view_macs.php:91 calls unserialize() on a request parameter without restricting allowed classes. A crafted serialised object payload can instantiate arbitrary PHP classes. Line 214 in the same file already uses sanitize_unserialize_selected_items() — this fix brings line 91 to parity.

Details

Field Value
File mactrack_view_macs.php
Line 91
Auth required Yes — authenticated Cacti user
CWE CWE-502
// Before
$selected_items = unserialize(get_nfilter_request_var('selected_items'));

// After
$selected_items = unserialize(get_nfilter_request_var('selected_items'), ['allowed_classes' => false]);
if (!is_array($selected_items)) {
    $selected_items = [];
}

Fix applied in branch security/2-restrict-unserialize-mac-view.

Acceptance criteria

  • ['allowed_classes' => false] applied at line 91
  • Non-array result coerced to empty array
  • Regression test in tests/Security/UnserializeRegressionTest.php

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions