Skip to content

Integration tests depend on a floating reccaster:master tag #173

Description

@anderslindho

The recceiver integration tests pull reccaster from a mutable tag:

# server/tests/integration/resources/docker-compose/ioc-compose.yml
image: ghcr.io/channelfinder/reccaster:master

That image is republished on every push to reccaster's default branch, so the reference resolves to different content over time.

Moving these tests off build: ../client and onto a published image was an improvement; the only question is which tag we point at. While both projects lived in the same repository they advanced together, so "latest master" was a coherent thing to test against. Now that they version independently it no longer identifies a known counterpart, which means runs are not reproducible and a merge in reccaster can show up as a red build on an unrelated recceiver PR.

Could we either:

Either way it may be worth keeping a separate, non-blocking job on :master so drift still gets caught early. Happy to open the PR if there is a preference.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions