From 73be55de31157f697bd36f12007ab07b47054263 Mon Sep 17 00:00:00 2001 From: Krzysztof Malinowski Date: Fri, 2 Oct 2026 22:49:48 +0100 Subject: [PATCH] Fix profile selects sending string ids, which root folder save drops QualityProfileSelectInputConnector and MetadataProfileSelectInputConnector spread otherProps after their own onChange, so the parent's handler replaced the one that parses the id to a number. A profile picked from the dropdown reached state as a string, and the root folder save nulled it, failing with "A ebook quality profile is required". Fixes #279 Co-Authored-By: Claude Opus 5.5 --- .../src/Components/Form/MetadataProfileSelectInputConnector.js | 2 ++ .../src/Components/Form/QualityProfileSelectInputConnector.js | 2 ++ 2 files changed, 4 insertions(+) diff --git a/frontend/src/Components/Form/MetadataProfileSelectInputConnector.js b/frontend/src/Components/Form/MetadataProfileSelectInputConnector.js index 986bea6f..cad24fc3 100644 --- a/frontend/src/Components/Form/MetadataProfileSelectInputConnector.js +++ b/frontend/src/Components/Form/MetadataProfileSelectInputConnector.js @@ -161,6 +161,8 @@ class MetadataProfileSelectInputConnector extends Component { value, hasError, hasWarning, + // Pulled out so it can't override this.onChange, which parses the id to a number + onChange, ...otherProps } = this.props; diff --git a/frontend/src/Components/Form/QualityProfileSelectInputConnector.js b/frontend/src/Components/Form/QualityProfileSelectInputConnector.js index 93e7964f..079b9626 100644 --- a/frontend/src/Components/Form/QualityProfileSelectInputConnector.js +++ b/frontend/src/Components/Form/QualityProfileSelectInputConnector.js @@ -163,6 +163,8 @@ class QualityProfileSelectInputConnector extends Component { values, hasError, hasWarning, + // Pulled out so it can't override this.onChange, which parses the id to a number + onChange, ...otherProps } = this.props;