docs(flags): refresh capability migration TODOs

Author: btthomas

packages/core/src/flags/configuration/__tests__/rules.test.ts

@@ -200,8 +200,10 @@ describe('rules configuration', () => {
 
     // TODO(FFL-2837): Replace this legacy JSON compatibility test with a
     // generated protobuf fixture after a flagging-core release contains
-    // DataDog/openfeature-js-client#344 through `41dff20`. Round-trip the
+    // DataDog/openfeature-js-client#344 through `9f794c7`. Round-trip the
     // generated fixture and confirm that serialization preserves the unknown field.
+    // Add a fixture with an unsupported minimum feature level and require a
+    // flag-scoped `PARSE_ERROR`, not `FLAG_NOT_FOUND`.
     it('keeps supported known data when an unknown field is present', () => {
         const source = buildRulesConfiguration();
         (source.flags['dynamic-flag'] as typeof source.flags['dynamic-flag'] & {
@@ -228,7 +230,7 @@ describe('rules configuration', () => {
 
     // TODO(FFL-2837): Replace this unsafe JSON number with an out-of-range
     // protobuf `int64` fixture after flagging-core contains PR #344 at or after
-    // `41dff20` plus the no-`BigInt` follow-up. The generated parser must preserve
+    // `9f794c7` plus the no-`BigInt` follow-up. The generated parser must preserve
     // the source value as `bigint` where supported. Run the same evaluation with
     // global `BigInt` unavailable and require `PARSE_ERROR`, not `GENERAL`.
     it('returns PARSE_ERROR instead of serving an unsafe integer', () => {

packages/core/src/flags/configuration/rules.ts

@@ -14,7 +14,7 @@ import type { EvaluationContext, JsonValue, PrimitiveValue } from '../types';
 
 // TODO(FFL-2837): Replace this legacy UFC v1 alias with
 // `NonNullable<FlagsConfiguration['rules']>['response']` after a flagging-core
-// release contains DataDog/openfeature-js-client#344 through `41dff20`, restores
+// release contains DataDog/openfeature-js-client#344 through `9f794c7`, restores
 // 32-byte SHA digest validation, and defines or fixes integer evaluation without
 // global `BigInt`. Keep the `FlagsConfiguration` type import on the flagging-core
 // package root. PR #344 preserves protobuf integers as `bigint`, and its evaluator
@@ -130,7 +130,7 @@ const hasOwn = (value: object, key: PropertyKey): boolean =>
     Object.prototype.hasOwnProperty.call(value, key);
 
 // TODO(FFL-2837): Delete this compatibility error store after a flagging-core
-// release contains DataDog/openfeature-js-client#344 through `41dff20` and fixes
+// release contains DataDog/openfeature-js-client#344 through `9f794c7` and fixes
 // or explicitly excludes integer and shard evaluation without global `BigInt`.
 // The generated protobuf evaluator validates the requested flag and the data
 // that evaluation reaches. It does not build this error map during parsing.
@@ -210,7 +210,7 @@ const validateCondition = (value: unknown): string | undefined => {
             try {
                 // TODO(FFL-2837): Define a bounded regular expression policy before
                 // dynamic offline rules leave draft state. Upstream PR #344 through
-                // `41dff20` compiles protobuf regular expressions lazily and caches
+                // `9f794c7` compiles protobuf regular expressions lazily and caches
                 // them by configuration and index, but it does not limit patterns.
                 RegExp(value.value); // dd-iac-scan ignore-line
             } catch {
@@ -465,7 +465,7 @@ export const prepareRulesConfiguration = (
     const clone = cloneValue(value);
 
     // TODO(FFL-2837): Delete this legacy JSON clone and validator after a
-    // flagging-core release contains upstream PR #344 through `41dff20` and the
+    // flagging-core release contains upstream PR #344 through `9f794c7` and the
     // no-`BigInt` integer contract is fixed or declared unsupported. That
     // implementation preserves protobuf integers as `bigint` and validates only
     // the requested flag data that evaluation reaches. With `BigInt`, it returns a
@@ -521,7 +521,7 @@ const normalizeVariationType = (
 
 // TODO(FFL-2837): Delete this legacy UFC v1 metadata fallback after the
 // flagging-core dependency contains DataDog/openfeature-js-client#344 through
-// `41dff20`. The protobuf evaluator maps only safely represented integer
+// `9f794c7`. The protobuf evaluator maps only safely represented integer
 // variations, and all numeric variations, to the OpenFeature type `number`.
 const recoverVariationType = (
     configuration: RulesConfigurationResponse,
@@ -548,7 +548,7 @@ export const flaggingCoreRulesEngine: RulesEngine = {
 
         // TODO(FFL-2837): Delete this local compatibility guard after the
         // flagging-core dependency contains DataDog/openfeature-js-client#344
-        // through `41dff20`. Keep the reserved-name contract tests.
+        // through `9f794c7`. Keep the reserved-name contract tests.
         if (!hasOwn(flags, request.flagKey)) {
             return {
                 value: request.defaultValue,
@@ -559,9 +559,10 @@ export const flaggingCoreRulesEngine: RulesEngine = {
         }
 
         // TODO(FFL-2837): Delete this compatibility check with the local error
-        // store after the published PR #344 evaluator through `41dff20` validates
-        // reached flag data and reports deterministic errors, including unsafe
-        // integer conversions with and without global `BigInt` when supported.
+        // store after the published PR #344 evaluator through `9f794c7` validates
+        // reached flag data and reports deterministic flag-scoped errors, including
+        // unsupported feature levels and unsafe integer conversions with and
+        // without global `BigInt` when supported.
         const configurationError = errorsByConfiguration
             .get(request.configuration)
             ?.get(request.flagKey);

packages/core/src/flags/configuration/wire.ts

@@ -23,15 +23,19 @@ import type {
 
 // TODO(FFL-2837): Delete the pending `rulesBased` types, reader, and wrappers
 // after a flagging-core release contains DataDog/openfeature-js-client#344
-// through `41dff20` plus the required SHA digest and no-`BigInt` follow-ups.
+// through `9f794c7` plus the required SHA digest and no-`BigInt` follow-ups.
 // Import and re-export the wire functions and `FlagsConfigurationWire` type from
 // `@datadog/flagging-core/configuration`. Keep `FlagsConfiguration` and the rules
-// evaluator on the package root. Use `FlagsConfiguration.rules`. The distribution
-// layer must put one base64 encoding of the raw dd-source#34959 protobuf response
-// in the version 1 `rules.response` field. Do not add that service transport or
-// envelope construction here. PR #344 preserves decoded protobuf flags and
-// protobuf integers. Its evaluator reports invalid reached data and unsafe
-// integer conversion as deterministic `PARSE_ERROR` results.
+// evaluator on the package root. The new `@datadog/flagging-core/precomputed`
+// subpath is protobuf-free, ignores rules, and is not the parser for this module.
+// Use `FlagsConfiguration.rules`. The distribution layer must put one base64
+// encoding of the raw dd-source#34959 protobuf response in the version 1
+// `rules.response` field. Record dd-source#40304 commit `071c4ad` as the schema
+// revision and dd-source#34959 as the service producer path. Do not add that
+// service transport or envelope construction here. PR #344 preserves decoded
+// protobuf flags and integers. Its evaluator reports invalid reached data,
+// unsupported feature levels, and unsafe integer conversion as deterministic
+// flag-scoped `PARSE_ERROR` results.
 type PendingRulesConfiguration = FlagsConfiguration & {
     rulesBased?: {
         response: UniversalFlagConfigurationV1;
@@ -83,7 +87,7 @@ export const configurationFromString = (source: string): FlagsConfiguration => {
     // validator that PR #344 removed in favor of the Protobuf-ES decoder. The
     // published parser must also include PR #344's unknown-field tolerance,
     // unknown-field serialization, and lossless integer parsing through
-    // `41dff20`, plus the final no-`BigInt` runtime decision.
+    // `9f794c7`, plus the final no-`BigInt` runtime decision.
     const pendingRules = readPendingRulesWire(source);
     if (pendingRules) {
         try {
@@ -108,7 +112,7 @@ export const configurationToString = (
     const pendingConfiguration = configuration as PendingRulesConfiguration;
 
     // TODO(FFL-2837): Delete this legacy serialization wrapper with the pending
-    // types above after the dependency contains PR #344 through `41dff20` and
+    // types above after the dependency contains PR #344 through `9f794c7` and
     // its required follow-ups. The upstream serializer encodes generated protobuf
     // rules back to base64 and preserves unknown protobuf fields.
     // This temporary UFC v1 shim serializes its legacy JSON response instead.