test(flags): preserve unknown rules fields

Author: btthomas

packages/core/src/flags/configuration/__tests__/rules.test.ts

@@ -200,7 +200,8 @@ describe('rules configuration', () => {
 
     // TODO(FFL-2837): Replace this legacy JSON compatibility test with a
     // generated protobuf fixture after a flagging-core release contains
-    // DataDog/openfeature-js-client#344 through `41dff20`.
+    // DataDog/openfeature-js-client#344 through `41dff20`. Round-trip the
+    // generated fixture and confirm that serialization preserves the unknown field.
     it('keeps supported known data when an unknown field is present', () => {
         const source = buildRulesConfiguration();
         (source.flags['dynamic-flag'] as typeof source.flags['dynamic-flag'] & {
@@ -227,7 +228,9 @@ describe('rules configuration', () => {
 
     // TODO(FFL-2837): Replace this unsafe JSON number with an out-of-range
     // protobuf `int64` fixture after flagging-core contains PR #344 at or after
-    // `41dff20`. The generated parser must preserve the source value as `bigint`.
+    // `41dff20` plus the no-`BigInt` follow-up. The generated parser must preserve
+    // the source value as `bigint` where supported. Run the same evaluation with
+    // global `BigInt` unavailable and require `PARSE_ERROR`, not `GENERAL`.
     it('returns PARSE_ERROR instead of serving an unsafe integer', () => {
         const source = buildRulesConfiguration();
         const flag = source.flags['dynamic-flag'];

packages/core/src/flags/configuration/__tests__/wire.test.ts

@@ -165,9 +165,15 @@ describe('temporary rules configuration wire compatibility', () => {
     });
 
     it('round-trips a legacy rules configuration', () => {
+        const response = buildRulesConfiguration() as ReturnType<
+            typeof buildRulesConfiguration
+        > & {
+            futureField?: { value: number };
+        };
+        response.futureField = { value: 7 };
         const original = {
             rulesBased: {
-                response: buildRulesConfiguration(),
+                response,
                 fetchedAt: 123,
                 etag: 'rules-etag'
             }

packages/core/src/flags/configuration/rules.ts

@@ -14,10 +14,12 @@ import type { EvaluationContext, JsonValue, PrimitiveValue } from '../types';
 
 // TODO(FFL-2837): Replace this legacy UFC v1 alias with
 // `NonNullable<FlagsConfiguration['rules']>['response']` after a flagging-core
-// release contains DataDog/openfeature-js-client#344 through `41dff20`. Keep the
-// `FlagsConfiguration` type import on the flagging-core package root. PR #344
-// preserves protobuf integers as `bigint`, and its evaluator reports unsafe
-// conversions as deterministic per-flag `PARSE_ERROR` results.
+// release contains DataDog/openfeature-js-client#344 through `41dff20`, restores
+// 32-byte SHA digest validation, and defines or fixes integer evaluation without
+// global `BigInt`. Keep the `FlagsConfiguration` type import on the flagging-core
+// package root. PR #344 preserves protobuf integers as `bigint`, and its evaluator
+// reports unsafe conversions as deterministic per-flag `PARSE_ERROR` results when
+// `BigInt` is available.
 type RulesConfigurationResponse = UniversalFlagConfigurationV1;
 
 export type RulesValueType = 'boolean' | 'string' | 'number' | 'object';
@@ -128,7 +130,8 @@ const hasOwn = (value: object, key: PropertyKey): boolean =>
     Object.prototype.hasOwnProperty.call(value, key);
 
 // TODO(FFL-2837): Delete this compatibility error store after a flagging-core
-// release contains DataDog/openfeature-js-client#344 through `41dff20`.
+// release contains DataDog/openfeature-js-client#344 through `41dff20` and fixes
+// or explicitly excludes integer and shard evaluation without global `BigInt`.
 // The generated protobuf evaluator validates the requested flag and the data
 // that evaluation reaches. It does not build this error map during parsing.
 // It returns deterministic `PARSE_ERROR` results, including for an integer that
@@ -462,10 +465,11 @@ export const prepareRulesConfiguration = (
     const clone = cloneValue(value);
 
     // TODO(FFL-2837): Delete this legacy JSON clone and validator after a
-    // flagging-core release contains upstream PR #344 through `41dff20`. That
+    // flagging-core release contains upstream PR #344 through `41dff20` and the
+    // no-`BigInt` integer contract is fixed or declared unsupported. That
     // implementation preserves protobuf integers as `bigint` and validates only
-    // the requested flag data that evaluation reaches. It returns a deterministic
-    // per-flag error when evaluation cannot produce a safe JavaScript number.
+    // the requested flag data that evaluation reaches. With `BigInt`, it returns a
+    // deterministic per-flag error when evaluation cannot produce a safe number.
     // Do not adapt this validator to the generated response type.
     const errorMessage = validateRulesConfigurationEnvelope(clone);
     if (errorMessage) {
@@ -557,7 +561,7 @@ export const flaggingCoreRulesEngine: RulesEngine = {
         // TODO(FFL-2837): Delete this compatibility check with the local error
         // store after the published PR #344 evaluator through `41dff20` validates
         // reached flag data and reports deterministic errors, including unsafe
-        // integer conversions.
+        // integer conversions with and without global `BigInt` when supported.
         const configurationError = errorsByConfiguration
             .get(request.configuration)
             ?.get(request.flagKey);

packages/core/src/flags/configuration/wire.ts

@@ -23,7 +23,7 @@ import type {
 
 // TODO(FFL-2837): Delete the pending `rulesBased` types, reader, and wrappers
 // after a flagging-core release contains DataDog/openfeature-js-client#344
-// through `41dff20`.
+// through `41dff20` plus the required SHA digest and no-`BigInt` follow-ups.
 // Import and re-export the wire functions and `FlagsConfigurationWire` type from
 // `@datadog/flagging-core/configuration`. Keep `FlagsConfiguration` and the rules
 // evaluator on the package root. Use `FlagsConfiguration.rules`. The distribution
@@ -81,8 +81,9 @@ export const configurationFromString = (source: string): FlagsConfiguration => {
     // generated Protobuf-ES message. Do not adapt this shim to decode a raw
     // service response or to add a base64 layer. Do not copy the strict base64
     // validator that PR #344 removed in favor of the Protobuf-ES decoder. The
-    // published parser must also include PR #344's unknown-field tolerance and
-    // lossless integer parsing through `41dff20`.
+    // published parser must also include PR #344's unknown-field tolerance,
+    // unknown-field serialization, and lossless integer parsing through
+    // `41dff20`, plus the final no-`BigInt` runtime decision.
     const pendingRules = readPendingRulesWire(source);
     if (pendingRules) {
         try {
@@ -107,8 +108,9 @@ export const configurationToString = (
     const pendingConfiguration = configuration as PendingRulesConfiguration;
 
     // TODO(FFL-2837): Delete this legacy serialization wrapper with the pending
-    // types above after the dependency contains PR #344 through `41dff20`.
-    // The upstream serializer encodes generated protobuf rules back to base64.
+    // types above after the dependency contains PR #344 through `41dff20` and
+    // its required follow-ups. The upstream serializer encodes generated protobuf
+    // rules back to base64 and preserves unknown protobuf fields.
     // This temporary UFC v1 shim serializes its legacy JSON response instead.
     if (pendingConfiguration.rulesBased) {
         const serialized = JSON.parse(