From 9ba26b3a6ca5ceb6b25f6583624986c2def07b20 Mon Sep 17 00:00:00 2001 From: Tristan Partin Date: Tue, 20 Oct 2026 09:28:14 +0000 Subject: [PATCH] Define TAP_TESTS before including PGXS pgxs.mk only defines the TAP test rules, such as the prove step of installcheck, when TAP_TESTS is already set. The Makefile set it after including PGXS, so "make installcheck" never ran the tests in t/. Move the assignment above the include. Signed-off-by: Tristan Partin --- Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 51a1386..f80ddd3 100644 --- a/Makefile +++ b/Makefile @@ -4,6 +4,10 @@ PGFILEDESC = "pg_tracing - Distributed Tracing for PostgreSQL" SHLIB_LINK = -lcurl PG_CFLAGS = -Werror +# Must be set before including PGXS, which only defines the TAP test targets +# (prove_installcheck, installcheck) when TAP_TESTS is set. +TAP_TESTS = 1 + include common.mk OBJS = \ @@ -61,7 +65,6 @@ REGRESSCHECKS += sample planstate planstate_bitmap planstate_hash \ planstate_union parallel subxact full_buffer \ guc nested wal cleanup -TAP_TESTS = 1 regresscheck_noinstall: $(pg_regress_check) $(REGRESSCHECKS_OPTS) $(REGRESSCHECKS) || \