Noticed in the BlanketCon 23 pack with Dark Amaranth Fungus from Promenade, but not reporting there as it's not important for the con.
Due to a change in the signature of isFertilizable the method in DawnFungusBlock is no longer an override. As such, it falls back to the super implementation — which always fails due to passing null for the nylium argument in the constructor. This is easily checked by decompiling the resulting DawnAPI jar and noting that the method is not reobfuscated to method_9651 as it should be. The method now takes WorldView rather than BlockView.
This exact issue is what @Override is meant to catch — you should tag every single method that overrides a super with it so you're alerted with a compile error if the name or signature of the method you're overriding changes.
Noticed in the BlanketCon 23 pack with Dark Amaranth Fungus from Promenade, but not reporting there as it's not important for the con.
Due to a change in the signature of isFertilizable the method in DawnFungusBlock is no longer an override. As such, it falls back to the super implementation — which always fails due to passing
nullfor thenyliumargument in the constructor. This is easily checked by decompiling the resulting DawnAPI jar and noting that the method is not reobfuscated tomethod_9651as it should be. The method now takesWorldViewrather thanBlockView.This exact issue is what
@Overrideis meant to catch — you should tag every single method that overrides a super with it so you're alerted with a compile error if the name or signature of the method you're overriding changes.