Skip to content

Unify duplicate windows-sys versions to fix cargo-deny bans check #179

Description

@unclesp1d3r

Context

Surfaced during #177 but pre-existing on main and unrelated to MSVC demangling.

cargo deny check bans fails on a duplicate windows-sys:

  • 0.59.0 pulled via fs4 -> mmap-guard
  • 0.61.2 from the rest of the tree

deny.toml sets multiple-versions = "deny", so this duplicate trips the bans check.

Why this needs its own change

  • It is not introduced by any feature work; msvc-demangler adds no new duplicates.
  • It must not be masked with a deny.toml skip entry -- a skip would also swallow any genuinely-new windows-sys duplicate a future PR introduces, planting a latent supply-chain hole.
  • security.yml (which runs cargo deny) triggers on workflow_run/schedule/workflow_dispatch, not on pull_request, so this failure only shows on scheduled/post-merge runs, not PR status checks.

The fix

Unify windows-sys to a single version by bumping the dependency that pins the old one:

  • Investigate whether mmap-guard / fs4 have releases that depend on windows-sys 0.61.x.
  • Bump mmap-guard (and/or fs4) accordingly, then confirm cargo deny check bans passes.
  • If no compatible upstream release exists yet, track upstream and revisit.

Verify

just deny    # cargo deny check -- bans section must pass
cargo tree -d -i windows-sys   # should show a single version

Metadata

Metadata

Assignees

No one assigned

    Labels

    cidependenciesPull requests that update a dependency filesecuritysize:SThis PR changes 10-29 lines, ignoring generated files.status:backlogTask in backlog

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions