Context
Surfaced during #177 but pre-existing on main and unrelated to MSVC demangling.
cargo deny check bans fails on a duplicate windows-sys:
0.59.0 pulled via fs4 -> mmap-guard
0.61.2 from the rest of the tree
deny.toml sets multiple-versions = "deny", so this duplicate trips the bans check.
Why this needs its own change
- It is not introduced by any feature work;
msvc-demangler adds no new duplicates.
- It must not be masked with a
deny.toml skip entry -- a skip would also swallow any genuinely-new windows-sys duplicate a future PR introduces, planting a latent supply-chain hole.
security.yml (which runs cargo deny) triggers on workflow_run/schedule/workflow_dispatch, not on pull_request, so this failure only shows on scheduled/post-merge runs, not PR status checks.
The fix
Unify windows-sys to a single version by bumping the dependency that pins the old one:
- Investigate whether
mmap-guard / fs4 have releases that depend on windows-sys 0.61.x.
- Bump
mmap-guard (and/or fs4) accordingly, then confirm cargo deny check bans passes.
- If no compatible upstream release exists yet, track upstream and revisit.
Verify
just deny # cargo deny check -- bans section must pass
cargo tree -d -i windows-sys # should show a single version
Context
Surfaced during #177 but pre-existing on
mainand unrelated to MSVC demangling.cargo deny check bansfails on a duplicatewindows-sys:0.59.0pulled viafs4 -> mmap-guard0.61.2from the rest of the treedeny.tomlsetsmultiple-versions = "deny", so this duplicate trips the bans check.Why this needs its own change
msvc-demangleradds no new duplicates.deny.tomlskip entry -- a skip would also swallow any genuinely-newwindows-sysduplicate a future PR introduces, planting a latent supply-chain hole.security.yml(which runscargo deny) triggers onworkflow_run/schedule/workflow_dispatch, not onpull_request, so this failure only shows on scheduled/post-merge runs, not PR status checks.The fix
Unify
windows-systo a single version by bumping the dependency that pins the old one:mmap-guard/fs4have releases that depend onwindows-sys 0.61.x.mmap-guard(and/orfs4) accordingly, then confirmcargo deny check banspasses.Verify