From 2bf148507702703fef629626ce98e9aa3c58b61c Mon Sep 17 00:00:00 2001 From: Kyle Knoepfel Date: Fri, 26 Jun 2026 08:45:00 -0500 Subject: [PATCH] Fix workflow-dispatch action triggering of code-coverage coverage-upload was missing setup in its needs list and was missing ref: and repository: in its checkout step. Without those, on a workflow_dispatch run where main advances between the coverage job starting and the coverage-upload job starting (which happened in PR #668), the upload job checks out a different commit than the one coverage was actually measured on. Codecov then tries to upload for that wrong commit SHA, which it has no record of, producing the 404. --- .github/workflows/coverage.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/coverage.yaml b/.github/workflows/coverage.yaml index f9b2c4fc8..a9f2791f7 100644 --- a/.github/workflows/coverage.yaml +++ b/.github/workflows/coverage.yaml @@ -374,7 +374,7 @@ jobs: retention-days: 30 coverage-upload: - needs: coverage + needs: [setup, coverage] if: ${{ needs.coverage.result == 'success' && needs.coverage.outputs.artifact_upload_available == 'true' && github.actor != 'nektos/act' }} @@ -386,6 +386,8 @@ jobs: - name: Check out source code for Codecov mapping uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 with: + ref: ${{ needs.setup.outputs.ref }} + repository: ${{ needs.setup.outputs.repo }} fetch-depth: 0 - name: Download coverage bundle