Summary
The desktop crate's browser webview creation path emits an unused_mut warning in Windows release builds.
cargo check --release -p bitfun-desktop on main reports:
src/apps/desktop/src/api/browser_api.rs:145:9 — unused_mut: let mut builder in browser_webview_create, with the note "variable does not need to be mutable".
The WebviewBuilder binding is declared mut unconditionally, but its only mutating call — builder.devtools(true) — is compiled solely under #[cfg(any(debug_assertions, feature = "devtools"))]. In a release build without the devtools feature the mutation is compiled out, so the mut requirement disappears and the compiler flags the binding. Debug and devtools-enabled builds do not warn, which is why the warning only shows up in release-mode checks.
Area
Desktop app
Reproduction or evidence
- On Windows, check out main and run
cargo check --release -p bitfun-desktop.
- Observe:
warning: variable does not need to be mutable --> src\apps\desktop\src\api\browser_api.rs:145:9.
- Run
cargo check -p bitfun-desktop (dev profile): the same binding compiles without the warning, since the cfg block is active there.
A scoped fix exists and is ready to submit: shadow the builder inside the cfg block (immutable outer binding + local mut rebind), which removes the warning in every build configuration with zero behavior change. PR to follow referencing this issue.
Summary
The desktop crate's browser webview creation path emits an
unused_mutwarning in Windows release builds.cargo check --release -p bitfun-desktopon main reports:src/apps/desktop/src/api/browser_api.rs:145:9—unused_mut:let mut builderinbrowser_webview_create, with the note "variable does not need to be mutable".The
WebviewBuilderbinding is declaredmutunconditionally, but its only mutating call —builder.devtools(true)— is compiled solely under#[cfg(any(debug_assertions, feature = "devtools"))]. In a release build without the devtools feature the mutation is compiled out, so themutrequirement disappears and the compiler flags the binding. Debug and devtools-enabled builds do not warn, which is why the warning only shows up in release-mode checks.Area
Desktop app
Reproduction or evidence
cargo check --release -p bitfun-desktop.warning: variable does not need to be mutable --> src\apps\desktop\src\api\browser_api.rs:145:9.cargo check -p bitfun-desktop(dev profile): the same binding compiles without the warning, since the cfg block is active there.A scoped fix exists and is ready to submit: shadow the builder inside the cfg block (immutable outer binding + local
mutrebind), which removes the warning in every build configuration with zero behavior change. PR to follow referencing this issue.