From da0955c7f3a28af85de608f89a573be763810510 Mon Sep 17 00:00:00 2001 From: Matthew Shepherd Date: Wed, 2 Sep 2026 16:40:37 -0400 Subject: [PATCH 1/3] remove unnecessary header --- src/libraries/AMPTOOLS_AMPS/Vec_ps_refl.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/libraries/AMPTOOLS_AMPS/Vec_ps_refl.cc b/src/libraries/AMPTOOLS_AMPS/Vec_ps_refl.cc index d6aa7225a..8654ce025 100644 --- a/src/libraries/AMPTOOLS_AMPS/Vec_ps_refl.cc +++ b/src/libraries/AMPTOOLS_AMPS/Vec_ps_refl.cc @@ -127,8 +127,6 @@ #include "AMPTOOLS_AMPS/barrierFactor.h" #include "IUAmpTools/report.h" -#include "UTILITIES/BeamProperties.h" - //~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ //....oooOO0OOooo........ Helper Functions ........oooOO0OOooo..... //~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ From 23726fde3403d4d6d36a4dc5cc50b8fa33c6570f Mon Sep 17 00:00:00 2001 From: Matthew Shepherd Date: Wed, 2 Sep 2026 16:42:31 -0400 Subject: [PATCH 2/3] make return value of areUserVarsStatic variable depending on whether the polarization is stored in the data file or not - this generates the correct behavior for the current implementation of the class --- src/libraries/AMPTOOLS_AMPS/Zlm.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/libraries/AMPTOOLS_AMPS/Zlm.h b/src/libraries/AMPTOOLS_AMPS/Zlm.h index 20c1aa8e9..aa08b3e2a 100644 --- a/src/libraries/AMPTOOLS_AMPS/Zlm.h +++ b/src/libraries/AMPTOOLS_AMPS/Zlm.h @@ -51,8 +51,11 @@ class Zlm : public UserAmplitude< Zlm > // the framework to purge the four-vectors bool needsUserVarsOnly() const { return true; } - // the user variables above are the same for all instances of this amplitude - bool areUserVarsStatic() const { return true; } + // are the user variables above are the same for all instances of this amplitude? + // this is true if the polarization is embedded in the data file, but it + // is not true if, for example, pGamma is computed from polarization angle + // and fraction that are passed as arguments to the amplitude + bool areUserVarsStatic() const { return m_polInTree; } #ifdef GPU_ACCELERATION From 2331a0da6bd8520d9fefa217f3a282ea7fbb8f2f Mon Sep 17 00:00:00 2001 From: Matthew Shepherd Date: Wed, 2 Sep 2026 16:52:29 -0400 Subject: [PATCH 3/3] Fix typo in comment about user variables Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- src/libraries/AMPTOOLS_AMPS/Zlm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/AMPTOOLS_AMPS/Zlm.h b/src/libraries/AMPTOOLS_AMPS/Zlm.h index aa08b3e2a..8224f4c74 100644 --- a/src/libraries/AMPTOOLS_AMPS/Zlm.h +++ b/src/libraries/AMPTOOLS_AMPS/Zlm.h @@ -51,7 +51,7 @@ class Zlm : public UserAmplitude< Zlm > // the framework to purge the four-vectors bool needsUserVarsOnly() const { return true; } - // are the user variables above are the same for all instances of this amplitude? + // are the user variables above the same for all instances of this amplitude? // this is true if the polarization is embedded in the data file, but it // is not true if, for example, pGamma is computed from polarization angle // and fraction that are passed as arguments to the amplitude