From 07b3cce29ab32d86c7672b047c28eb04b6bec98e Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 22 Oct 2026 04:41:53 +0000 Subject: [PATCH] fix(macos): register the welcome account-choice parity surface The onboarding capture exports onboarding-welcome-account-choice, but the name was not a ParityCaptureSurface, so the debug URL never parsed and the export timed out. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01GKHjv2HDx1DFAnG4cfSxcr --- .../Sources/CompassKit/Layout/ParityCaptureSurface.swift | 1 + .../CompassKitTests/DesktopDebugCommandTests.swift | 4 ++++ docs/features/desktop-web-parity-checklist.md | 1 + 3 files changed, 6 insertions(+) diff --git a/apps/calendar-macos/CompassKit/Sources/CompassKit/Layout/ParityCaptureSurface.swift b/apps/calendar-macos/CompassKit/Sources/CompassKit/Layout/ParityCaptureSurface.swift index e4ea81e82..b656dedb0 100644 --- a/apps/calendar-macos/CompassKit/Sources/CompassKit/Layout/ParityCaptureSurface.swift +++ b/apps/calendar-macos/CompassKit/Sources/CompassKit/Layout/ParityCaptureSurface.swift @@ -15,6 +15,7 @@ public enum ParityCaptureSurface: String, CaseIterable, Sendable { case commandPalette = "command-palette" case settings = "settings" case onboardingWelcome = "onboarding-welcome" + case onboardingWelcomeAccountChoice = "onboarding-welcome-account-choice" public static func isValid(_ name: String) -> Bool { ParityCaptureSurface(rawValue: name) != nil diff --git a/apps/calendar-macos/CompassKitTests/DesktopDebugCommandTests.swift b/apps/calendar-macos/CompassKitTests/DesktopDebugCommandTests.swift index 0825b9d98..ed6367d82 100644 --- a/apps/calendar-macos/CompassKitTests/DesktopDebugCommandTests.swift +++ b/apps/calendar-macos/CompassKitTests/DesktopDebugCommandTests.swift @@ -59,6 +59,10 @@ final class DesktopDebugCommandTests: XCTestCase { XCTAssertEqual( DesktopDebugCommand.parse("compass://debug/parity-export-title-bar-reference"), .parityExportTitleBarReference) + // Every name NativeParityCaptureTests exports must parse, or the export times out. + XCTAssertEqual( + DesktopDebugCommand.parse("compass://debug/parity-export?name=onboarding-welcome-account-choice"), + .parityExport(surface: "onboarding-welcome-account-choice")) XCTAssertNil(DesktopDebugCommand.parse("compass://debug/parity-export?name=not-a-surface")) XCTAssertNil(DesktopDebugCommand.parse("compass://debug/unknown")) diff --git a/docs/features/desktop-web-parity-checklist.md b/docs/features/desktop-web-parity-checklist.md index c5a70fb3b..d2ff6494c 100644 --- a/docs/features/desktop-web-parity-checklist.md +++ b/docs/features/desktop-web-parity-checklist.md @@ -341,6 +341,7 @@ Each PR should link a child issue, include before/after screenshots (web Chromiu | 2026-10-21 | Hold-Mod sidebar chips: month picker and Up next chips render, calendar list chip moved onto the list (compare run 39634795849) | | 2026-10-21 | Per-account page-jump targets (web `calendar-account:` ids) | | 2026-10-21 | Event jump chips use web day-prefix labels (W1, SU2) and digits after a day pick | +| 2026-10-22 | macOS capture: register `onboarding-welcome-account-choice` so the welcome account step exports instead of timing out | ---