From ae7701b6e08ab60b2a9dec082542e02671784cbd Mon Sep 17 00:00:00 2001
From: Marty Pradere <martyp@labkey.com>
Date: Tue, 8 Sep 2026 05:55:40 -0600
Subject: [PATCH 1/2] Use the shared LDK helper for lookup normalization

Replaces the copied normalization loop in three trigger scripts. Field lists and error text are unchanged, so behavior is identical; the matching LDK change must be deployed first or the require() fails to compile.
---
 .../queries/EHR_ComplianceDB/requirements.js      | 15 ++-------------
 .../requirementsperemployee.js                    | 15 ++-------------
 onprc_ssu/resources/queries/onprc_ssu/schedule.js | 15 ++-------------
 3 files changed, 6 insertions(+), 39 deletions(-)

diff --git a/ONPRC_EHR_ComplianceDB/resources/queries/EHR_ComplianceDB/requirements.js b/ONPRC_EHR_ComplianceDB/resources/queries/EHR_ComplianceDB/requirements.js
index 7f2a92c15..afe078fcf 100644
--- a/ONPRC_EHR_ComplianceDB/resources/queries/EHR_ComplianceDB/requirements.js
+++ b/ONPRC_EHR_ComplianceDB/resources/queries/EHR_ComplianceDB/requirements.js
@@ -6,6 +6,7 @@
 
 var console = require("console");
 var LABKEY = require("labkey");
+var ldkUtils = require("ldk/Utils").LDK.Server.Utils;
 
 var helper = org.labkey.ldk.query.LookupValidationHelper.create(LABKEY.Security.currentContainer.id, LABKEY.Security.currentUser.id, 'ehr_compliancedb', 'requirements');
 
@@ -27,19 +28,7 @@ function beforeUpdate(row, oldRow, errors){
 }
 
 function beforeUpsert(row, errors){
-    var lookupFields = ['type'];
-    for (var i=0;i<lookupFields.length;i++){
-        var f = lookupFields[i];
-        var val = row[f];
-        if (!LABKEY.ExtAdapter.isEmpty(val)){
-            var normalizedVal = helper.getLookupValue(val, f);
-
-            if (LABKEY.ExtAdapter.isEmpty(normalizedVal))
-                errors[f] = 'Unknown value for field: ' + f + '. Value was: ' + val;
-            else
-                row[f] = normalizedVal;  //cache value for purpose of normalizing case
-        }
-    }
+    ldkUtils.normalizeLookupFields(helper, row, errors, ['type']);
 }
 
 function afterUpdate(row, oldRow, errors){
diff --git a/ONPRC_EHR_ComplianceDB/resources/queries/onprc_ehr_compliancedb/requirementsperemployee.js b/ONPRC_EHR_ComplianceDB/resources/queries/onprc_ehr_compliancedb/requirementsperemployee.js
index 76a800812..bb0c49148 100644
--- a/ONPRC_EHR_ComplianceDB/resources/queries/onprc_ehr_compliancedb/requirementsperemployee.js
+++ b/ONPRC_EHR_ComplianceDB/resources/queries/onprc_ehr_compliancedb/requirementsperemployee.js
@@ -5,6 +5,7 @@
 */
 
 var LABKEY = require("labkey");
+var ldkUtils = require("ldk/Utils").LDK.Server.Utils;
 
 var helper = org.labkey.ldk.query.LookupValidationHelper.create(LABKEY.Security.currentContainer.id, LABKEY.Security.currentUser.id, 'onprc_ehr_compliancedb', 'requirementsperemployee');
 
@@ -24,17 +25,5 @@ function beforeUpdate(row, oldRow, errors){
 }
 
 function beforeUpsert(row, errors){
-    var lookupFields = ['employeeid', 'requirementname'];
-    for (var i=0;i<lookupFields.length;i++){
-        var f = lookupFields[i];
-        var val = row[f];
-        if (!LABKEY.ExtAdapter.isEmpty(val)){
-            var normalizedVal = helper.getLookupValue(val, f);
-
-            if (LABKEY.ExtAdapter.isEmpty(normalizedVal))
-                errors[f] = 'Unknown value for field: ' + f + '. Value was: ' + val;
-            else
-                row[f] = normalizedVal;  //cache value for purpose of normalizing case
-        }
-    }
+    ldkUtils.normalizeLookupFields(helper, row, errors, ['employeeid', 'requirementname']);
 }
diff --git a/onprc_ssu/resources/queries/onprc_ssu/schedule.js b/onprc_ssu/resources/queries/onprc_ssu/schedule.js
index 4a69359e4..810189a79 100644
--- a/onprc_ssu/resources/queries/onprc_ssu/schedule.js
+++ b/onprc_ssu/resources/queries/onprc_ssu/schedule.js
@@ -6,6 +6,7 @@
 
 var console = require("console");
 var LABKEY = require("labkey");
+var ldkUtils = require("ldk/Utils").LDK.Server.Utils;
 
 var helper = org.labkey.ldk.query.LookupValidationHelper.create(LABKEY.Security.currentContainer.id, LABKEY.Security.currentUser.id, 'onprc_ssu', 'schedule');
 
@@ -27,17 +28,5 @@ function beforeUpdate(row, oldRow, errors){
 }
 
 function beforeUpsert(row, errors){
-    var lookupFields = ['projectName'];
-    for (var i=0;i<lookupFields.length;i++){
-        var f = lookupFields[i];
-        var val = row[f];
-        if (!LABKEY.ExtAdapter.isEmpty(val)){
-            var normalizedVal = helper.getLookupValue(val, f);
-
-            if (LABKEY.ExtAdapter.isEmpty(normalizedVal))
-                errors[f] = 'Unknown value for field: ' + f + '. Value was: ' + val;
-            else
-                row[f] = normalizedVal;  //cache value for purpose of normalizing case
-        }
-    }
+    ldkUtils.normalizeLookupFields(helper, row, errors, ['projectName']);
 }
\ No newline at end of file

From 046e5f6801224458098ef1793112f29e989a8276 Mon Sep 17 00:00:00 2001
From: Marty Pradere <martyp@labkey.com>
Date: Tue, 8 Sep 2026 10:33:11 -0600
Subject: [PATCH 2/2] Pin the employeeperUnit employeeId lookup to the
 compliance folder

The new ehr_compliancedb.employeeperunit trigger script case-normalizes employeeid against its lookup target, but this table is written from an EHR task form in the EHR folder, where ehr_compliancedb.employees holds no rows, so an unpinned fk would reject every submission. The unit and category lookups were already pinned to the same folder.
---
 .../resources/queries/EHR_ComplianceDB/employeeperUnit.query.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ONPRC_EHR_ComplianceDB/resources/queries/EHR_ComplianceDB/employeeperUnit.query.xml b/ONPRC_EHR_ComplianceDB/resources/queries/EHR_ComplianceDB/employeeperUnit.query.xml
index ba8a15c67..38016fa62 100644
--- a/ONPRC_EHR_ComplianceDB/resources/queries/EHR_ComplianceDB/employeeperUnit.query.xml
+++ b/ONPRC_EHR_ComplianceDB/resources/queries/EHR_ComplianceDB/employeeperUnit.query.xml
@@ -7,6 +7,7 @@
                 <columns>
                    <column columnName="employeeId">
                         <fk>
+                            <fkFolderPath>/ONPRC/Admin/Compliance</fkFolderPath>
                             <fkDbSchema>ehr_compliancedb</fkDbSchema>
                             <fkTable>employees</fkTable>
                             <fkColumnName>employeeId</fkColumnName>