From 1114caea82ca0df9544ce5c50a2359a8454847cf Mon Sep 17 00:00:00 2001 From: jazairi <16103405+jazairi@users.noreply.github.com> Date: Tue, 4 Aug 2026 15:34:54 -0700 Subject: [PATCH] Update PR template Why these changes are being introduced: The PR template is outdated. Relevant ticket(s): - [ETD-698](https://mitlibraries.atlassian.net/browse/ETD-698) How this addresses that need: This updates the template to match TIMDEX UI. Side effects of this change: --- .github/PULL_REQUEST_TEMPLATE.md | 54 ++++++++++++++++++++++---------- 1 file changed, 37 insertions(+), 17 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 392b12ce..a68fcc98 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,26 +1,46 @@ #### Developer -- [ ] All new ENV is documented in README -- [ ] All new ENV has been added to Heroku Pipeline, Staging and Prod -- [ ] ANDI or Wave has been run in accordance to - [our guide](https://mitlibraries.github.io/guides/basics/a11y.html) and - all issues introduced by these changes have been resolved or opened as new - issues (link to those issues in the Pull Request details above) -- [ ] Stakeholder approval has been confirmed (or is not needed) +##### Accessibility + +- [ ] ANDI or WAVE has been run in accordance to [our guide](https://mitlibraries.github.io/guides/basics/a11y.html). +- [ ] This PR contains no changes to the view layer. +- [ ] New issues flagged by ANDI or WAVE have been resolved. +- [ ] New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above). +- [ ] No new accessibility issues have been flagged. + +##### New ENV + +- [ ] All new ENV is documented in README. +- [ ] All new ENV has been added to Heroku Pipeline, Staging and Prod. +- [ ] ENV has not changed. + +##### Approval beyond code review + +- [ ] UXWS/stakeholder approval has been confirmed. +- [ ] UXWS/stakeholder review will be completed retroactively. +- [ ] UXWS/stakeholder review is not needed. + +##### Additional context needed to review + +E.g., if the PR includes updated dependencies and/or data +migration, or how to confirm the feature is working. #### Code Reviewer -- [ ] The commit message is clear and follows our guidelines - (not just this pull request message) -- [ ] There are appropriate tests covering any new functionality -- [ ] The documentation has been updated or is unnecessary -- [ ] The changes have been verified -- [ ] New dependencies are appropriate or there were no changes +##### Code -#### Requires database migrations? +- [ ] I have confirmed that the code works as intended. +- [ ] Any CodeClimate issues have been fixed or confirmed as +added technical debt. -YES | NO +##### Documentation + +- [ ] The commit message is clear and follows our guidelines + (not just this pull request message). +- [ ] The documentation has been updated or is unnecessary. +- [ ] New dependencies are appropriate or there were no changes. -#### Includes new or updated dependencies? +##### Testing -YES | NO +- [ ] There are appropriate tests covering any new functionality. +- [ ] No additional test coverage is required. \ No newline at end of file