From 8a354c287686c208a18171b169dae8a85839514e Mon Sep 17 00:00:00 2001 From: Market Data <112879596+MarketDataApp@users.noreply.github.com> Date: Tue, 22 Sep 2026 14:34:43 -0400 Subject: [PATCH] ci: arm the automatic code review trigger --- .github/workflows/code-review.yml | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/.github/workflows/code-review.yml b/.github/workflows/code-review.yml index 1e228fc..566967e 100644 --- a/.github/workflows/code-review.yml +++ b/.github/workflows/code-review.yml @@ -1,22 +1,16 @@ name: Code review -# DISPATCH ONLY FOR NOW, DELIBERATELY. -# -# The automatic trigger is written out below and commented. It is held back so -# the first review on this repository is read by a person before every open -# pull request gets one: this repository has never been reviewed by the bot, and -# whether the rules say useful things about sdk-csharp is the one thing nobody -# has measured yet. -# -# TO ARM IT: delete the `workflow_run` comment markers below, and delete this -# banner. Nothing else changes. Read docs/setup.md section 4 in -# MarketData-App/code-review-bot first -- it explains why the trigger is CI's -# completion and not the push. on: - # workflow_run: - # # The `name:` of this repository's pull-request CI, not its filename. - # workflows: ["Tests", "Lint"] - # types: [completed] + # CI'S COMPLETION, not the push. `require_ci_green` refuses a commit whose + # checks are still running, so a push-triggered review would find CI pending, + # skip, and never come back -- reporting success having done nothing. + workflow_run: + # The workflow's `name:`, never its filename. `Tests` is this repository's + # ONLY pull-request workflow. The template this file came from also listed + # `Lint`, which does not exist here; a name matching no workflow never + # fires, so it was silent dead weight rather than a second trigger. + workflows: ["Tests"] + types: [completed] issue_comment: types: [created] workflow_dispatch: