From 54b521eaa66ea149289e73b3e7e54f7a4f17cf50 Mon Sep 17 00:00:00 2001 From: MarketDataApp <112879596+MarketDataApp@users.noreply.github.com> Date: Wed, 16 Sep 2026 18:57:25 -0400 Subject: [PATCH] chore(ci): name this workflow Tests, like every other SDK repository The five SDK repositories called their pull-request CI four different things: Tests here and in sdk-go and sdk-py, CI in sdk-js, Pull Request in sdk-java. The code review bot triggers on CI FINISHING, and a workflow_run trigger matches on the workflow's name -- so every repository needed a different caller, and naming the wrong one fails silently: no review ever runs and nothing says why. Renaming breaks no branch protection. Every required status check in every one of these repositories is a JOB name, not a workflow name -- measured: sdk-py test (3.10), test (3.11), test (3.12) sdk-go Unit Tests (1.22.x), Integration Tests, Lint sdk-js check (20.x), check (22.x) sdk-php P8.2 - prefer-stable - ubuntu-latest, ... sdk-java Verify (JDK 17) So the only thing that moves is the label in the Actions list, and the caller workflow becomes identical across every repository instead of carrying a value someone has to look up and can get wrong. --- .github/workflows/pull-request.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index d84a13d..d004c7a 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -1,5 +1,4 @@ -name: Pull Request - +name: Tests # Triggers only on pull request lifecycle events: # - opened (PR creation) # - synchronize (push to the PR branch while the PR is open)