From fad9932f394524ed365df267de9271e302cddf3e Mon Sep 17 00:00:00 2001 From: MarketDataDev02 Date: Thu, 1 Oct 2026 10:02:40 -0300 Subject: [PATCH 1/2] ci(review): wait for Codecov before the review reads CI The review starts when Tests or Lint finishes, before Codecov reports codecov/patch and codecov/project, so require_ci_green read CI without coverage, or skipped the review while Codecov was running. The policy now lists both in wait_for_checks, and the review waits for them for 300 s at most. --- .github/code-review/policy.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/code-review/policy.yml b/.github/code-review/policy.yml index c07dd29..916cca4 100644 --- a/.github/code-review/policy.yml +++ b/.github/code-review/policy.yml @@ -27,6 +27,11 @@ gate: true # review should paper over. require_ci_green: true +# Codecov reports these two after every other check has finished, and nothing +# starts a review when they do. The review waits for them (300 s at most, the +# default) so require_ci_green reads coverage too; a red one skips the review. +wait_for_checks: ["codecov/patch", "codecov/project"] + proof: required: true # The gate fires only when a changed path matches. src/marketdata/** is the From 1f1ea6ebc07bfe94b00c0eafb18d769b87d6e77f Mon Sep 17 00:00:00 2001 From: MarketDataDev02 Date: Thu, 1 Oct 2026 14:57:50 -0300 Subject: [PATCH 2/2] ci(review): say what the Codecov wait costs a documentation-only pull request --- .github/code-review/policy.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/code-review/policy.yml b/.github/code-review/policy.yml index 916cca4..fc603cd 100644 --- a/.github/code-review/policy.yml +++ b/.github/code-review/policy.yml @@ -30,6 +30,8 @@ require_ci_green: true # Codecov reports these two after every other check has finished, and nothing # starts a review when they do. The review waits for them (300 s at most, the # default) so require_ci_green reads coverage too; a red one skips the review. +# A pull request the suite skips (documentation only) never gets them, so its +# review waits the full 300 s first. wait_for_checks: ["codecov/patch", "codecov/project"] proof: