Skip to content

Move the size information in EbmlCallbacks #272

Description

@robUx4

SizeIsValid() is used before reading the data. It's only used to check the header if the size is valid. So we could move the check in the EbmlCallbacks (holding the specs of each element).

Eventually we can also avoid allocating an element if we know beforehand the size is not valid.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    abi-breakbreaks the ABI (e.g. programs linked against the library have to be recompiled)api-breakbreaks the API (e.g. programs using it will have to adjust their source code)enhancement

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions