Skip to content

Commit 083c2cd

Browse files
committed
Fixed height/Y pos issues for Dynamic and Settings dialogs
1 parent 7946187 commit 083c2cd

3 files changed

Lines changed: 13 additions & 8 deletions

File tree

‎helpers/react/DynamicDialog/DynamicDialog.css‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@
88
background-color: var(--bg-mid-color);
99
position: fixed;
1010
top: calc(50% + var(--noteplan-toolbar-height, 0)/2); /* TEST: */
11+
height: 90vh;
12+
max-height: calc(92vh - var(--noteplan-toolbar-height, 0));
13+
/* max-height: calc(92% - var(--noteplan-toolbar-height, 0)); TEST: */
1114
left: 50%;
12-
transform: translate(-50%, -50%);
1315
/* width: 90vw; */
1416
/* max-width: 90vw; */
15-
/* height: 90vh; */
16-
/* max-height: 90vh; */
1717
width: clamp(380px, 86%, 700px);
18-
height: fit-content;
19-
max-height: calc(92% - var(--noteplan-toolbar-height, 0)); /* TEST: */
18+
/* transform: translate(-50%, -50%); */
19+
transform: translate(-50%, 0%); /* TEST: */
2020
border: none;
2121
box-shadow: 0 8px 16px rgba(0 0 0 / 0.2);
2222
/* z-index: 1000; */

‎jgclark.Dashboard/CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ For more details see the [plugin's documentation](https://github.com/NotePlan/pl
99
- TODO: fix isNoteFromAllowedFolder() for teamspace or possibly 2025-W21.md
1010
-->
1111

12+
## [2.4.0.b5] 2026-01-03
13+
- Fixed height/Y pos issues for Dynamic and Settings dialogs
14+
- dev: added new color definitions to theme CSS generator
15+
1216
## [2.4.0.b5] 2026-01-02
1317
- dev: height/width/sticky fixes to use the new `var(--noteplan-toolbar-height, 0)` for mainWindow running
1418

‎jgclark.Dashboard/src/react/css/SettingsDialog.css‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,12 @@
66
font-family: system-ui;
77
background-color: var(--bg-mid-color);
88
position: fixed;
9-
top: calc(50% + var(--noteplan-toolbar-height, 0)/2);
9+
top: calc(50% + var(--noteplan-toolbar-height, 0)*2); /* a little lower to try to avoid hiding the Header bar, as we want to see Perspective name */
10+
max-height: calc(90% - var(--noteplan-toolbar-height, 0)*);
1011
left: 50%;
11-
transform: translate(-50%, -48%); /* second param needs to be a little lower than 50% to avoid hiding the Header bar, as we want to see Perspective name */
1212
width: clamp(380px, 86%, 700px);
13-
max-height: calc(90% - var(--noteplan-toolbar-height, 0));
13+
/* transform: translate(-50%, -48%); /* second param needs to be a little lower than 50% to avoid hiding the Header bar, as we want to see Perspective name */
14+
transform: translate(-50%, 0%); /* TEST: */
1415
border: none;
1516
box-shadow: 0 8px 16px rgba(0 0 0 / 0.2);
1617
/* z-index: 1000; */

0 commit comments

Comments
 (0)