Flow fixes

Author: jgclark

helpers/HTMLView.js

@@ -831,7 +831,7 @@ export async function themeHasChanged(windowID: string, overrideThemeName?: stri
   const currentTheme = overrideThemeName ? overrideThemeName : notePlanThemeName || editorThemeName
 
   if (!currentTheme) {
-    logError('themeHasChanged', `Could not find currentTheme: "${currentTheme}", overrideThemeName: "${overrideThemeName || ''}", themeInReactWindow: "${themeInWindow}"`)
+    logError('themeHasChanged', `Could not find currentTheme: "${String(currentTheme)}", overrideThemeName: "${overrideThemeName || ''}", themeInReactWindow: "${themeInWindow}"`)
     return false
   }
   if (currentTheme !== themeInWindow) {

helpers/NPEditor.js

@@ -537,6 +537,8 @@ function openNoteInMainEditorViaCallback(
  * @returns {boolean}
  */
 function isEditorOpenNoteApiAvailable(): boolean {
+  // Testing for an API method trips [method-unbinding]; a function-typed property in flow-typed/Noteplan.js would avoid it.
+  // $FlowFixMe[method-unbinding]
   return typeof Editor !== 'undefined' && typeof Editor.openNoteByFilename === 'function'
 }
 

helpers/NPdateTime.js

@@ -4,7 +4,7 @@
 // @jgclark except where shown
 //-------------------------------------------------------------------------------
 
-import { endOfWeek as dfEndOfWeek, format, startOfWeek as dfStartOfWeek } from 'date-fns'
+import { endOfWeek as dfEndOfWeek, format, startOfWeek as dfStartOfWeek, type Locale } from 'date-fns'
 import moment from 'moment/min/moment-with-locales'
 import { trimAnyQuotes } from './dataManipulation'
 import * as dt from './dateTime'
@@ -872,7 +872,8 @@ function coerceBridgedDate(value: mixed): Date | null {
  */
 function weekBoundariesFromFirstDayOfWeek(date: Date, weekStartsOn: number): {| startDate: Date, endDate: Date |} {
   const startsOn = ((Math.floor(weekStartsOn) % 7) + 7) % 7
-  const options = { weekStartsOn: (startsOn: any) }
+  // Annotate so the missing optional `locale` is allowed. date-fns types that property invariantly.
+  const options: {| locale?: Locale, weekStartsOn?: 0 | 1 | 2 | 3 | 4 | 5 | 6 |} = { weekStartsOn: (startsOn: any) }
   return {
     startDate: dfStartOfWeek(date, options),
     endDate: dfEndOfWeek(date, options),

jgclark.Dashboard/src/react/components/Section/useSectionSortAndFilter.jsx

@@ -376,7 +376,7 @@ const useSectionSortAndFilter = (
         limitToApply,
       )
       if (priorityFilterFooter) {
-        const messageItem = {
+        const messageItem: TSectionItem = {
           itemType: priorityFilterFooter.itemType,
           ID: priorityFilterFooter.itemType === 'offerToFilter' ? `${section.ID}-FilterOffer` : `${section.ID}-FilterIndicator`,
           // Note: ideally indicate here that the display of offerToFilter shouldn't start with the + icon

jgclark.Dashboard/src/react/components/WebView.jsx

@@ -169,7 +169,7 @@ export function WebView({ data, dispatch, reactSettings, setReactSettings }: Pro
    */
   const addPassthroughVars = (data: PassedData): PassedData => {
     const newData = { ...data }
-    if (!newData?.passThroughVars) newData.passThroughVars = { lastWindowScrollTop: 0 }
+    if (!newData?.passThroughVars) newData.passThroughVars = { lastWindowScrollTop: (0: number) }
     newData.passThroughVars.lastWindowScrollTop = getDashboardScrollTop()
     return newData
   }