Make NoteChooser component non-md/txt dependent. Fix flow errors in earlier commit.

Author: jgclark

helpers/NPnote.js

@@ -238,7 +238,8 @@ export function getNoteDecorationForReact(note: TNote | NoteOption): { icon: str
   if (note.type === 'Calendar') {
     // dateTime helpers match YYYYMMDD etc. with the vault's supported extensions; also allow ISO daily filenames, should they erronesouly exist now, or are allowed in future.
     const basename = note.filename.split('/').pop() || ''
-    noteTypeForIcon = dt.isDailyNote(note) || dt.isIsoDaily(basename) ? '<DAY>' : dt.isWeeklyNote(note) ? '<WEEK>' : dt.isMonthlyNote(note) ? '<MONTH>' : dt.isQuarterlyNote(note) ? '<QUARTER>' : '<YEAR>'
+    const calendarNoteForTypeCheck: CoreNoteFields = (note: any)
+    noteTypeForIcon = dt.isDailyNote(calendarNoteForTypeCheck) || dt.isIsoDaily(basename) ? '<DAY>' : dt.isWeeklyNote(calendarNoteForTypeCheck) ? '<WEEK>' : dt.isMonthlyNote(calendarNoteForTypeCheck) ? '<MONTH>' : dt.isQuarterlyNote(calendarNoteForTypeCheck) ? '<QUARTER>' : '<YEAR>'
   }
   const folderIconDetails = noteIconsToUse.find((details) => details.firstLevelFolder === noteTypeForIcon) ?? defaultNoteIconDetails
 

helpers/dateTime.js

@@ -100,7 +100,7 @@ export const RE_OFFSET_DATE_CAPTURE = `{(\\^?${RE_DATE_INTERVAL})}`
  * @param {string} basename 
  * @returns {boolean} true if basename is of form YYYY-MM-DD.md or YYYY-MM-DD.txt
  */
-export const isIsoDaily = (basename) => new RegExp(`^${RE_DATE}${FILE_EXTENSIONS_GROUP}`, 'i').test(basename)
+export const isIsoDaily = (basename: string): boolean => new RegExp(`^${RE_DATE}${FILE_EXTENSIONS_GROUP}`, 'i').test(basename)
 
 /**
  * WARNING: Deprecated in favour of clearer named function 'todaysDateISOString' below.

helpers/react/DynamicDialog/NoteChooser.jsx

@@ -15,6 +15,7 @@ import { logDebug, logError } from '@helpers/react/reactDev.js'
 import { unwrapPluginRequestData } from '@helpers/react/pluginRequestEnvelope'
 import { getNoteDecorationForReact, TEAMSPACE_ICON_COLOR } from '@helpers/NPnote.js'
 import { getFolderFromFilename } from '@helpers/folders.js'
+import { makeCalendarFilename, RE_NOTE_FILE_EXTENSION } from '@helpers/NPFileExtensions'
 import { parseTeamspaceFilename, getFilenameWithoutTeamspaceID } from '@helpers/teamspace.js'
 import './NoteChooser.css'
 
@@ -196,7 +197,7 @@ export function NoteChooser({
         // Use setTimeout to ensure notes are reloaded first
         setTimeout(() => {
           // Get the note title from the filename
-          const noteTitleFromFilename = createdFilename.split('/').pop()?.replace(/\.md$/, '') || noteTitle.trim()
+          const noteTitleFromFilename = createdFilename.split('/').pop()?.replace(RE_NOTE_FILE_EXTENSION, '') || noteTitle.trim()
           onChange(noteTitleFromFilename, createdFilename)
         }, 100)
       } else {
@@ -261,19 +262,21 @@ export function NoteChooser({
   }
 
   /**
-   * Convert a Date object to calendar note filename (YYYYMMDD.md)
+   * Convert a Date object to its equivalent daily calendar note filename (YYYYMMDD with user's file extension)
+   * Note: This is local-timezone-dependent.
    * @param {Date} date - The date to convert
    * @returns {string} - Calendar note filename
    */
   const dateToCalendarFilename = (date: Date): string => {
     const year = date.getFullYear()
     const month = String(date.getMonth() + 1).padStart(2, '0')
     const day = String(date.getDate()).padStart(2, '0')
-    return `${year}${month}${day}.md`
+    return makeCalendarFilename(`${year}${month}${day}`)
   }
 
   /**
-   * Convert a Date object to ISO 8601 format (YYYY-MM-DD) in local timezone
+   * Convert a Date object to ISO 8601 format (YYYY-MM-DD)
+   * Note: this is local-timezone-dependent.
    * @param {Date} date - The date to convert
    * @returns {string} - ISO 8601 date string
    */