Skip to content

Commit 8568b9f

Browse files
committed
Add tooltip for reminders circle icons
1 parent f8558e6 commit 8568b9f

4 files changed

Lines changed: 10 additions & 14 deletions

File tree

‎jgclark.Dashboard/CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ For more details see the [plugin's documentation](https://github.com/NotePlan/pl
1212
- Can now click reminder item to open it in the Apple Reminders app (requires NP 3.21.2+ / build 1524).
1313
- fix: Adding a Reminder with blank date/time fields uses Unix epoch as the API stand-in for "no date" (matched by the Reminders mapper), instead of assigning today/now.
1414
- fix: Show the add-Reminder heading button in demo mode (was missing because demo data had no list options for the dialog).
15+
- fix: ⌘-hover on a reminder status icon now shows "Delete reminder" (and ⌘-click deletes), matching ctrl.
1516

1617
## [2.4.0.b49] 2026-07-13
1718
- New **Reminders** section (Apple Reminders), gated by feature flag **FFlag_Reminders**. Shows open reminders from the Apple Reminders lists that the user has selected in NotePlan's settings.

‎jgclark.Dashboard/src/react/components/ReminderItem.jsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ type Props = {
2626

2727
/**
2828
* Reminder row. Content click opens in Apple Reminders when NP supports x-apple-reminderkit via openURL.
29-
* Status icon: click completes, ctrl deletes (Calendar API).
29+
* Status icon: click completes; ⌘-click or ctrl-click deletes (Calendar API).
3030
* TODO(later): task-like dialog (edit title/details, reschedule, change list)
3131
*/
3232
function ReminderItem({ item /*, thisSection */ }: Props): Node {

‎jgclark.Dashboard/src/react/components/StatusIcon.jsx‎

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
//--------------------------------------------------------------------------
33
// Dashboard React component to show the Icon before an item
44
// Called by TaskItem component.
5-
// Last updated 2026-07-13 for v2.4.0.b49, @jgclark
5+
// Last updated 2026-07-14 for v2.4.0.b50, @jgclark
66
//--------------------------------------------------------------------------
77
import React, { useState, useEffect } from 'react'
88
import type { Node } from 'react'
@@ -108,13 +108,9 @@ const StatusIcon = ({ item, respondToClicks, onIconClick, location, iconColor }:
108108
return metaKey ? 'cancelChecklist' : ctrlKey ? 'deleteItem' : 'completeChecklist'
109109
}
110110
case 'reminder': {
111-
// Apple Reminders have no cancel state; click completes, ctrl deletes. Meta is ignored.
112-
if (metaKey && !ctrlKey) {
113-
logInfo(`StatusIcon`, `Clicked on reminder with metaKey -> no cancel action for reminders`)
114-
return
115-
}
116-
setIconClassName(getClassNameFromType(ctrlKey ? 'deleted' : 'done'))
117-
return ctrlKey ? 'deleteReminder' : 'completeReminder'
111+
// ⌘ or ctrl deletes; plain click completes (no cancel for reminders)
112+
setIconClassName(getClassNameFromType(metaKey || ctrlKey ? 'deleted' : 'done'))
113+
return metaKey || ctrlKey ? 'deleteReminder' : 'completeReminder'
118114
}
119115
case 'project': {
120116
return 'showNoteInEditorFromFilename'
@@ -135,12 +131,11 @@ const StatusIcon = ({ item, respondToClicks, onIconClick, location, iconColor }:
135131
</div>
136132
)
137133

138-
// Note: trying TooltipOnKeyPress as a span item, and an equivalent empty one if there's no tooltip
139-
// Reminders: no Cancel (meta); only Delete (ctrl)
134+
// TEST: trying TooltipOnKeyPress as a span item, and an equivalent empty one if there's no tooltip
140135
return shouldShowTooltips ? (
141136
<TooltipOnKeyPress
142-
ctrlKey={{ text: isReminder ? 'Delete Reminder' : 'Delete Item' }}
143-
metaKey={isReminder ? undefined : { text: 'Cancel Item' }}
137+
ctrlKey={{ text: isReminder ? 'Delete reminder' : 'Delete Item' }}
138+
metaKey={{ text: isReminder ? 'Delete reminder' : 'Cancel Item' }}
144139
label={`${item.itemType}_${item.ID}_Icon`}
145140
>
146141
{renderedIcon}

‎jgclark.Dashboard/src/react/css/Dashboard.css‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ html {
1313
/* Others that I have added */
1414
--fg-HashtagColor: var(--hashtag-color);
1515
--fg-MentionColor: var(--attag-color);
16-
--fg-TimeBlockColor: #efba13;
16+
--fg-TimeBlockColor: #DDA731;
1717
--fg-RemindersColor: #8d9598;
1818
--fg-WinsColor: var(--fg-ok-color);
1919
}

0 commit comments

Comments
 (0)