Skip to content

Commit d108b7e

Browse files
test: strengthen FileFilter validation
1 parent 930f2a1 commit d108b7e

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

application/tests/harvester_test/file_filter_test.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,10 @@ def test_default_instance_isolation(self):
112112
second.exclude_patterns,
113113
)
114114

115+
def test_empty_extension_raises(self):
116+
with self.assertRaises(ValueError):
117+
FileFilter(allowed_extensions={""})
118+
115119

116120
if __name__ == "__main__":
117121
unittest.main()

application/utils/harvester/file_filter.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@ def _validate_patterns(self) -> None:
5454
if any(not pattern for pattern in self.exclude_patterns):
5555
raise ValueError("Exclude pattern cannot be empty")
5656

57+
if any(not extension for extension in self.allowed_extensions):
58+
raise ValueError("Allowed extension cannot be empty")
59+
5760
def _normalize_path(self, file_path: str) -> str:
5861
return PurePosixPath(file_path).as_posix()
5962

0 commit comments

Comments
 (0)