Fix elevator name edit crash

Author: jillesvangurp

src/components/Sidebar/FeatureEditors/GenericImdfFeatureEditor.test.tsx

@@ -0,0 +1,53 @@
+import { fireEvent, render, screen } from "@testing-library/react";
+import { describe, expect, it, vi } from "vitest";
+import type { FloorFeature } from "../../../lib/types";
+import { GenericImdfFeatureEditor } from "./GenericImdfFeatureEditor";
+
+const createFeature = (): FloorFeature => ({
+  type: "Feature",
+  id: "opening-1",
+  feature_type: "opening",
+  geometry: {
+    type: "LineString",
+    coordinates: [
+      [4.9, 52.37],
+      [4.9001, 52.3701],
+    ],
+  },
+  properties: {
+    level_id: "level-1",
+    category: "elevator",
+    name: { en: "Elevator A" },
+  },
+});
+
+describe("GenericImdfFeatureEditor", () => {
+  it("allows typing in label fields without reading a cleared event target", () => {
+    const feature = createFeature();
+
+    render(
+      <GenericImdfFeatureEditor
+        feature={feature}
+        type="opening"
+        allFeatures={[feature]}
+        locked={false}
+        onCreateFeature={vi.fn()}
+        onUpdateProperty={vi.fn()}
+        onUpdateMetadata={vi.fn()}
+        onDelete={vi.fn()}
+        onClone={vi.fn()}
+        onToggleLock={vi.fn()}
+      />,
+    );
+
+    const nameInput = screen.getByDisplayValue("Elevator A") as HTMLInputElement;
+
+    expect(() =>
+      fireEvent.change(nameInput, {
+        target: { value: "Elevator" },
+      }),
+    ).not.toThrow();
+
+    expect(nameInput).toHaveValue("Elevator");
+  });
+});

src/components/Sidebar/FeatureEditors/GenericImdfFeatureEditor.tsx

@@ -403,12 +403,13 @@ export const GenericImdfFeatureEditor = ({
                     className={`input input-bordered input-sm ${hasError ? "input-error" : ""}`}
                     type="text"
                     value={textValue}
-                    onChange={(event) =>
+                    onChange={(event) => {
+                      const nextValue = event.currentTarget.value;
                       setFieldText((current) => ({
                         ...current,
-                        [field.key]: event.currentTarget.value,
-                      }))
-                    }
+                        [field.key]: nextValue,
+                      }));
+                    }}
                     onBlur={() => {
                       const value = fieldText[field.key] ?? textValue;
                       const trimmed = value.trim();
@@ -455,12 +456,13 @@ export const GenericImdfFeatureEditor = ({
                   <textarea
                     className={`textarea textarea-bordered h-24 w-full font-mono text-xs ${hasError ? "textarea-error" : ""}`}
                     value={textValue}
-                    onChange={(event) =>
+                    onChange={(event) => {
+                      const nextValue = event.currentTarget.value;
                       setFieldText((current) => ({
                         ...current,
-                        [field.key]: event.currentTarget.value,
-                      }))
-                    }
+                        [field.key]: nextValue,
+                      }));
+                    }}
                     onBlur={() => {
                       const value = fieldText[field.key] ?? textValue;
                       if (value.trim().length === 0) {