Receiving "empty" messages.

[davideyeahsure]

Hi,

I have a customer that is doing... something... on their system, now every now and then, they start a connection without actually sending anything, and the result is that something like this get logged:

08:09:08.683 [pool-3-thread-2572] INFO org.openas2.processor.receiver.AS2ReceiverHandler -- received 0 bytes in 0.0 seconds at 0 Bps xx.xx.xx.xx 45946 [null]
08:09:08.684 [pool-3-thread-2572] ERROR org.openas2.processor.receiver.AS2ReceiverHandler -- Error extracting received message.
org.openas2.WrappedException: jakarta.mail.internet.ParseException: In Content-Type string , expected '/', got null
at org.openas2.message.BaseMessage.setData(BaseMessage.java:219)
at org.openas2.processor.receiver.AS2ReceiverHandler.handle(AS2ReceiverHandler.java:180)
at org.openas2.processor.receiver.NetModule$ConnectionHandler.run(NetModule.java:176)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: jakarta.mail.internet.ParseException: In Content-Type string , expected '/', got null
at jakarta.mail.internet.ContentType.(ContentType.java:80)
at org.openas2.message.DataHistoryItem.setContentType(DataHistoryItem.java:42)
at org.openas2.message.DataHistoryItem.(DataHistoryItem.java:26)
at org.openas2.message.BaseMessage.setData(BaseMessage.java:214)
... 5 common frames omitted
08:09:08.684 [pool-3-thread-2572] ERROR org.openas2.OpenAS2Exception -- Error occurred:: Partnership not found: Partnership null Sender IDs = {as2_id=null} Receiver IDs = {as2_id=null} Attributes = {}
Sources: {message=Message From:{}To:{}

Now, since the message is 0 bytes, why is it even "processed"? Is there any way to "reject" messages that are empty?

Davide

[uhurusurfa]

My guess there is some sort of availability check going on where they ping the AS2 server to see if it is alive.
Currently the system only checks if there was actual content received in the HTTP request before trying to process it but does not check if the content containss no bytes.
The suggested fix is to change line 114 of AS2ReceiverHandler.java from:
if (data == null) {
... to:
if (data == null || data.length=0) {
Then you can supporess the error message using the "log_invalid_http_request" property to suppress logging an error.
Raise a PR if you can or I will add that into the next release when I get the chance.