Quality slider for rings

[dmitryarch]

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

Currently only way to change quality on a ring is to manually write it into "Edit item text" editor. While other items like armor, weapons and flasks have dynamic spinner for quality that allow to preview min/max quality influence or any middle value.

Describe the solution you'd like

Add quality slider for rings same way as it is for other items.
0 - 20% for usual rings.
0 - 50% for breach rings.

Describe alternatives you've considered

No response

Additional context

No response

[lucaskarsten]

Some context for whoever picks this up, since the good first issue label undersells it a little.

The quality control is already generic: displayItemQuality and displayItemQualityEdit are shown when self.displayItem.quality and self.displayItem.base.quality (Classes/ItemsTab.lua:590,599). Rings never satisfy the second half, because Data/Bases/ring.lua is generated and carries no quality field on any base, while e.g. gloves.lua has quality = 20 throughout. So the UI half is one condition, but it depends on a data change in generated files.

The larger part is that PoB has no model for what quality does on a ring in PoE2. Item.lua:1899 emits Multiplier:QualityOn<slot>, but nothing in the codebase reads Multiplier:QualityOnRing, and unlike weapons and armour there is no quality scaling for jewellery in BuildModList. Showing the spinner without that would let people set a number that changes nothing.

Related: the maximum-quality implicits themselves, +20% to Maximum Quality on Breach Rings, were not parsed at all — #2417.

[vaisest]

[vaisest]

The larger part is that PoB has no model for what quality does on a ring in PoE2. Item.lua:1899 emits Multiplier:QualityOn, but nothing in the codebase reads Multiplier:QualityOnRing, and unlike weapons and armour there is no quality scaling for jewellery in BuildModList. Showing the spinner without that would let people set a number that changes nothing.

This makes no sense.

The multiplier exists (presumably) because of poe1 alternate qualities. Quality scaling IS supported for rings. It shouldn't and will not exist in BuildModList as the idea is to only scale mods which come into PoB as a range. You wouldn't want to get an item with baked values from the trade site and then apply catalyst scaling on top of that.

If you're more interested in mod scaling behaviour, look into pob1 as we have proper mod magnitude mod support there, and it hasn't been ported over yet