Skip to content

Commit d9e30ec

Browse files
committed
Fix async feature flag mypy violations
1 parent 9d7bd7c commit d9e30ec

1 file changed

Lines changed: 13 additions & 11 deletions

File tree

posthog/async_client.py

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,7 @@ async def _enqueue(self, msg, disable_geoip) -> Optional[str]: # type: ignore[o
627627
self.log.warning("analytics-python async queue is full")
628628
return None
629629

630-
async def get_flags_decision(
630+
async def get_flags_decision( # type: ignore[override]
631631
self,
632632
distinct_id=None,
633633
groups: Optional[Mapping[str, Union[str, int]]] = None,
@@ -651,7 +651,7 @@ async def get_flags_decision(
651651
self.log.exception("Unable to get feature flags: %s", err)
652652
return normalize_flags_response({})
653653

654-
async def _get_flags_decision(
654+
async def _get_flags_decision( # type: ignore[override]
655655
self,
656656
distinct_id=None,
657657
groups: Optional[Mapping[str, Union[str, int]]] = None,
@@ -863,7 +863,7 @@ async def _ensure_feature_flags_loaded_for_local_evaluation(self) -> None:
863863
if self.feature_flags is None and self.personal_api_key:
864864
await self.load_feature_flags()
865865

866-
async def _get_feature_flag_details_from_server(
866+
async def _get_feature_flag_details_from_server( # type: ignore[override]
867867
self,
868868
key: str,
869869
distinct_id,
@@ -889,7 +889,7 @@ async def _get_feature_flag_details_from_server(
889889
flag_details = flags.get(key) if flags else None
890890
return flag_details, request_id, evaluated_at, errors_while_computing
891891

892-
async def get_feature_flag_result(
892+
async def get_feature_flag_result( # type: ignore[override]
893893
self,
894894
key: str,
895895
distinct_id,
@@ -914,7 +914,7 @@ async def get_feature_flag_result(
914914
device_id=device_id,
915915
)
916916

917-
async def _get_feature_flag_result(
917+
async def _get_feature_flag_result( # type: ignore[override]
918918
self,
919919
key: str,
920920
distinct_id,
@@ -1041,7 +1041,7 @@ async def _get_feature_flag_result(
10411041

10421042
return flag_result
10431043

1044-
async def get_feature_flag(
1044+
async def get_feature_flag( # type: ignore[override]
10451045
self,
10461046
key: str,
10471047
distinct_id,
@@ -1073,7 +1073,9 @@ async def get_feature_flag(
10731073
)
10741074
return result.get_value() if result else None
10751075

1076-
async def feature_enabled(self, key: str, distinct_id, **kwargs) -> Optional[bool]:
1076+
async def feature_enabled( # type: ignore[override]
1077+
self, key: str, distinct_id, **kwargs
1078+
) -> Optional[bool]:
10771079
warnings.warn(
10781080
"`feature_enabled` is deprecated and will be removed in a future major version. "
10791081
"Use `await posthog.evaluate_flags(distinct_id, ...)` and call `flags.is_enabled(key)` instead.",
@@ -1118,7 +1120,7 @@ async def get_feature_flag_payload(
11181120
)
11191121
return result.payload if result else None
11201122

1121-
async def get_all_flags(
1123+
async def get_all_flags( # type: ignore[override]
11221124
self,
11231125
distinct_id,
11241126
*,
@@ -1142,7 +1144,7 @@ async def get_all_flags(
11421144
)
11431145
return response["featureFlags"]
11441146

1145-
async def get_all_flags_and_payloads(
1147+
async def get_all_flags_and_payloads( # type: ignore[override]
11461148
self,
11471149
distinct_id,
11481150
*,
@@ -1197,7 +1199,7 @@ async def get_all_flags_and_payloads(
11971199
)
11981200
return response
11991201

1200-
async def evaluate_flags(
1202+
async def evaluate_flags( # type: ignore[override]
12011203
self,
12021204
distinct_id=None,
12031205
*,
@@ -1449,7 +1451,7 @@ async def _capture_feature_flag_called_if_needed_async(
14491451
"$feature_flag_called",
14501452
distinct_id=distinct_id,
14511453
properties=properties,
1452-
groups=groups or {},
1454+
groups={str(k): str(v) for k, v in (groups or {}).items()},
14531455
disable_geoip=disable_geoip,
14541456
)
14551457
reported_flags.add(feature_flag_reported_key)

0 commit comments

Comments
 (0)