You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5787a6f
Browse filesBrowse the repository at this point in the historyBrowse files
-**PR Scoping**: Flag PRs that mix unrelated subsystems or combine large protocol/parser additions with trait consumption when they should be split into focused PRs.
22
+
-**Automated Conformance**: Structural invariants (`RoborockBase` inheritance, `RoborockEnum` fallback members, `RoborockException` rooting, and trait boundary types) are enforced in `tests/conformance/`. Flag any unjustified allowlist exemptions added to `tests/conformance/` and focus deeper review energy on semantic, lifecycle, and design issues.
21
23
22
24
2.**Evaluate Layer 1: Public Trait APIs & Consumer Contracts**:
23
25
- Are trait models subclassing `RoborockBase` with `@dataclass`?
@@ -28,9 +30,11 @@ All reviews are evaluated against the engineering conventions defined in [AGENTS
28
30
- Are trait abstractions consumer-agnostic (not hardcoded exclusively to Home Assistant entities)?
29
31
- Are transport details (keys, tokens, sockets) cleanly isolated from traits?
30
32
31
-
3.**Evaluate Layer 2: Lifecycle, State & Simplification**:
33
+
3.**Evaluate Layer 2: Lifecycle, State & Concurrency**:
32
34
-**Value-Returning Helpers**: Do helper functions return values instead of modifying `self` via hidden side effects?
33
35
-**Direct Flow**: Is the execution path straightforward and direct, avoiding unnecessary indirection or ping-ponging between methods?
36
+
-**Render & Cache Immutability**: Are cached telemetry state and raw packets kept immutable during presentation/rendering? When caching derived state (e.g., parsed maps or calibration), is cache invalidation handled accurately across out-of-order or concurrent updates?
37
+
-**Event Loop Safety**: Are CPU-intensive operations (e.g., heavy map decompression or PIL image rendering) kept off the `asyncio` event loop (such as via `asyncio.to_thread`) with proper concurrency/staleness guards?
34
38
-**Concurrency**: Does 1:1 async command-response matching use `asyncio.Future` correlated by protocol request/sequence ID (`request_id` or `msg_id`)?
35
39
-**Teardown**: Are all tasks, event listeners, and channels cleanly unhooked in `RoborockDevice.close()`?
36
40
-**Capability Gating**: Is capability gating checking protocol version, category (appropriate for device family), and device feature flags?
@@ -47,8 +51,6 @@ All reviews are evaluated against the engineering conventions defined in [AGENTS
47
51
- Do assertions verify public behavior rather than private `_state` variables?
48
52
49
53
6.**Format Review Output**:
50
-
Structure review comments with clear rationale and actionable code recommendations:
51
-
-**Priority Level & File Reference**
52
-
-**Issue / Anti-Pattern Identified**
53
-
-**Grounded Rationale** (citing protocol resilience, consumer stability, or maintainability)
54
-
-**Concrete Before / After Diff or Suggested Fix**
54
+
Keep feedback high-signal: focus on architectural violations, state/concurrency bugs, protocol safety, and test gaps; avoid nitpicking formatting or style already enforced by Ruff and Mypy.
55
+
-**Interactive / Summary Reviews**: Group findings by Priority Layer (1 → 3) with file references, the anti-pattern identified, grounded rationale (citing protocol resilience, consumer stability, or maintainability), and a concrete before/after diff or suggested fix.
56
+
-**Inline PR Review Comments**: State the issue, grounded rationale (citing `AGENTS.md` conventions), and suggested fix concisely right on the affected lines.
A structured, interactive review workflow for evaluating pull requests and diffs against the repository's architectural hierarchy, typing rules, and testing standards. To invoke during interactive sessions, refer to [.agents/skills/review/SKILL.md](.agents/skills/review/SKILL.md).
A structured, interactive review workflow for evaluating pull requests and diffs against the repository's architectural hierarchy, typing rules, and testing standards. To invoke during interactive sessions, refer to [.agents/skills/code-review/SKILL.md](.agents/skills/code-review/SKILL.md).
0 commit comments