Skip to content

Commit b3952f2

Browse files
committed
fix: treat the roller mop as a mop module for water and custom modes
1 parent 554fd71 commit b3952f2

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

‎roborock/device_features.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -651,6 +651,10 @@ def from_feature_flags(
651651
kwargs["is_clean_route_setting_supported"] |= (
652652
kwargs["is_shake_mop_set_supported"] or kwargs["is_roller_mop_supported"]
653653
)
654+
# Roller-mop models have no mop module product feature; the app treats the
655+
# roller mop like one for water modes and customized cleaning.
656+
kwargs["is_support_water_mode"] |= kwargs["is_roller_mop_supported"]
657+
kwargs["is_customized_clean_supported"] |= kwargs["is_roller_mop_supported"]
654658

655659
return cls(**kwargs)
656660

‎tests/test_supported_features.py‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,8 @@ def test_clean_route_setting_support_from_spin_mop_model() -> None:
184184
(129, False),
185185
],
186186
)
187-
def test_clean_route_setting_support_from_roller_mop_bit(feature_bit: int, expected: bool) -> None:
188-
"""Test only the RR_API roller-mop bit adds roller route support."""
187+
def test_mop_support_from_roller_mop_bit(feature_bit: int, expected: bool) -> None:
188+
"""Test only the RR_API roller-mop bit adds mop support to models without a mop module."""
189189
device_features = DeviceFeatures.from_feature_flags(
190190
new_feature_info=0,
191191
new_feature_info_str=f"{1 << feature_bit:X}",
@@ -195,6 +195,8 @@ def test_clean_route_setting_support_from_roller_mop_bit(feature_bit: int, expec
195195

196196
assert device_features.is_roller_mop_supported is expected
197197
assert device_features.is_clean_route_setting_supported is expected
198+
assert device_features.is_support_water_mode is expected
199+
assert device_features.is_customized_clean_supported is expected
198200

199201

200202
@pytest.mark.parametrize(

0 commit comments

Comments
 (0)