1515 get_cleaning_mode_codes ,
1616 get_display_options ,
1717 get_motor_mode_commands ,
18+ get_setting_change_codes ,
1819 get_water_modes ,
1920)
2021from roborock .device_features import DeviceFeatures
@@ -245,6 +246,92 @@ def test_get_cleaning_mode_codes_unsupported_mode() -> None:
245246 get_cleaning_mode_codes (CleaningMode .SMART_MODE , _features (), None )
246247
247248
249+ @pytest .mark .parametrize (
250+ ("setting" , "code" , "mode" , "status" , "overrides" , "expected" ),
251+ [
252+ (CleaningSetting .FAN_SPEED , 104 , CleaningMode .VAC_AND_MOP , (102 , 202 , 300 ), {}, (104 , 202 , 300 )),
253+ (CleaningSetting .WATER_MODE , 203 , CleaningMode .MOP , (105 , 202 , 300 ), {}, (105 , 203 , 300 )),
254+ (CleaningSetting .MOP_ROUTE , 301 , CleaningMode .MOP , (105 , 202 , 300 ), {}, (105 , 202 , 301 )),
255+ # Without a route setting the route is not sent.
256+ (
257+ CleaningSetting .FAN_SPEED ,
258+ 103 ,
259+ CleaningMode .VACUUM ,
260+ (102 , 200 , 300 ),
261+ {"is_clean_route_setting_supported" : False },
262+ (103 , 200 , None ),
263+ ),
264+ # Without the shake module the route is not sent either.
265+ (
266+ CleaningSetting .FAN_SPEED ,
267+ 103 ,
268+ CleaningMode .VACUUM ,
269+ (102 , 200 , 300 ),
270+ {"is_shake_mop_set_supported" : False },
271+ (103 , 200 , None ),
272+ ),
273+ # Water slide devices accept every slider position.
274+ (
275+ CleaningSetting .WATER_MODE ,
276+ 233 ,
277+ CleaningMode .VAC_AND_MOP ,
278+ (102 , 225 , 300 ),
279+ {"is_water_slide_mode_supported" : True },
280+ (102 , 233 , 300 ),
281+ ),
282+ ],
283+ )
284+ def test_get_setting_change_codes (
285+ setting : CleaningSetting ,
286+ code : int ,
287+ mode : CleaningMode ,
288+ status : tuple [int , int , int ],
289+ overrides : dict [str , bool ],
290+ expected : tuple [int , int , int | None ],
291+ ) -> None :
292+ features = _features (is_pure_clean_mop_supported = True , ** overrides )
293+ assert (
294+ get_setting_change_codes (
295+ setting , code , mode , features , "us" , fan_power = status [0 ], water_box_mode = status [1 ], mop_mode = status [2 ]
296+ )
297+ == expected
298+ )
299+
300+
301+ @pytest .mark .parametrize (
302+ ("setting" , "code" , "mode" , "overrides" ),
303+ [
304+ (CleaningSetting .FAN_SPEED , 104 , CleaningMode .SMART_MODE , {}),
305+ (CleaningSetting .FAN_SPEED , 104 , CleaningMode .CUSTOM , {}),
306+ (CleaningSetting .FAN_SPEED , 104 , None , {}),
307+ (CleaningSetting .FAN_SPEED , 104 , CleaningMode .MOP , {}),
308+ (CleaningSetting .WATER_MODE , 203 , CleaningMode .VACUUM , {}),
309+ (CleaningSetting .FAN_SPEED , 110 , CleaningMode .VAC_AND_MOP , {}),
310+ (CleaningSetting .FAN_SPEED , 999 , CleaningMode .VAC_AND_MOP , {}),
311+ (CleaningSetting .WATER_MODE , 220 , CleaningMode .VAC_AND_MOP , {"is_water_slide_mode_supported" : True }),
312+ (CleaningSetting .WATER_MODE , 251 , CleaningMode .VAC_AND_MOP , {"is_water_slide_mode_supported" : True }),
313+ (CleaningSetting .MOP_ROUTE , 302 , CleaningMode .VAC_AND_MOP , {}),
314+ # Mopping without water is not mopping.
315+ (CleaningSetting .WATER_MODE , 200 , CleaningMode .MOP , {}),
316+ ],
317+ )
318+ def test_get_setting_change_codes_refused (
319+ setting : CleaningSetting , code : int , mode : CleaningMode | None , overrides : dict [str , bool ]
320+ ) -> None :
321+ features = _features (is_pure_clean_mop_supported = True , ** overrides )
322+ with pytest .raises (RoborockUnsupportedFeature ):
323+ get_setting_change_codes (setting , code , mode , features , "us" , fan_power = 102 , water_box_mode = 202 , mop_mode = 300 )
324+
325+
326+ @pytest .mark .parametrize ("route_supported" , [True , False ])
327+ def test_get_setting_change_codes_vacuum_only (route_supported : bool ) -> None :
328+ """Without a mop there is no water mode or route to carry along."""
329+ features = _features (is_support_water_mode = False , is_clean_route_setting_supported = route_supported )
330+ assert get_setting_change_codes (
331+ CleaningSetting .FAN_SPEED , 104 , None , features , "us" , fan_power = 102 , water_box_mode = None , mop_mode = None
332+ ) == (104 , None , None )
333+
334+
248335_SAROS_10R = {
249336 "is_soft_clean_mode_supported" : False ,
250337 "is_pure_clean_mop_supported" : True ,
@@ -347,6 +434,85 @@ def test_water_mode_display_options_keep_off_without_sub_tabs() -> None:
347434 assert WaterModes .OFF in options
348435
349436
437+ @pytest .mark .parametrize (
438+ ("setting" , "code" , "mode" , "overrides" ),
439+ [
440+ (CleaningSetting .MOP_ROUTE , 301 , CleaningMode .VAC_AND_MOP , {}),
441+ (CleaningSetting .MOP_ROUTE , 303 , CleaningMode .VACUUM , {}),
442+ (CleaningSetting .FAN_SPEED , 108 , CleaningMode .VAC_AND_MOP , {}),
443+ (CleaningSetting .FAN_SPEED , 108 , CleaningMode .VACUUM , {"is_max_plus_mode_supported" : False }),
444+ (CleaningSetting .WATER_MODE , 200 , CleaningMode .VAC_AND_MOP , {}),
445+ (CleaningSetting .MOP_ROUTE , 300 , CleaningMode .VAC_AND_MOP , {"is_shake_mop_set_supported" : False }),
446+ ],
447+ )
448+ def test_get_setting_change_codes_refuses_values_outside_mode_list (
449+ setting : CleaningSetting , code : int , mode : CleaningMode , overrides : dict [str , bool ]
450+ ) -> None :
451+ features = _features (** {** _SAROS_10R , ** overrides })
452+ with pytest .raises (RoborockUnsupportedFeature ):
453+ get_setting_change_codes (setting , code , mode , features , "us" , fan_power = 102 , water_box_mode = 235 , mop_mode = 300 )
454+
455+
456+ @pytest .mark .parametrize (
457+ ("setting" , "code" , "mode" , "status" , "expected" , "overrides" ),
458+ [
459+ (CleaningSetting .FAN_SPEED , 108 , CleaningMode .VACUUM , (102 , 200 , 300 ), (108 , 200 , 300 ), {}),
460+ (CleaningSetting .MOP_ROUTE , 304 , CleaningMode .VACUUM , (108 , 200 , 300 ), (108 , 200 , 304 ), {}),
461+ (CleaningSetting .MOP_ROUTE , 301 , CleaningMode .MOP , (105 , 235 , 300 ), (105 , 235 , 301 ), {}),
462+ # A route or fan speed set in another tab by an older client is not carried along.
463+ (CleaningSetting .WATER_MODE , 240 , CleaningMode .VAC_AND_MOP , (102 , 235 , 301 ), (102 , 240 , 300 ), {}),
464+ (CleaningSetting .WATER_MODE , 240 , CleaningMode .VAC_AND_MOP , (108 , 235 , 300 ), (102 , 240 , 300 ), {}),
465+ (CleaningSetting .MOP_ROUTE , 304 , CleaningMode .VAC_AND_MOP , (108 , 235 , 300 ), (102 , 235 , 304 ), {}),
466+ (CleaningSetting .WATER_MODE , 240 , CleaningMode .MOP , (105 , 235 , 301 ), (105 , 240 , 301 ), {}),
467+ # The mop-only fan code left behind outside mopping only becomes balanced, like Max+.
468+ (CleaningSetting .MOP_ROUTE , 304 , CleaningMode .VACUUM , (105 , 200 , 300 ), (102 , 200 , 304 ), {}),
469+ (CleaningSetting .WATER_MODE , 240 , CleaningMode .VAC_AND_MOP , (105 , 235 , 300 ), (102 , 240 , 300 ), {}),
470+ # Gentle is on the fan list of soft-clean models, so code 105 stays there.
471+ (
472+ CleaningSetting .WATER_MODE ,
473+ 240 ,
474+ CleaningMode .VAC_AND_MOP ,
475+ (105 , 235 , 300 ),
476+ (105 , 240 , 300 ),
477+ {"is_soft_clean_mode_supported" : True },
478+ ),
479+ # A leftover route is replaced even when the mode has no adjustable route.
480+ (
481+ CleaningSetting .WATER_MODE ,
482+ 240 ,
483+ CleaningMode .VAC_AND_MOP ,
484+ (102 , 235 , 301 ),
485+ (102 , 240 , 300 ),
486+ {"is_clean_route_fast_mode_supported" : False },
487+ ),
488+ # Fast is on the tab's short list and stays.
489+ (
490+ CleaningSetting .WATER_MODE ,
491+ 240 ,
492+ CleaningMode .VAC_AND_MOP ,
493+ (102 , 235 , 304 ),
494+ (102 , 240 , 304 ),
495+ {"is_clean_route_fast_mode_supported" : False },
496+ ),
497+ ],
498+ )
499+ def test_get_setting_change_codes_replaces_values_outside_mode_list (
500+ setting : CleaningSetting ,
501+ code : int ,
502+ mode : CleaningMode ,
503+ status : tuple [int , int , int ],
504+ expected : tuple [int , int , int ],
505+ overrides : dict [str , bool ],
506+ ) -> None :
507+ features = _features (** {** _SAROS_10R , ** overrides })
508+ assert (
509+ get_setting_change_codes (
510+ setting , code , mode , features , "us" , fan_power = status [0 ], water_box_mode = status [1 ], mop_mode = status [2 ]
511+ )
512+ == expected
513+ )
514+
515+
350516@pytest .mark .parametrize ("mode" , [CleaningMode .SMART_MODE , CleaningMode .CUSTOM ])
351517@pytest .mark .parametrize ("shake" , [True , False ])
352518def test_get_display_options_route_special_values_need_shake (mode : CleaningMode , shake : bool ) -> None :
@@ -365,6 +531,20 @@ def test_water_mode_display_options_include_off_when_turning_water_on_without_mo
365531 assert len (options ) > 1
366532
367533
534+ def test_get_setting_change_codes_turns_water_on_without_mode_tabs () -> None :
535+ features = _features (** {** _SAROS_10R , "is_pure_clean_mop_supported" : False })
536+ assert get_setting_change_codes (
537+ CleaningSetting .WATER_MODE ,
538+ 240 ,
539+ CleaningMode .VACUUM ,
540+ features ,
541+ "us" ,
542+ fan_power = 102 ,
543+ water_box_mode = 200 ,
544+ mop_mode = 300 ,
545+ ) == (102 , 240 , 300 )
546+
547+
368548def test_fan_speed_display_options_keep_full_list_without_a_mop () -> None :
369549 """Devices without a mop have no mode tabs at all and keep every fan speed the model lists, Max+ included."""
370550 features = _features (is_support_water_mode = False , is_max_plus_mode_supported = True )
0 commit comments