From 6a5900cd87ead97bfd5fe59365d1c99bc9294327 Mon Sep 17 00:00:00 2001 From: Rob Hofmann Date: Mon, 9 Nov 2026 20:10:05 +0100 Subject: [PATCH 1/2] Read git.allowTrunkPush through a relative hooks path, and skip the issue row on main The pre-push hook passed a relative module path to Import-Module, which read it as a module name, so every push to main was refused. On main with the setting on, the pre-flight issue-contract row is now SKIP. Refs #18 --- .../skills/ai-sdlc-gates/sync-manifest.json | 10 +++--- .../ai-sdlc-handbook/references/layout.md | 2 +- .../skills/ai-sdlc-hooks/githooks/pre-push | 4 ++- .../scripts/PrePushHook.Tests.ps1 | 35 +++++++++++++++++++ .../scripts/Invoke-IssuePreflight.Tests.ps1 | 21 +++++++++++ .../scripts/Invoke-IssuePreflight.ps1 | 8 ++++- CHANGELOG.md | 8 +++++ apm.lock.yaml | 24 ++++++------- .../skills/ai-sdlc-gates/sync-manifest.json | 10 +++--- .../ai-sdlc-handbook/references/layout.md | 2 +- .../skills/ai-sdlc-hooks/githooks/pre-push | 4 ++- .../scripts/PrePushHook.Tests.ps1 | 35 +++++++++++++++++++ core/apm.yml | 2 +- packs/bicep/apm.yml | 2 +- packs/blazor/apm.yml | 2 +- packs/discovery/apm.yml | 2 +- packs/dotnet/apm.yml | 2 +- .../scripts/Invoke-IssuePreflight.Tests.ps1 | 21 +++++++++++ .../scripts/Invoke-IssuePreflight.ps1 | 8 ++++- packs/github-issues/apm.yml | 2 +- packs/github/apm.yml | 2 +- packs/knowledge/apm.yml | 2 +- packs/sonarcloud/apm.yml | 2 +- 23 files changed, 173 insertions(+), 37 deletions(-) diff --git a/.claude/skills/ai-sdlc-gates/sync-manifest.json b/.claude/skills/ai-sdlc-gates/sync-manifest.json index fb4e8ae..efa5b23 100644 --- a/.claude/skills/ai-sdlc-gates/sync-manifest.json +++ b/.claude/skills/ai-sdlc-gates/sync-manifest.json @@ -114,7 +114,7 @@ ".claude/skills/ai-sdlc-handbook/references/docs-wiki.md": "038477c9b704a5b545decfe5e3f3f9970d8d1f9d", ".claude/skills/ai-sdlc-handbook/references/first-story.md": "be899eb395dafb2d704b8f0cb46bac1fb5e593c8", ".claude/skills/ai-sdlc-handbook/references/language.md": "ca703edeb9e07e28e32a39fbcc9116b64db444d8", - ".claude/skills/ai-sdlc-handbook/references/layout.md": "b6683bbb25c614a5d0a3f8283d4e46bfa110bcd2", + ".claude/skills/ai-sdlc-handbook/references/layout.md": "69e6a7345ca838eb224aa1bc6e093f3699c9a28c", ".claude/skills/ai-sdlc-handbook/references/node-templates.md": "580c9c92c470a6abbaa0145cc3060ff1a11d247c", ".claude/skills/ai-sdlc-handbook/references/orchestration.md": "22373827d6ecd454d93cfb652f76c5204f3215e2", ".claude/skills/ai-sdlc-handbook/references/pattern.md": "f0f2a8cf3dac267cda0fd3783d86bddba5afc7c0", @@ -130,7 +130,7 @@ ".claude/skills/ai-sdlc-hooks/githooks/post-commit": "f18058f9a38efc164e13801d61bb05329a056109", ".claude/skills/ai-sdlc-hooks/githooks/post-merge": "bb373f33abd09294cda55d7fc4499f32672eb372", ".claude/skills/ai-sdlc-hooks/githooks/post-rewrite": "e4c187dffeeaba569901f3424fae476b17c14927", - ".claude/skills/ai-sdlc-hooks/githooks/pre-push": "490c81fd333d26cf9f09877fecb369d531710d66", + ".claude/skills/ai-sdlc-hooks/githooks/pre-push": "2e0d36443dbfbff57e4b8bddece5ca4f75fc7992", ".claude/skills/ai-sdlc-hooks/scripts/AiSdlcSetup.ps1": "52ffd325d13cd403e7bfea0de8098c530c129b65", ".claude/skills/ai-sdlc-hooks/scripts/AiSdlcSetup.Tests.ps1": "ef5b30f0811181462d354a61d3e64c19f0c305e2", ".claude/skills/ai-sdlc-hooks/scripts/Deny-AgentMerge.ps1": "535543b86886fcc582912ded5373b0bd3d756356", @@ -156,7 +156,7 @@ ".claude/skills/ai-sdlc-hooks/scripts/Invoke-PostEditCheck.Tests.ps1": "3429e18735428ab387ab58ae276d4195b32e7999", ".claude/skills/ai-sdlc-hooks/scripts/New-AiSdlcUpdatePullRequest.ps1": "b54f90deb751d0b0dbf8ee8fbc3f39b3300b3b3d", ".claude/skills/ai-sdlc-hooks/scripts/New-AiSdlcUpdatePullRequest.Tests.ps1": "77e4b627da13ea9887f3918f66bc5b33dfd91c56", - ".claude/skills/ai-sdlc-hooks/scripts/PrePushHook.Tests.ps1": "718248ded3ba695b29d4d7eb59e8f09130cf918c", + ".claude/skills/ai-sdlc-hooks/scripts/PrePushHook.Tests.ps1": "b39aacfa62f188fee2455b85f00e259bfe509c87", ".claude/skills/ai-sdlc-hooks/scripts/Update-AiSdlc.ps1": "56abaf1de1c17bea94c26e128f8c41e275a74f87", ".claude/skills/ai-sdlc-hooks/scripts/Update-AiSdlc.Tests.ps1": "8db305e438bc7ee404eb5106eacbe5581738f148", ".claude/skills/ai-sdlc-hooks/scripts/WindowsLongPaths.ps1": "fa3d7f509b6f9a1a935178c1eaf0d1566b7afead", @@ -425,8 +425,8 @@ ".claude/skills/check-pr-contract/scripts/Check-PrStoryContract.Tests.ps1": "0ede5de0d5b3075c6c77ade9889e8b221fbf5d2e", ".claude/skills/check-pr-contract/scripts/Check-StoryBackEdges.ps1": "bf4281ad4dfaf0409954ca163e306fee4458de76", ".claude/skills/check-pr-contract/scripts/Check-StoryBackEdges.Tests.ps1": "8c022a6a71e2890486ded5461c31531acfeb2350", - ".claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1": "21dd90b6929fe9129e537b7c609cb4a0afc996c7", - ".claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.Tests.ps1": "a0cda3adda6acb74bcc30cdbe5126891e9d68e10", + ".claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1": "8c88138ef4cccf10cfe293b48ceaad2fead4cf71", + ".claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.Tests.ps1": "8a16f579a336c64db5fbcb21dd1f0ff814a87549", ".claude/skills/check-pr-contract/SKILL.md": "5d8173088d1434642bfe734ae8afbf201c8ec8b1", ".claude/skills/fix-bug/SKILL.md": "9928171978b34ac58a94fd076e2202f3fe53a997", ".claude/skills/github-issue-conventions/SKILL.md": "6a24729d513512df9399c9fc8570685f9369253d", diff --git a/.claude/skills/ai-sdlc-handbook/references/layout.md b/.claude/skills/ai-sdlc-handbook/references/layout.md index b6683bb..69e6a73 100644 --- a/.claude/skills/ai-sdlc-handbook/references/layout.md +++ b/.claude/skills/ai-sdlc-handbook/references/layout.md @@ -129,7 +129,7 @@ installs. `AiSdlcConfig.psm1` takes each dependency whose path ends in `packs/, so neither # an edit in the working tree nor a local ref can switch the setting on. A new branch (zero sha) or a tip # that is not in this clone counts as off. $1 is that remote sha. +# core.hooksPath is relative, so $0 and the module path can be relative to the repository root, where git +# starts the hook. Import-Module reads a bare relative path as a module name, so the path is resolved first. trunk_push_allowed() { is_zero_sha "$1" && return 1 git cat-file -e "$1^{commit}" 2>/dev/null || return 1 command -v pwsh >/dev/null 2>&1 || return 1 module="$(dirname "$0")/../../ai-sdlc-gates/scripts/AiSdlcConfig.psm1" [ -f "$module" ] || return 1 - AISDLC_CONFIG_MODULE="$module" AISDLC_REPO_ROOT="$(git rev-parse --show-toplevel)" AISDLC_REF="$1" pwsh -NoProfile -NonInteractive -Command 'try { Import-Module $env:AISDLC_CONFIG_MODULE -Force; if (Test-AiSdlcTrunkPushAllowed -RepoRoot $env:AISDLC_REPO_ROOT -Ref $env:AISDLC_REF) { exit 0 } } catch { }; exit 1' >/dev/null 2>&1 + AISDLC_CONFIG_MODULE="$module" AISDLC_REPO_ROOT="$(git rev-parse --show-toplevel)" AISDLC_REF="$1" pwsh -NoProfile -NonInteractive -Command 'try { Import-Module (Resolve-Path -LiteralPath $env:AISDLC_CONFIG_MODULE).ProviderPath -Force; if (Test-AiSdlcTrunkPushAllowed -RepoRoot $env:AISDLC_REPO_ROOT -Ref $env:AISDLC_REF) { exit 0 } } catch { }; exit 1' >/dev/null 2>&1 } is_zero_sha() { diff --git a/.claude/skills/ai-sdlc-hooks/scripts/PrePushHook.Tests.ps1 b/.claude/skills/ai-sdlc-hooks/scripts/PrePushHook.Tests.ps1 index 718248d..b39aacf 100644 --- a/.claude/skills/ai-sdlc-hooks/scripts/PrePushHook.Tests.ps1 +++ b/.claude/skills/ai-sdlc-hooks/scripts/PrePushHook.Tests.ps1 @@ -147,6 +147,41 @@ Describe 'The pre-push git hook' { $r.Code | Should -Be 1 $r.Output | Should -Match 'a push to main is refused' } + + # Initialize-AiSdlc.ps1 sets a relative core.hooksPath, so git starts the hook with a relative $0. + # This test runs a real git push through that setup, not the hook through an absolute path. + It 'reads the setting through the relative core.hooksPath of a real git push, when it is ' -Skip:($script:NoSh -or $script:NoPwshHere) -ForEach @( + @{ Name = 'on'; Json = '{ "git": { "allowTrunkPush": true } }'; Code = 0; Expect = 'allows this fast-forward of main' } + @{ Name = 'off'; Json = '{}'; Code = 1; Expect = 'a push to main is refused' } + ) { + $root = Join-Path ([System.IO.Path]::GetTempPath()) ('pre-push-' + [guid]::NewGuid().ToString('n')) + $remote = "$root-remote.git" + try { + git init --quiet --bare --initial-branch main $remote + git -C (Split-Path $remote) init --quiet --initial-branch main $root + git -C $root config user.email probe@example.invalid + git -C $root config user.name probe + Set-Content -LiteralPath (Join-Path $root 'aisdlc.json') -Value $Json + git -C $root add aisdlc.json + git -C $root commit --quiet -m one --no-verify + git -C $root remote add origin $remote + git -C $root push --quiet --no-verify origin main 2>$null + + $hooks = Join-Path $root '.claude' 'skills' 'ai-sdlc-hooks' 'githooks' + $gates = Join-Path $root '.claude' 'skills' 'ai-sdlc-gates' 'scripts' + New-Item -ItemType Directory -Path $hooks, $gates -Force | Out-Null + Copy-Item -Path (Join-Path $PSScriptRoot '..' 'githooks' '*') -Destination $hooks + Copy-Item -LiteralPath (Join-Path $PSScriptRoot '..' '..' 'ai-sdlc-gates' 'scripts' 'AiSdlcConfig.psm1') -Destination $gates + if (-not $IsWindows) { chmod +x (Get-ChildItem -LiteralPath $hooks).FullName } + git -C $root config core.hooksPath '.claude/skills/ai-sdlc-hooks/githooks' + git -C $root commit --quiet --allow-empty -m two --no-verify + + $output = git -C $root push origin main 2>&1 | Out-String + $LASTEXITCODE | Should -Be $Code -Because $output + $output | Should -Match $Expect + } + finally { Remove-Item -LiteralPath $root, $remote -Recurse -Force -ErrorAction SilentlyContinue } + } } It 'never falls back to Windows PowerShell, which cannot run a gate that needs PowerShell 7' { diff --git a/.claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.Tests.ps1 b/.claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.Tests.ps1 index a0cda3a..8a16f57 100644 --- a/.claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.Tests.ps1 +++ b/.claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.Tests.ps1 @@ -42,6 +42,27 @@ Describe 'Invoke-IssuePreflight' { $rows[0].Detail | Should -Match 'title or body' } + It 'returns a SKIP row on main when git.allowTrunkPush is on, and a FAIL row when it is off' { + git -C $script:Repo checkout -q -B main 2>$null + $rows = @(& $script:ScriptUnderTest -RepoRoot $script:Repo -GhCommand $script:NoGh 6>$null) + $rows[0].Status | Should -Be 'FAIL' + + $config = Join-Path $script:Repo 'aisdlc.json' + $saved = Get-Content -LiteralPath $config -Raw + try { + Set-Content -LiteralPath $config -Value '{ "tracker": { "repository": "contoso/portal" }, "git": { "allowTrunkPush": true } }' + $rows = @(& $script:ScriptUnderTest -RepoRoot $script:Repo -GhCommand $script:NoGh 6>$null) + $rows.Count | Should -Be 1 + $rows[0].Status | Should -Be 'SKIP' + $rows[0].Detail | Should -Match 'git.allowTrunkPush' + + git -C $script:Repo checkout -q -B feature/no-key 2>$null + $rows = @(& $script:ScriptUnderTest -RepoRoot $script:Repo -GhCommand $script:NoGh 6>$null) + $rows[0].Status | Should -Be 'FAIL' -Because 'the setting only covers main and master' + } + finally { Set-Content -LiteralPath $config -Value $saved -NoNewline } + } + It 'returns NEEDS-GH for a branch that names a story key' { git -C $script:Repo checkout -q -B 1234-a-change 2>$null diff --git a/.claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1 b/.claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1 index 21dd90b..8c88138 100644 --- a/.claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1 +++ b/.claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1 @@ -11,6 +11,8 @@ story key (42-short-name, or the bare number 42 of a bug branch) is a FAIL row, so the pre-flight writes no receipt, with or without gh. Set PR_STORY_KEY to name the key of a branch that cannot carry it. Outside a git repository there is no branch, and this step is left out. + On main or master in a repository that sets git.allowTrunkPush, the row is SKIP: a change there has + no story or pull request on purpose. When gh is installed and signed in (`gh auth status` succeeds), it runs Check-PrStoryContract.ps1 for the current branch and the changed files. Without it, it says what is needed; the same check @@ -54,7 +56,11 @@ Write-Host "Issue contract (gh; the same check runs from the run-preflight skill $branch = [string](git -C $RepoRoot rev-parse --abbrev-ref HEAD 2>$null) # The story key needs no GitHub read, so a branch without one fails before the gh check. The branch rule # is the one Check-PrStoryContract.ps1 uses, so both forms agree on what a key is. -if ($branch -and -not ($env:PR_STORY_KEY -or (Get-AiSdlcBranchStoryKey -Branch $branch))) { +# A repository that sets git.allowTrunkPush changes main or master directly, with no story or pull request. +if ($branch -in 'main', 'master' -and -not $env:PR_STORY_KEY -and (Test-AiSdlcTrunkPushAllowed -RepoRoot $RepoRoot)) { + [pscustomobject]@{ Check = 'IssueContract (story + ADR)'; Status = 'SKIP'; Detail = "branch '$branch' is the main branch, and git.allowTrunkPush in aisdlc.json lets a change go there without a story or pull request" } +} +elseif ($branch -and -not ($env:PR_STORY_KEY -or (Get-AiSdlcBranchStoryKey -Branch $branch))) { [pscustomobject]@{ Check = 'IssueContract (story + ADR)'; Status = 'FAIL'; Detail = "branch '$branch' names no story key, and the pre-flight has no pull request title or body to read; start the branch name with the issue number (42-short-name), or set PR_STORY_KEY to the key" } } elseif (Test-GhReady) { diff --git a/CHANGELOG.md b/CHANGELOG.md index 1fae576..7b21b0f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,14 @@ merge is ready to tag, and no second pull request is needed to name the version. Each entry names its issue, as `#42`. +## v1.3.1 - 2026-11-09 + +- The pre-push git hook now reads `git.allowTrunkPush` when `core.hooksPath` is relative, which is how + `Initialize-AiSdlc.ps1` sets it (#18). Before, the hook could not load the config module, so it refused + every push to `main`. A new test runs a real `git push` through that setup. +- On `main` or `master` in a repository that sets `git.allowTrunkPush`, the pre-flight issue-contract row + is SKIP, not FAIL, because a change there has no story or pull request (#18). + ## v1.3.0 - 2026-11-09 - A repository can set `git.allowTrunkPush` to `true` in `aisdlc.json` to update `main` or `master` diff --git a/apm.lock.yaml b/apm.lock.yaml index 3543dfa..940cc2d 100644 --- a/apm.lock.yaml +++ b/apm.lock.yaml @@ -331,7 +331,7 @@ dependencies: .claude/skills/ai-sdlc-gates/scripts/gitleaks-rules.json: sha256:6a8a75c5dbcf2378a1c52d046e34ce275aac7ce08a0ae61408d25c18e1e27014 .claude/skills/ai-sdlc-gates/scripts/gitleaks-version.json: sha256:c54acb854f87a1bbdf0e90c670b72b5de3cd37f7e460d82eca599c3c7af23a84 .claude/skills/ai-sdlc-gates/skill-catalog.json: sha256:5537684656bf189a740ba7e9e7050083af05668d00501ce1e9c6909cb8b91203 - .claude/skills/ai-sdlc-gates/sync-manifest.json: sha256:02e70e5febf8f5c377da8f209aebae347f1dd5c54abdb3c47c65e097b5551cda + .claude/skills/ai-sdlc-gates/sync-manifest.json: sha256:8d40bcba0f9aa58fcb31ef15d25c502479ee04415a69be821f381ea784bcfd1c .claude/skills/ai-sdlc-handbook/SKILL.md: sha256:548e6b9ad79d3d2afa2f5779835988eeb12c49cda08917c4bbaa9ac0486a47a0 .claude/skills/ai-sdlc-handbook/references/README.md: sha256:654afcaa2b81f560eff93dbdef521b09ced06137a1dbb85d70a4e14ef7502248 .claude/skills/ai-sdlc-handbook/references/artifact-graph.md: sha256:d7ddfe20e5ee6565bcf25f9cef0f578da2a4ab1590033d791b8814d4688fd1f0 @@ -343,7 +343,7 @@ dependencies: .claude/skills/ai-sdlc-handbook/references/docs-wiki.md: sha256:2bd6f3a8e64f9db16163519767b822e4ebcffd740e3c5cbff17281ad71d264b7 .claude/skills/ai-sdlc-handbook/references/first-story.md: sha256:831552230cc16386ee01d7c730e288ef19aca5a66fafb00e1dfbbf4e9788caf2 .claude/skills/ai-sdlc-handbook/references/language.md: sha256:e0e32fae9c9fcdd23380d92ec910128254ce248538940541f5789ca78228a023 - .claude/skills/ai-sdlc-handbook/references/layout.md: sha256:b37f18f29cdbef58bdf34ed17367b49d5a4a7ccd2e220fc3a1615effd4a8be31 + .claude/skills/ai-sdlc-handbook/references/layout.md: sha256:c0287872a2b6ada62c4ac3fef9c8dc636c6b1b34c68b30d12c673cf2fe2ce33a .claude/skills/ai-sdlc-handbook/references/node-templates.md: sha256:8664ad1f85bff48d6230ed22e3f25683f378822e566c2a1454cbb204f4bb8fad .claude/skills/ai-sdlc-handbook/references/orchestration.md: sha256:6a1d6b6cc434f2e312994bd77daaa1fef4e007e03777ac63f3ca74edaa0cc485 .claude/skills/ai-sdlc-handbook/references/pattern.md: sha256:7908f80ee28ff1f7cd9f85b22fcf3e455fe74225d33ff201f8fbce1623d672eb @@ -358,7 +358,7 @@ dependencies: .claude/skills/ai-sdlc-hooks/githooks/post-commit: sha256:4f73a74133b0272725117fa9d962353abb6ed98d9cf5e731cd212fd5ace23271 .claude/skills/ai-sdlc-hooks/githooks/post-merge: sha256:b9f1f47cd3894406451e00c177912baeed66470b0cc18d581a5461330c7c0868 .claude/skills/ai-sdlc-hooks/githooks/post-rewrite: sha256:b7ee1a97b08a9826678829b6c49457fdc4b5ebd53eaf8cdd70f33d26e61c4a79 - .claude/skills/ai-sdlc-hooks/githooks/pre-push: sha256:8083ee4f6a7d6c688a73d66ed31428cc602f87d7742b29c1c2210804ac9d04c5 + .claude/skills/ai-sdlc-hooks/githooks/pre-push: sha256:be87399d754cfa3f937c5aa0e49e55851260a48c843cc2e5a0fa5de5a33e6584 .claude/skills/ai-sdlc-hooks/scripts/AiSdlcSetup.Tests.ps1: sha256:004bc7f1a68e953c8e657b49e74755b69a14138dfb0db61162ab15420f2b24be .claude/skills/ai-sdlc-hooks/scripts/AiSdlcSetup.ps1: sha256:b3569de6e27c3dcaffbc082311e6882bd722d440e5e855245da2410033202c7e .claude/skills/ai-sdlc-hooks/scripts/Deny-AgentMerge.Tests.ps1: sha256:4c4e1f6b673671125290d78815c72277665a8a618b55fd589f75f3a36e3b80aa @@ -384,7 +384,7 @@ dependencies: .claude/skills/ai-sdlc-hooks/scripts/Invoke-PostEditCheck.ps1: sha256:d60cdd2d341487ded3b9fafe40da49f2adfb1cf8f20cf3f8559ea2e80a5f93c6 .claude/skills/ai-sdlc-hooks/scripts/New-AiSdlcUpdatePullRequest.Tests.ps1: sha256:9c9859767d2534c45e1c72b47f4b5c64aaa16c32c580df3b5d8bc3dce5cdb2c4 .claude/skills/ai-sdlc-hooks/scripts/New-AiSdlcUpdatePullRequest.ps1: sha256:abf763c6cde97dbfc83b25f140e768d66fd9edd3961605b7d058b08a31882875 - .claude/skills/ai-sdlc-hooks/scripts/PrePushHook.Tests.ps1: sha256:de023a2c91558728f72e02091986607941ef6b7ef0e6df7602d944e20219ae4b + .claude/skills/ai-sdlc-hooks/scripts/PrePushHook.Tests.ps1: sha256:06760f922d0a90550923195fe5eacfb65d29d95d9294d2f679ee7aafa068d014 .claude/skills/ai-sdlc-hooks/scripts/Update-AiSdlc.Tests.ps1: sha256:4f2fe5313c8763f8128ad0e0347da1f2dd485393d20dc5e3a5d75e08aa157ad3 .claude/skills/ai-sdlc-hooks/scripts/Update-AiSdlc.ps1: sha256:0381e47c6b1070c7b230f81f243e25b1a8bfa68b5e8e9ae2ad6e225b0ddb36b6 .claude/skills/ai-sdlc-hooks/scripts/WindowsLongPaths.Tests.ps1: sha256:52f81e945390e61222a2668c8525cb17f17226267e24c52d7792263a07576543 @@ -562,8 +562,8 @@ dependencies: .claude/skills/check-pr-contract/scripts/Check-PrStoryContract.ps1: sha256:ba17878234019bf6e6a2bbaa36bcdd7832303ef21047af9c51c155f668f46942 .claude/skills/check-pr-contract/scripts/Check-StoryBackEdges.Tests.ps1: sha256:379ae81e01c477021062f7156321c36e5b427285fc89f2cde89e436b783752ea .claude/skills/check-pr-contract/scripts/Check-StoryBackEdges.ps1: sha256:4cc5b0153c56966c67d489b9f0d1110b8c3763ab752a48e1e23629f624df8b37 - .claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.Tests.ps1: sha256:547ad76963e44f189a187567f8ffac473a24480c12963e8672111eb5ae6df0ad - .claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1: sha256:94d035b258baa92346aba863ca6beaf80cfa95c01528f8723753869f1b693146 + .claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.Tests.ps1: sha256:dde25013df004e686254844c23d48cab5493e587c7bac22a4c19067431adeaa5 + .claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1: sha256:5180ea76aec779bf1da8119f543ed635e95ac260a91e14b7372b7b041670babd .claude/skills/fix-bug/SKILL.md: sha256:bc790a37ca12fbb64d4a736ab8bc91d9eec98e57dcaba8842e9d3a2665a4aedb .claude/skills/github-issue-conventions/SKILL.md: sha256:639c56467bd97a5253c7e1abd0216f8fcd0bd5d131f1fa7f4edfaa79c2d8348a .claude/skills/write-story/SKILL.md: sha256:d944f36869aa2a791311a27ee5b2db17d38869f41fb04d5970b1269db7515e2a @@ -1551,7 +1551,7 @@ deployments: owners: - ./core active_owner: ./core - content_hash: sha256:02e70e5febf8f5c377da8f209aebae347f1dd5c54abdb3c47c65e097b5551cda + content_hash: sha256:8d40bcba0f9aa58fcb31ef15d25c502479ee04415a69be821f381ea784bcfd1c - kind: project-relative target: claude value: .claude/skills/ai-sdlc-handbook @@ -1668,7 +1668,7 @@ deployments: owners: - ./core active_owner: ./core - content_hash: sha256:b37f18f29cdbef58bdf34ed17367b49d5a4a7ccd2e220fc3a1615effd4a8be31 + content_hash: sha256:c0287872a2b6ada62c4ac3fef9c8dc636c6b1b34c68b30d12c673cf2fe2ce33a - kind: project-relative target: claude value: .claude/skills/ai-sdlc-handbook/references/node-templates.md @@ -1812,7 +1812,7 @@ deployments: owners: - ./core active_owner: ./core - content_hash: sha256:8083ee4f6a7d6c688a73d66ed31428cc602f87d7742b29c1c2210804ac9d04c5 + content_hash: sha256:be87399d754cfa3f937c5aa0e49e55851260a48c843cc2e5a0fa5de5a33e6584 - kind: project-relative target: claude value: .claude/skills/ai-sdlc-hooks/scripts/AiSdlcSetup.Tests.ps1 @@ -2046,7 +2046,7 @@ deployments: owners: - ./core active_owner: ./core - content_hash: sha256:de023a2c91558728f72e02091986607941ef6b7ef0e6df7602d944e20219ae4b + content_hash: sha256:06760f922d0a90550923195fe5eacfb65d29d95d9294d2f679ee7aafa068d014 - kind: project-relative target: claude value: .claude/skills/ai-sdlc-hooks/scripts/Update-AiSdlc.Tests.ps1 @@ -2172,7 +2172,7 @@ deployments: owners: - ./packs/github-issues active_owner: ./packs/github-issues - content_hash: sha256:547ad76963e44f189a187567f8ffac473a24480c12963e8672111eb5ae6df0ad + content_hash: sha256:dde25013df004e686254844c23d48cab5493e587c7bac22a4c19067431adeaa5 - kind: project-relative target: claude value: .claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1 @@ -2181,7 +2181,7 @@ deployments: owners: - ./packs/github-issues active_owner: ./packs/github-issues - content_hash: sha256:94d035b258baa92346aba863ca6beaf80cfa95c01528f8723753869f1b693146 + content_hash: sha256:5180ea76aec779bf1da8119f543ed635e95ac260a91e14b7372b7b041670babd - kind: project-relative target: claude value: .claude/skills/convene-personas diff --git a/core/.apm/skills/ai-sdlc-gates/sync-manifest.json b/core/.apm/skills/ai-sdlc-gates/sync-manifest.json index fb4e8ae..efa5b23 100644 --- a/core/.apm/skills/ai-sdlc-gates/sync-manifest.json +++ b/core/.apm/skills/ai-sdlc-gates/sync-manifest.json @@ -114,7 +114,7 @@ ".claude/skills/ai-sdlc-handbook/references/docs-wiki.md": "038477c9b704a5b545decfe5e3f3f9970d8d1f9d", ".claude/skills/ai-sdlc-handbook/references/first-story.md": "be899eb395dafb2d704b8f0cb46bac1fb5e593c8", ".claude/skills/ai-sdlc-handbook/references/language.md": "ca703edeb9e07e28e32a39fbcc9116b64db444d8", - ".claude/skills/ai-sdlc-handbook/references/layout.md": "b6683bbb25c614a5d0a3f8283d4e46bfa110bcd2", + ".claude/skills/ai-sdlc-handbook/references/layout.md": "69e6a7345ca838eb224aa1bc6e093f3699c9a28c", ".claude/skills/ai-sdlc-handbook/references/node-templates.md": "580c9c92c470a6abbaa0145cc3060ff1a11d247c", ".claude/skills/ai-sdlc-handbook/references/orchestration.md": "22373827d6ecd454d93cfb652f76c5204f3215e2", ".claude/skills/ai-sdlc-handbook/references/pattern.md": "f0f2a8cf3dac267cda0fd3783d86bddba5afc7c0", @@ -130,7 +130,7 @@ ".claude/skills/ai-sdlc-hooks/githooks/post-commit": "f18058f9a38efc164e13801d61bb05329a056109", ".claude/skills/ai-sdlc-hooks/githooks/post-merge": "bb373f33abd09294cda55d7fc4499f32672eb372", ".claude/skills/ai-sdlc-hooks/githooks/post-rewrite": "e4c187dffeeaba569901f3424fae476b17c14927", - ".claude/skills/ai-sdlc-hooks/githooks/pre-push": "490c81fd333d26cf9f09877fecb369d531710d66", + ".claude/skills/ai-sdlc-hooks/githooks/pre-push": "2e0d36443dbfbff57e4b8bddece5ca4f75fc7992", ".claude/skills/ai-sdlc-hooks/scripts/AiSdlcSetup.ps1": "52ffd325d13cd403e7bfea0de8098c530c129b65", ".claude/skills/ai-sdlc-hooks/scripts/AiSdlcSetup.Tests.ps1": "ef5b30f0811181462d354a61d3e64c19f0c305e2", ".claude/skills/ai-sdlc-hooks/scripts/Deny-AgentMerge.ps1": "535543b86886fcc582912ded5373b0bd3d756356", @@ -156,7 +156,7 @@ ".claude/skills/ai-sdlc-hooks/scripts/Invoke-PostEditCheck.Tests.ps1": "3429e18735428ab387ab58ae276d4195b32e7999", ".claude/skills/ai-sdlc-hooks/scripts/New-AiSdlcUpdatePullRequest.ps1": "b54f90deb751d0b0dbf8ee8fbc3f39b3300b3b3d", ".claude/skills/ai-sdlc-hooks/scripts/New-AiSdlcUpdatePullRequest.Tests.ps1": "77e4b627da13ea9887f3918f66bc5b33dfd91c56", - ".claude/skills/ai-sdlc-hooks/scripts/PrePushHook.Tests.ps1": "718248ded3ba695b29d4d7eb59e8f09130cf918c", + ".claude/skills/ai-sdlc-hooks/scripts/PrePushHook.Tests.ps1": "b39aacfa62f188fee2455b85f00e259bfe509c87", ".claude/skills/ai-sdlc-hooks/scripts/Update-AiSdlc.ps1": "56abaf1de1c17bea94c26e128f8c41e275a74f87", ".claude/skills/ai-sdlc-hooks/scripts/Update-AiSdlc.Tests.ps1": "8db305e438bc7ee404eb5106eacbe5581738f148", ".claude/skills/ai-sdlc-hooks/scripts/WindowsLongPaths.ps1": "fa3d7f509b6f9a1a935178c1eaf0d1566b7afead", @@ -425,8 +425,8 @@ ".claude/skills/check-pr-contract/scripts/Check-PrStoryContract.Tests.ps1": "0ede5de0d5b3075c6c77ade9889e8b221fbf5d2e", ".claude/skills/check-pr-contract/scripts/Check-StoryBackEdges.ps1": "bf4281ad4dfaf0409954ca163e306fee4458de76", ".claude/skills/check-pr-contract/scripts/Check-StoryBackEdges.Tests.ps1": "8c022a6a71e2890486ded5461c31531acfeb2350", - ".claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1": "21dd90b6929fe9129e537b7c609cb4a0afc996c7", - ".claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.Tests.ps1": "a0cda3adda6acb74bcc30cdbe5126891e9d68e10", + ".claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1": "8c88138ef4cccf10cfe293b48ceaad2fead4cf71", + ".claude/skills/check-pr-contract/scripts/Invoke-IssuePreflight.Tests.ps1": "8a16f579a336c64db5fbcb21dd1f0ff814a87549", ".claude/skills/check-pr-contract/SKILL.md": "5d8173088d1434642bfe734ae8afbf201c8ec8b1", ".claude/skills/fix-bug/SKILL.md": "9928171978b34ac58a94fd076e2202f3fe53a997", ".claude/skills/github-issue-conventions/SKILL.md": "6a24729d513512df9399c9fc8570685f9369253d", diff --git a/core/.apm/skills/ai-sdlc-handbook/references/layout.md b/core/.apm/skills/ai-sdlc-handbook/references/layout.md index b6683bb..69e6a73 100644 --- a/core/.apm/skills/ai-sdlc-handbook/references/layout.md +++ b/core/.apm/skills/ai-sdlc-handbook/references/layout.md @@ -129,7 +129,7 @@ installs. `AiSdlcConfig.psm1` takes each dependency whose path ends in `packs/, so neither # an edit in the working tree nor a local ref can switch the setting on. A new branch (zero sha) or a tip # that is not in this clone counts as off. $1 is that remote sha. +# core.hooksPath is relative, so $0 and the module path can be relative to the repository root, where git +# starts the hook. Import-Module reads a bare relative path as a module name, so the path is resolved first. trunk_push_allowed() { is_zero_sha "$1" && return 1 git cat-file -e "$1^{commit}" 2>/dev/null || return 1 command -v pwsh >/dev/null 2>&1 || return 1 module="$(dirname "$0")/../../ai-sdlc-gates/scripts/AiSdlcConfig.psm1" [ -f "$module" ] || return 1 - AISDLC_CONFIG_MODULE="$module" AISDLC_REPO_ROOT="$(git rev-parse --show-toplevel)" AISDLC_REF="$1" pwsh -NoProfile -NonInteractive -Command 'try { Import-Module $env:AISDLC_CONFIG_MODULE -Force; if (Test-AiSdlcTrunkPushAllowed -RepoRoot $env:AISDLC_REPO_ROOT -Ref $env:AISDLC_REF) { exit 0 } } catch { }; exit 1' >/dev/null 2>&1 + AISDLC_CONFIG_MODULE="$module" AISDLC_REPO_ROOT="$(git rev-parse --show-toplevel)" AISDLC_REF="$1" pwsh -NoProfile -NonInteractive -Command 'try { Import-Module (Resolve-Path -LiteralPath $env:AISDLC_CONFIG_MODULE).ProviderPath -Force; if (Test-AiSdlcTrunkPushAllowed -RepoRoot $env:AISDLC_REPO_ROOT -Ref $env:AISDLC_REF) { exit 0 } } catch { }; exit 1' >/dev/null 2>&1 } is_zero_sha() { diff --git a/core/.apm/skills/ai-sdlc-hooks/scripts/PrePushHook.Tests.ps1 b/core/.apm/skills/ai-sdlc-hooks/scripts/PrePushHook.Tests.ps1 index 718248d..b39aacf 100644 --- a/core/.apm/skills/ai-sdlc-hooks/scripts/PrePushHook.Tests.ps1 +++ b/core/.apm/skills/ai-sdlc-hooks/scripts/PrePushHook.Tests.ps1 @@ -147,6 +147,41 @@ Describe 'The pre-push git hook' { $r.Code | Should -Be 1 $r.Output | Should -Match 'a push to main is refused' } + + # Initialize-AiSdlc.ps1 sets a relative core.hooksPath, so git starts the hook with a relative $0. + # This test runs a real git push through that setup, not the hook through an absolute path. + It 'reads the setting through the relative core.hooksPath of a real git push, when it is ' -Skip:($script:NoSh -or $script:NoPwshHere) -ForEach @( + @{ Name = 'on'; Json = '{ "git": { "allowTrunkPush": true } }'; Code = 0; Expect = 'allows this fast-forward of main' } + @{ Name = 'off'; Json = '{}'; Code = 1; Expect = 'a push to main is refused' } + ) { + $root = Join-Path ([System.IO.Path]::GetTempPath()) ('pre-push-' + [guid]::NewGuid().ToString('n')) + $remote = "$root-remote.git" + try { + git init --quiet --bare --initial-branch main $remote + git -C (Split-Path $remote) init --quiet --initial-branch main $root + git -C $root config user.email probe@example.invalid + git -C $root config user.name probe + Set-Content -LiteralPath (Join-Path $root 'aisdlc.json') -Value $Json + git -C $root add aisdlc.json + git -C $root commit --quiet -m one --no-verify + git -C $root remote add origin $remote + git -C $root push --quiet --no-verify origin main 2>$null + + $hooks = Join-Path $root '.claude' 'skills' 'ai-sdlc-hooks' 'githooks' + $gates = Join-Path $root '.claude' 'skills' 'ai-sdlc-gates' 'scripts' + New-Item -ItemType Directory -Path $hooks, $gates -Force | Out-Null + Copy-Item -Path (Join-Path $PSScriptRoot '..' 'githooks' '*') -Destination $hooks + Copy-Item -LiteralPath (Join-Path $PSScriptRoot '..' '..' 'ai-sdlc-gates' 'scripts' 'AiSdlcConfig.psm1') -Destination $gates + if (-not $IsWindows) { chmod +x (Get-ChildItem -LiteralPath $hooks).FullName } + git -C $root config core.hooksPath '.claude/skills/ai-sdlc-hooks/githooks' + git -C $root commit --quiet --allow-empty -m two --no-verify + + $output = git -C $root push origin main 2>&1 | Out-String + $LASTEXITCODE | Should -Be $Code -Because $output + $output | Should -Match $Expect + } + finally { Remove-Item -LiteralPath $root, $remote -Recurse -Force -ErrorAction SilentlyContinue } + } } It 'never falls back to Windows PowerShell, which cannot run a gate that needs PowerShell 7' { diff --git a/core/apm.yml b/core/apm.yml index e1afdc7..ade8bf9 100644 --- a/core/apm.yml +++ b/core/apm.yml @@ -1,3 +1,3 @@ name: ai-sdlc-core -version: "1.3.0" +version: "1.3.1" description: The AI-SDLC core for every repository - workflow skills, review agents, hooks, core gates and the handbook. diff --git a/packs/bicep/apm.yml b/packs/bicep/apm.yml index c1ac72e..b68ad52 100644 --- a/packs/bicep/apm.yml +++ b/packs/bicep/apm.yml @@ -1,3 +1,3 @@ name: ai-sdlc-bicep -version: "1.3.0" +version: "1.3.1" description: The Bicep pack - Bicep conventions for infrastructure templates. diff --git a/packs/blazor/apm.yml b/packs/blazor/apm.yml index 43124e6..3d1a5bb 100644 --- a/packs/blazor/apm.yml +++ b/packs/blazor/apm.yml @@ -1,3 +1,3 @@ name: ai-sdlc-blazor -version: "1.3.0" +version: "1.3.1" description: The Blazor pack - portal UI conventions, component authorization and the Razor gates. diff --git a/packs/discovery/apm.yml b/packs/discovery/apm.yml index 8144e4d..88f959b 100644 --- a/packs/discovery/apm.yml +++ b/packs/discovery/apm.yml @@ -1,3 +1,3 @@ name: ai-sdlc-discovery -version: "1.3.0" +version: "1.3.1" description: The discovery pack - the discovery workflows that write a research summary, a journey map and a hypothesis canvas as markdown files in the repository. diff --git a/packs/dotnet/apm.yml b/packs/dotnet/apm.yml index a490cde..e7fa5fb 100644 --- a/packs/dotnet/apm.yml +++ b/packs/dotnet/apm.yml @@ -1,3 +1,3 @@ name: ai-sdlc-dotnet -version: "1.3.0" +version: "1.3.1" description: The .NET pack - C# conventions, test-first, the .NET gates and the code graph. diff --git a/packs/github-issues/.apm/skills/check-pr-contract/scripts/Invoke-IssuePreflight.Tests.ps1 b/packs/github-issues/.apm/skills/check-pr-contract/scripts/Invoke-IssuePreflight.Tests.ps1 index a0cda3a..8a16f57 100644 --- a/packs/github-issues/.apm/skills/check-pr-contract/scripts/Invoke-IssuePreflight.Tests.ps1 +++ b/packs/github-issues/.apm/skills/check-pr-contract/scripts/Invoke-IssuePreflight.Tests.ps1 @@ -42,6 +42,27 @@ Describe 'Invoke-IssuePreflight' { $rows[0].Detail | Should -Match 'title or body' } + It 'returns a SKIP row on main when git.allowTrunkPush is on, and a FAIL row when it is off' { + git -C $script:Repo checkout -q -B main 2>$null + $rows = @(& $script:ScriptUnderTest -RepoRoot $script:Repo -GhCommand $script:NoGh 6>$null) + $rows[0].Status | Should -Be 'FAIL' + + $config = Join-Path $script:Repo 'aisdlc.json' + $saved = Get-Content -LiteralPath $config -Raw + try { + Set-Content -LiteralPath $config -Value '{ "tracker": { "repository": "contoso/portal" }, "git": { "allowTrunkPush": true } }' + $rows = @(& $script:ScriptUnderTest -RepoRoot $script:Repo -GhCommand $script:NoGh 6>$null) + $rows.Count | Should -Be 1 + $rows[0].Status | Should -Be 'SKIP' + $rows[0].Detail | Should -Match 'git.allowTrunkPush' + + git -C $script:Repo checkout -q -B feature/no-key 2>$null + $rows = @(& $script:ScriptUnderTest -RepoRoot $script:Repo -GhCommand $script:NoGh 6>$null) + $rows[0].Status | Should -Be 'FAIL' -Because 'the setting only covers main and master' + } + finally { Set-Content -LiteralPath $config -Value $saved -NoNewline } + } + It 'returns NEEDS-GH for a branch that names a story key' { git -C $script:Repo checkout -q -B 1234-a-change 2>$null diff --git a/packs/github-issues/.apm/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1 b/packs/github-issues/.apm/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1 index 21dd90b..8c88138 100644 --- a/packs/github-issues/.apm/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1 +++ b/packs/github-issues/.apm/skills/check-pr-contract/scripts/Invoke-IssuePreflight.ps1 @@ -11,6 +11,8 @@ story key (42-short-name, or the bare number 42 of a bug branch) is a FAIL row, so the pre-flight writes no receipt, with or without gh. Set PR_STORY_KEY to name the key of a branch that cannot carry it. Outside a git repository there is no branch, and this step is left out. + On main or master in a repository that sets git.allowTrunkPush, the row is SKIP: a change there has + no story or pull request on purpose. When gh is installed and signed in (`gh auth status` succeeds), it runs Check-PrStoryContract.ps1 for the current branch and the changed files. Without it, it says what is needed; the same check @@ -54,7 +56,11 @@ Write-Host "Issue contract (gh; the same check runs from the run-preflight skill $branch = [string](git -C $RepoRoot rev-parse --abbrev-ref HEAD 2>$null) # The story key needs no GitHub read, so a branch without one fails before the gh check. The branch rule # is the one Check-PrStoryContract.ps1 uses, so both forms agree on what a key is. -if ($branch -and -not ($env:PR_STORY_KEY -or (Get-AiSdlcBranchStoryKey -Branch $branch))) { +# A repository that sets git.allowTrunkPush changes main or master directly, with no story or pull request. +if ($branch -in 'main', 'master' -and -not $env:PR_STORY_KEY -and (Test-AiSdlcTrunkPushAllowed -RepoRoot $RepoRoot)) { + [pscustomobject]@{ Check = 'IssueContract (story + ADR)'; Status = 'SKIP'; Detail = "branch '$branch' is the main branch, and git.allowTrunkPush in aisdlc.json lets a change go there without a story or pull request" } +} +elseif ($branch -and -not ($env:PR_STORY_KEY -or (Get-AiSdlcBranchStoryKey -Branch $branch))) { [pscustomobject]@{ Check = 'IssueContract (story + ADR)'; Status = 'FAIL'; Detail = "branch '$branch' names no story key, and the pre-flight has no pull request title or body to read; start the branch name with the issue number (42-short-name), or set PR_STORY_KEY to the key" } } elseif (Test-GhReady) { diff --git a/packs/github-issues/apm.yml b/packs/github-issues/apm.yml index 5cd691b..0647fa6 100644 --- a/packs/github-issues/apm.yml +++ b/packs/github-issues/apm.yml @@ -1,3 +1,3 @@ name: ai-sdlc-github-issues -version: "1.3.0" +version: "1.3.1" description: The GitHub Issues pack - issue conventions and the issue contract gates. diff --git a/packs/github/apm.yml b/packs/github/apm.yml index c892d1f..c09968a 100644 --- a/packs/github/apm.yml +++ b/packs/github/apm.yml @@ -1,3 +1,3 @@ name: ai-sdlc-github -version: "1.3.0" +version: "1.3.1" description: The GitHub pack - pull requests, review threads, pull request delivery metrics and the GitHub Actions workflows. diff --git a/packs/knowledge/apm.yml b/packs/knowledge/apm.yml index f125836..dc40d32 100644 --- a/packs/knowledge/apm.yml +++ b/packs/knowledge/apm.yml @@ -1,3 +1,3 @@ name: ai-sdlc-knowledge -version: "1.3.0" +version: "1.3.1" description: The knowledge pack - the conventions and the workflow for platform knowledge notes in the knowledge repository. diff --git a/packs/sonarcloud/apm.yml b/packs/sonarcloud/apm.yml index ecff446..2350d83 100644 --- a/packs/sonarcloud/apm.yml +++ b/packs/sonarcloud/apm.yml @@ -1,5 +1,5 @@ name: ai-sdlc-sonarcloud -version: "1.3.0" +version: "1.3.1" description: The SonarQube Cloud pack - the SonarQube MCP server for the agent session, and the gate that keeps the token and the organization out of the repository. dependencies: mcp: From b09467048919e7155c77bcae9ee5b08e4511d9f8 Mon Sep 17 00:00:00 2001 From: Rob Hofmann Date: Mon, 9 Nov 2026 20:14:17 +0100 Subject: [PATCH 2/2] Update the lock to v1.3.1 Refs #18 --- apm.lock.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/apm.lock.yaml b/apm.lock.yaml index 940cc2d..bd7a947 100644 --- a/apm.lock.yaml +++ b/apm.lock.yaml @@ -3,7 +3,7 @@ apm_version: 0.31.0 dependencies: - repo_url: _local/core name: ai-sdlc-core - version: 1.3.0 + version: 1.3.1 package_type: apm_package deployed_files: - .claude/agents/architect.md @@ -427,7 +427,7 @@ dependencies: local_path: ./core - repo_url: _local/discovery name: ai-sdlc-discovery - version: 1.3.0 + version: 1.3.1 package_type: apm_package deployed_files: - .claude/skills/draw-customer-journey @@ -444,7 +444,7 @@ dependencies: local_path: ./packs/discovery - repo_url: _local/github name: ai-sdlc-github - version: 1.3.0 + version: 1.3.1 package_type: apm_package deployed_files: - .claude/skills/fix-pr-feedback @@ -534,7 +534,7 @@ dependencies: local_path: ./packs/github - repo_url: _local/github-issues name: ai-sdlc-github-issues - version: 1.3.0 + version: 1.3.1 package_type: apm_package deployed_files: - .claude/agents/draft-reviewer.md