From 6393e954bf6d6cb5db360346b7c724995a20c18e Mon Sep 17 00:00:00 2001 From: Dave Liu <7david12liu@gmail.com> Date: Wed, 26 Aug 2026 14:59:16 -0700 Subject: [PATCH 1/2] Guard staging App Check Hosting deploy --- GITHUB_ISSUES.md | 2 +- IMPLEMENTATION_PLAN.md | 2 + OFFICER_START_HERE.md | 2 +- OPERATIONS_RUNBOOK.md | 11 +- README.md | 2 +- SECURITY.md | 2 +- SYSTEM_DESIGN.md | 2 +- docs/officers/PUBLISH_AND_CHECK.md | 39 ++- docs/officers/README.md | 2 +- docs/officers/SYSTEM_MAPS.md | 4 +- package.json | 2 + scripts/firebase-hosting-contract.js | 19 ++ scripts/firebase-hosting-staging-contract.js | 221 +++++++++++++++ tests/firebase-hosting-foundation.test.js | 280 ++++++++++++++++++- 14 files changed, 575 insertions(+), 15 deletions(-) create mode 100644 scripts/firebase-hosting-staging-contract.js diff --git a/GITHUB_ISSUES.md b/GITHUB_ISSUES.md index 54ae553..e1e3f87 100644 --- a/GITHUB_ISSUES.md +++ b/GITHUB_ISSUES.md @@ -146,7 +146,7 @@ Do not redesign routing or hosting in this issue; WEB-001 owns that. WEB-001A1 [ **Current CI-001C boundary:** CI-001C1 [#667](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/667) supplies the staging-only protected read-only OIDC proof: exact immutable repository/owner IDs, `main`, the `staging` environment, one verifier workflow, two named individual reviewers, and a keyless principal with only project-identity read permission. Parent #133 still owns Firebase deployment roles and production protection; #136 still owns an actual backend release. -**Current CI-001D boundary:** CI-001D1 [#669](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/669) supplies the first staging data boundary: empty Native/Standard `(default)` Firestore in `us-west2`, delete protection enabled, PITR disabled, and exact Rules/indexes from `ee16bd16220ab58bd3a2add80dd2f39a1d514dd7`. The 418-case Rules suite passed, provider definitions matched, fixed anonymous server-only reads were denied, and root collection count remained zero. CI-001D2 [#671](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/671) deploys the email/password-only Auth contract from exact merged source `42542303d043f87a8f1a04be2f0b4f2a88e0318c`. Provider readback and disposable API/browser checks prove password-required sign-in, improved email privacy, only staging domains, no other provider, billing disabled, and final cleanup to zero users/records. CI-001D3 [#674](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/674) adds a source-only, argument-closed command for exactly `createMemberOnSignUp` and `ensureMemberProfile`; its tests reject broad/partial targets, another project/account, a credentials file, changed exports/scripts, extra arguments, and an unpinned CLI. Read-only preflight found project Owner authority, billing disabled, and zero open billing accounts visible to the club account. No Function/API/billing/data/provider mutation is part of #674. Functions, App Check, provider sandboxes, reusable deploy authority, application records, and production behavior remain absent. Parent #133 still owns keyless Firebase deployment roles and production protection; #136 still owns the compatible synthetic backend release. +**Current CI-001D boundary:** CI-001D1 [#669](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/669) supplies the first staging data boundary: empty Native/Standard `(default)` Firestore in `us-west2`, delete protection enabled, PITR disabled, and exact Rules/indexes from `ee16bd16220ab58bd3a2add80dd2f39a1d514dd7`. The 418-case Rules suite passed, provider definitions matched, fixed anonymous server-only reads were denied, and root collection count remained zero. CI-001D2 [#671](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/671) deploys the email/password-only Auth contract from exact merged source `42542303d043f87a8f1a04be2f0b4f2a88e0318c`. Provider readback and disposable API/browser checks prove password-required sign-in, improved email privacy, only staging domains, no other provider, billing disabled, and final cleanup to zero users/records. CI-001D3 [#674](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/674) adds a source-only, argument-closed command for exactly `createMemberOnSignUp` and `ensureMemberProfile`; its tests reject broad/partial targets, another project/account, a credentials file, changed exports/scripts, extra arguments, and an unpinned CLI. Read-only preflight found project Owner authority, billing disabled, and zero open billing accounts visible to the club account. No Function/API/billing/data/provider mutation is part of #674. CI-001D4 [#676](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/676) adds a source-only, argument-closed Hosting command for the exact staging project/account/quota/scope and pinned CLI. It requires a bounded non-placeholder Enterprise site key before deployment and in the executable artifact while leaving local/test and credential-free previews unchanged. Its source phase creates no key, App Check configuration, enforcement setting, Hosting version, user, record, Function, billing link, or production change. Parent #133 still owns keyless Firebase deployment roles and production protection; #136 still owns the compatible synthetic backend release. ### Problem diff --git a/IMPLEMENTATION_PLAN.md b/IMPLEMENTATION_PLAN.md index ed02a32..e240b2b 100644 --- a/IMPLEMENTATION_PLAN.md +++ b/IMPLEMENTATION_PLAN.md @@ -48,6 +48,8 @@ MPRC can open a race or merchandise item for sale only when the platform can: **CI-001D3 staging profile-Function guard:** [#674](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/674) adds an argument-closed source command for exactly `createMemberOnSignUp` and `ensureMemberProfile`. It validates the demo-only default alias, single reviewed Functions codebase, exact exports, lockfile Firebase CLI 15.24.0, staging project and quota project, club-account declaration, exact target list, short-lived token path, and absence of credential-file overrides before invoking Firebase. Negative tests reject missing/redirected exports, broad or partial target sets, production/cross-project context, extra arguments, changed scripts, and an unpinned CLI. Read-only provider preflight found project Owner authority but billing disabled and zero visible open billing accounts. #674 therefore enables no API, links no billing, deploys no Function, creates no record, and leaves App Check, staging E2E, reusable release authority, and production to later approved children. +**CI-001D4 staging App Check/Hosting guard:** [#676](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/676) adds a source-only, argument-closed Hosting command for `run-mprc-staging`. It validates the demo-only default alias, exact Hosting predeploy chain, Firebase CLI 15.24.0, staging project and quota project, club-account declaration, Hosting-only scope, short-lived token path, absence of credential-file overrides, and one bounded non-placeholder Enterprise site key. The executable artifact check must also find the selected key. Ordinary local/test and credential-free preview builds remain unchanged. Source/tests/merge do not create or register a provider key, republish Hosting, enable Auth/Firestore enforcement, deploy Functions, link billing, change production, or prove live token behavior; those are separate provider/evidence states in #676. + ## 3. Dependency map ```mermaid diff --git a/OFFICER_START_HERE.md b/OFFICER_START_HERE.md index 0b644a3..63a688e 100644 --- a/OFFICER_START_HERE.md +++ b/OFFICER_START_HERE.md @@ -50,7 +50,7 @@ As of **2026-08-13**, a merge runs checks but does not start the GitHub release. As of **2026-08-14**, [#659](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/659) completed one accessibility-only Netlify release. Deploy `6a7ece87c5ca4d0007c1a3fc` is live from frozen source `7496fe0881fb52908c4ff2f40f488df09c94c908`; its exact 62-file marker and signed-out desktop/phone route-focus and menu checks passed. Repause merge `3138a00c1c48e1d5d1dcda0b44722b09a2194ff7` made the manifest inactive. Its attempt `6a7ed0ddb00a46000818878d` published nothing and retained the verified deploy. #623 deploy `6a7e072f8f346b0008510d29` is the recorded rollback, not current production. #659 changed no Firebase, provider configuration, account, sign-in state, production data, payment, or connected directory behavior. Officers do not run commands, sign in, enter data, or approve this as a reusable release. Follow the completed record in [Review, merge, release, and check a change](./docs/officers/PUBLISH_AND_CHECK.md). -As of **2026-08-26**, WEB-001A1 [#663](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/663) is merged, and WEB-001A2 [#665](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/665) created the club-owned `run-mprc-staging` project and published exact source `a614c68d9a1a2be631a3be874a686d61e5d170a0` to [run-mprc-staging.web.app](https://run-mprc-staging.web.app). CI-001C1 [#667](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/667) adds a separate protected read-only identity check: Dave Liu or Jeff Chang reviews exact `main`, and a keyless five-minute identity may read only the staging project identity. It cannot deploy Firebase. CI-001D1 [#669](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/669) adds an empty, delete-protected staging Firestore database and the exact reviewed Rules/index definitions. Anonymous reads of three fixed server-only paths were denied, and the database still had zero root collections after verification. CI-001D2 [#671](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/671) deploys password-required email/password Auth from exact merged source and proves it with disposable API and browser sign-in/sign-out checks. Readback shows improved email privacy, only the two staging domains, no other provider, billing disabled, and zero users/records after cleanup. CI-001D3 [#674](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/674) adds a code guard for a future deployment of only the two profile Functions. It does not deploy them. Read-only checks found no billing account available to the club account, and Firebase requires pay-as-you-go billing for Functions. This remains an **ENGINEERING STAGING SITE ONLY**. It has no trusted Functions, App Check, outside-provider sandbox, protected automatic release, release marker, tested predecessor rollback, complete security-header policy, custom domain, or officer publish control. Officers do not sign in, enter data, run commands, attach billing, or treat a command guard as a usable member backend. Netlify still answers `runmprc.com`; production Firebase Hosting remains empty, and no DNS, GitHub Pages, Netlify, production Firebase, production data, or live website behavior changed. +As of **2026-08-26**, WEB-001A1 [#663](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/663) is merged, and WEB-001A2 [#665](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/665) created the club-owned `run-mprc-staging` project and published exact source `a614c68d9a1a2be631a3be874a686d61e5d170a0` to [run-mprc-staging.web.app](https://run-mprc-staging.web.app). CI-001C1 [#667](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/667) adds a separate protected read-only identity check: Dave Liu or Jeff Chang reviews exact `main`, and a keyless five-minute identity may read only the staging project identity. It cannot deploy Firebase. CI-001D1 [#669](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/669) adds an empty, delete-protected staging Firestore database and the exact reviewed Rules/index definitions. Anonymous reads of three fixed server-only paths were denied, and the database still had zero root collections after verification. CI-001D2 [#671](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/671) deploys password-required email/password Auth from exact merged source and proves it with disposable API and browser sign-in/sign-out checks. Readback shows improved email privacy, only the two staging domains, no other provider, billing disabled, and zero users/records after cleanup. CI-001D3 [#674](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/674) adds a code guard for a future deployment of only the two profile Functions. It does not deploy them. Read-only checks found no billing account available to the club account, and Firebase requires pay-as-you-go billing for Functions. CI-001D4 [#676](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/676) adds a separate code guard for a future staging Hosting release with App Check configuration. It requires the exact club account and staging project, a Hosting-only scope, a short-lived credential path, and a valid-looking Enterprise public site key in the built website. Source and tests do not create the key, publish the site, or turn protection on. This remains an **ENGINEERING STAGING SITE ONLY**. Until #676 posts provider and browser evidence, it has no trusted Functions, live App Check, outside-provider sandbox, protected automatic release, release marker, tested predecessor rollback, complete security-header policy, custom domain, or officer publish control. Officers do not sign in, enter data, run commands, attach billing, or treat a command guard as a usable member backend. Netlify still answers `runmprc.com`; production Firebase Hosting remains empty, and no DNS, GitHub Pages, Netlify, production Firebase, production data, or live website behavior changed. The optional profile-photo and officer People-finder functions are still **NOT AVAILABLE YET**. #621 makes the frontend default an inert preview: My Account shows the future photo and separate finder-choice controls disabled, while the People finder stays behind the administrator guard and shows its name field and Search button disabled. The preview reads no saved photo or setting, accepts or uploads no photo, searches no name, and saves nothing; it shows no people or sample results. #623 published exactly that disabled interface as deploy `6a7e072f8f346b0008510d29`. Officers inspect the protected layouts only in synthetic local artifacts. The completed signed-out production review proved only the exact revision, normal sign-in and administrator guards, and absence of a member-directory network request. Do not sign in to production, choose a real photo, enter a real name, or treat the preview as a directory. #623 changed no Firebase, provider configuration, account, sign-in, or production data. #507 must later prove the privacy, authorization, staging, backend-first deployment, and readback gates before a separate reviewed source change may connect it. Follow the preview and source-review procedure in [Events, shop, members, and money](./docs/officers/EVENTS_SHOP_MEMBERS.md). diff --git a/OPERATIONS_RUNBOOK.md b/OPERATIONS_RUNBOOK.md index 1f0da17..3ed7f40 100644 --- a/OPERATIONS_RUNBOOK.md +++ b/OPERATIONS_RUNBOOK.md @@ -78,6 +78,8 @@ The bounded provider phase ran on 2026-08-26 from exact merged source `42542303d CI-001D3 [#674](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/674) adds `npm run deploy:staging-profile-functions` as a source-only, argument-closed wrapper. Before Firebase CLI it checks the demo-only default alias, one reviewed Functions codebase, both exact profile exports, lockfile CLI 15.24.0, `run-mprc-staging` as both project and quota project, `runmprc@gmail.com` as the declared operator, an in-memory short-lived token, no credential-file override, and exactly `functions:createMemberOnSignUp,functions:ensureMemberProfile`. Do not add arguments or invoke the command directly from a branch. Read-only preflight on 2026-08-26 showed the club account is project Owner, project billing is disabled, and that account can see zero open billing accounts. Firebase requires Blaze for Function deployment, so do not enable APIs or run this command until a separately approved billing account, budget/alerts, exact-main source, and provider release issue exist. The guard itself deploys nothing and does not make App Check or staging profile behavior available. +CI-001D4 [#676](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/676) adds `npm run deploy:staging-hosting` as a separate source-only, argument-closed wrapper. It checks the demo-only default alias, exact Hosting predeploy chain, lockfile CLI 15.24.0, exact staging project/quota/account, Hosting-only scope, in-memory short-lived token, no credential-file override, and a bounded non-placeholder Enterprise site key. The existing executable scanner must find that same public key in the built JavaScript. Do not run it from a branch, append arguments, use a debug token, add localhost to provider domains, or treat the public site key as a server credential. Source/tests/merge do not configure the provider, publish Hosting, or enable service enforcement; #676 records those as separate later states. + The repository's only `.firebaserc` default is now `demo-mprc-local`, a deliberately non-deployable local namespace. It is an accidental-deploy brake, not staging. Every future deployment must still pass one exact privately approved project explicitly. Do not infer backend/provider isolation or release authority from the static host; #113/#133 must protect, map, and verify those remaining boundaries. ## 4. Configuration and secrets @@ -117,10 +119,11 @@ The safe sequence remains: 1. Confirm the approved Firebase project and host inventory under #113. 2. Merge and verify #159 source/tests without a real key. -3. Have the named owner create the Enterprise site key and allowed-domain policy for the approved environment. -4. Bind website preparation to the approved protected Actions scope under #133/a dedicated CI child, then store only that public site key there. The current preparation job has no environment binding and can read only repository/organization variables; do not use that gap as a production shortcut. -5. Rehearse a synthetic staging page, observe App Check metrics, and prove expected token behavior before ABUSE-001A2 enables any callable enforcement. -6. Publish and verify the website, Firebase, provider, and live behavior as separate states under #136/WEB-001. +3. Merge and verify the #676 staging-only Hosting/App Check deploy guard without a real key. +4. Under the #676 provider phase, have the named owner create one score-based Enterprise key restricted to the two staging hosts and register it only to the staging web app. +5. Use the exact merged source and guarded Hosting-only command to publish the staging client, then prove token-bearing browser Auth/Firestore behavior before changing enforcement. +6. Enable only staging Authentication and Firestore enforcement, prove missing-token denial plus continued browser success, and retain the documented monitoring-only rollback. +7. Keep native callable enforcement and Function deployment separate until the billing gate is explicitly approved; publish and verify production website, Firebase, provider, and live behavior separately under #136/WEB-001. A source merge, green CI run, or public-key variable alone does not prove Enterprise is configured or protecting a callable. diff --git a/README.md b/README.md index d62a078..0f92925 100644 --- a/README.md +++ b/README.md @@ -43,7 +43,7 @@ Historical developer/content/LLM guides remain under [`docs/`](./docs/README.md) **Deployment reality checked 2026-08-14:** merges run CI but do not start the manual release workflow. The protected gate accepts one exact current merged commit, rechecks its newest CI run after approval, uses one fixed Firebase target set, fails when protected authority/configuration is missing, verifies Firebase before publishing GitHub Pages, and gives no server credential to website preparation or publication. Ordinary Git-triggered Netlify production builds are paused. WEB-002D [#659](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/659) completed one bounded accessibility release: exact merge `46e23647d8e0bf9fa3a574ea5c5f993be10a419d` published deploy `6a7ece87c5ca4d0007c1a3fc` from source `7496fe0881fb52908c4ff2f40f488df09c94c908`, tree `ccac4c189c195db8ab594e0eefe256ea9fa04996`, 62 files, and artifact digest `e4c26e6f0fbcd086663d86238675f0be228fb649a00628c1c97d1166612f49c7`. Signed-out desktop and phone route-focus/menu checks passed. Repause merge `3138a00c1c48e1d5d1dcda0b44722b09a2194ff7` passed exact-main CI run `31783808994`; attempt `6a7ed0ddb00a46000818878d` published nothing, deploy `6a7ece87c5ca4d0007c1a3fc` remained live, and the manifest is inactive. #623 deploy `6a7e072f8f346b0008510d29` remains rollback history and its inert directory interface is unchanged beneath the accessibility delta. No Firebase, Rules, Functions, indexes, provider configuration, account, sign-in state, role, member data, payment, or connected directory backend changed. The prior bounded #473 deploy `6a6dc9ea588b0c0008036312` remains older history. The source stops adding a Pages `CNAME`, but GitHub Pages currently still claims `runmprc.com` and its default URL redirects there; only a controlled #136/WEB-001 publication and provider readback can clear that conflict. Reusable protected publication to the live Netlify-served `runmprc.com` is not configured yet. Treat GitHub Pages, Netlify, `runmprc.com`, Firebase, and outside providers as separate states. -**Owned staging checked 2026-08-26:** WEB-001A2 [#665](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/665) created the isolated `run-mprc-staging` Firebase project under the club account and published exact source `a614c68d9a1a2be631a3be874a686d61e5d170a0` as Hosting version `3ffadcf2ac8cc760` at [run-mprc-staging.web.app](https://run-mprc-staging.web.app). Signed-out desktop, phone, and direct `/events` checks passed. CI-001C1 [#667](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/667) adds a protected staging-only OIDC verifier with two named reviewers and a keyless principal that can read only the exact project identity. CI-001D1 [#669](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/669) adds the empty delete-protected `(default)` Firestore database in `us-west2` and deploys exact Rules/indexes from source `ee16bd16220ab58bd3a2add80dd2f39a1d514dd7`; provider definitions matched, fixed anonymous server-only reads were denied, and the root collection count remained zero. CI-001D2 [#671](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/671) deployed exact merged source `42542303d043f87a8f1a04be2f0b4f2a88e0318c` to Auth only. Live readback shows instrumentless Firebase Authentication with Identity Platform, billing disabled, password-required email/password, improved email privacy, only the two staging authorized domains, and no anonymous, phone, native federated, OIDC, or SAML provider. Disposable API and browser sign-in/sign-out checks passed, both identities were removed, no email or SMS was requested, and the final user and Firestore root-collection counts were zero. CI-001D3 [#674](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/674) adds a source-only guard for exactly `createMemberOnSignUp` and `ensureMemberProfile`; it rejects a broad Function target, another project/account, a credential file, an unpinned CLI, or appended arguments before Firebase CLI. Read-only preflight found billing disabled and no open billing account visible to the club account, so no Function API was enabled and no Function was deployed. This remains incomplete engineering staging: trusted Functions, App Check enforcement, outside-provider sandboxes, reusable Firebase deployment authority, application security headers, a release marker, and a tested predecessor rollback are not configured. Do not use real data or treat staging sign-in as an operational member system. Production Firebase Hosting remains empty and `runmprc.com` remains on its existing Netlify deployment. +**Owned staging checked 2026-08-26:** WEB-001A2 [#665](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/665) created the isolated `run-mprc-staging` Firebase project under the club account and published exact source `a614c68d9a1a2be631a3be874a686d61e5d170a0` as Hosting version `3ffadcf2ac8cc760` at [run-mprc-staging.web.app](https://run-mprc-staging.web.app). Signed-out desktop, phone, and direct `/events` checks passed. CI-001C1 [#667](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/667) adds a protected staging-only OIDC verifier with two named reviewers and a keyless principal that can read only the exact project identity. CI-001D1 [#669](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/669) adds the empty delete-protected `(default)` Firestore database in `us-west2` and deploys exact Rules/indexes from source `ee16bd16220ab58bd3a2add80dd2f39a1d514dd7`; provider definitions matched, fixed anonymous server-only reads were denied, and the root collection count remained zero. CI-001D2 [#671](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/671) deployed exact merged source `42542303d043f87a8f1a04be2f0b4f2a88e0318c` to Auth only. Live readback shows instrumentless Firebase Authentication with Identity Platform, billing disabled, password-required email/password, improved email privacy, only the two staging authorized domains, and no anonymous, phone, native federated, OIDC, or SAML provider. Disposable API and browser sign-in/sign-out checks passed, both identities were removed, no email or SMS was requested, and the final user and Firestore root-collection counts were zero. CI-001D3 [#674](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/674) adds a source-only guard for exactly `createMemberOnSignUp` and `ensureMemberProfile`; it rejects a broad Function target, another project/account, a credential file, an unpinned CLI, or appended arguments before Firebase CLI. Read-only preflight found billing disabled and no open billing account visible to the club account, so no Function API was enabled and no Function was deployed. CI-001D4 [#676](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/676) adds a separate source guard for an exact staging Hosting deployment: it requires the club account, exact project/quota/scope, short-lived token path, pinned CLI, and a bounded non-placeholder Enterprise site key, then requires that key in the executable artifact. That source guard alone does not create a key, configure App Check, republish Hosting, or enable enforcement. This remains incomplete engineering staging: trusted Functions, live App Check enforcement, outside-provider sandboxes, reusable Firebase deployment authority, application security headers, a release marker, and a tested predecessor rollback are not configured. Do not use real data or treat staging sign-in as an operational member system. Production Firebase Hosting remains empty and `runmprc.com` remains on its existing Netlify deployment. ## Local setup status diff --git a/SECURITY.md b/SECURITY.md index 0622952..9ccbdcb 100644 --- a/SECURITY.md +++ b/SECURITY.md @@ -47,7 +47,7 @@ The findings below describe the repository at the start of the 2026-07-12 assess | RISK-007 | Repository source rejects unverified targets at the two existing role-grant endpoints. AUTH-001B [#196](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/196) adds exact verified-email checks to role-based Firestore Rules, and AUTH-001C [#209](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/209) tracks the matching gate at current Functions role consumers. Firebase deployment, verification-mirror refresh, revocation, authoritative membership, scoped capability/recent-auth controls, and replacement of the legacy static-key endpoint remain unproven. | Older deployed code or a remaining role-only server guard can let an unverified known-email account use member/admin authority. CSV export also retains separate minimization, recent-auth, and audit risks. | Deploy and verify the exact Rules/Functions through #105, complete the remaining AUTH-001 mirror/revocation work, require authoritative membership and scoped privileged access, harden roster export under #116, and retire the static-key endpoint. | | RISK-008 | `requireAppCheck` is controlled by optional `ENFORCE_APP_CHECK`; repository/deployment config does not prove it is true. Missing site key also disables client App Check. | Public callable functions may be scripted directly, enabling abuse and cloud/Stripe cost amplification. | Use Firebase runtime `enforceAppCheck: true` for sensitive callables, reCAPTCHA Enterprise, staged metrics, and no environment fail-open. | | RISK-009 | #99 source preserves and validates the complete same-origin Pages callback route, applies `strict-origin` before subresources, and suppresses initial callback App Check/telemetry startup; #126 adds that standalone suite as a blocking hosted CI step. #443 adds only the source/test Strava same-document handoff after the native and Router callback locations are clean. No production Stripe/Strava callback, provider-backed App Check token behavior, or live custom-domain handoff has been rehearsed, and the live custom domain uses a different host. | Hosting, provider, configuration, or release drift can still break return links or the App Check handoff even when source tests pass. Enforcing a callback callable without its matching released client handoff and staged provider evidence can also break confirmation or Strava exchange. | Keep the hosted callback gate blocking; keep `lookupRegistration`/`lookupOrder` deferred until DATA-001A; keep native enforcement for `stravaExchangeCode` deferred to ABUSE-001A2 after the exact #443 website source and provider-backed Enterprise token behavior are proven in protected staging; verify test-mode callbacks only after provider gates; consolidate hosting under WEB-001. | -| RISK-010 | Development/test use synthetic loopback Auth, Firestore, and Functions. WEB-001A1 [#663](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/663) binds controlled Hosting builds to an explicit environment, and WEB-001A2 [#665](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/665) supplies owned static staging. CI-001D1 [#669](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/669) adds an empty delete-protected Firestore database with exact Rules/indexes. CI-001D2 [#671](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/671) deploys and verifies password-required email/password Auth with improved email privacy. CI-001D3 [#674](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/674) narrows the future staging command to the two profile Functions, but billing is unapproved and the project still has no Functions or App Check. Storage data, provider sandboxes, protected Firebase deployment authority, and a release marker remain absent; emulated Functions can still call outside providers. | A partially provisioned stage, bypassed build path, or provider-capable emulator can be mistaken for complete staging and affect production/provider systems. | Keep real identities and private actions out of previews; preserve the fixed project, exact Rules, Auth-only evidence, and source-only two-Function guard; do not link billing merely to make a test pass; complete #113/#133/#136 Functions, App Check, short-lived deploy authority, and provider isolation; prove test keys, sinks, exact marker readback, and rollback before end-to-end flows. | +| RISK-010 | Development/test use synthetic loopback Auth, Firestore, and Functions. WEB-001A1 [#663](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/663) binds controlled Hosting builds to an explicit environment, and WEB-001A2 [#665](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/665) supplies owned static staging. CI-001D1 [#669](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/669) adds an empty delete-protected Firestore database with exact Rules/indexes. CI-001D2 [#671](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/671) deploys and verifies password-required email/password Auth with improved email privacy. CI-001D3 [#674](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/674) narrows the future staging command to the two profile Functions, but billing is unapproved. CI-001D4 [#676](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/676) narrows a separate future staging Hosting command and requires one non-placeholder Enterprise key in both deployment context and executable artifact. The project still has no Functions or live App Check configuration at the source phase. Storage data, provider sandboxes, protected Firebase deployment authority, and a release marker remain absent; emulated Functions can still call outside providers. | A partially provisioned stage, bypassed build path, or provider-capable emulator can be mistaken for complete staging and affect production/provider systems. | Keep real identities and private actions out of previews; preserve the fixed project, exact Rules, Auth-only evidence, and both source-only deploy guards; do not link billing merely to make a test pass; complete #676 provider/token/enforcement proof and #113/#133/#136 Functions, short-lived deploy authority, and provider isolation; prove test keys, sinks, exact marker readback, and rollback before end-to-end flows. | | RISK-011 | Local cancellation only changes Firestore; it does not expire the active Stripe Session. The webhook can later move a cancelled record back to paid. | Customers can pay a supposedly cancelled registration/order; capacity/inventory and support state diverge. | Add explicit cancellation saga with Stripe Session expiry and allowed-state transitions. | | RISK-012 | Repository source now denies every admitted positive late-registration amount before identifier/token allocation, registration writes, Stripe construction, or Product/Price/Payment Link calls, and the Admin screen exposes only the exact-zero compatibility path. Firebase deployment is unproven, and legacy reusable Payment Links may still exist. | Older deployed code or an existing link can still create unreconciled or repeated charges/Sessions for one logical registration. The exact-zero local record is also marked paid without Stripe and is not payment, free, comp, or membership authority. | Keep paid late registration unavailable; inventory, deactivate, and reconcile legacy links privately; then replace them with one-off idempotent Checkout Sessions through the normal registration/payment lifecycle. | | RISK-013 | The assessment baseline permitted Stripe promotions while Firestore stored base price. Repository source now disables promotion entry and automatic tax, requires a complete adjustment breakdown, and quarantines unknown or nonzero discount/tax/shipping amounts; deployment and provider state are unproven. | An older open Session, provider drift, skipped backend release, or later guard regression could still make reporting, refunds, and local payment confirmation disagree. | Privately inventory pre-change Sessions/provider settings, release through the protected gate, verify Firebase and Stripe separately, and keep every adjustment disabled until an approved authoritative model exists. | diff --git a/SYSTEM_DESIGN.md b/SYSTEM_DESIGN.md index bfa0c6a..70771c4 100644 --- a/SYSTEM_DESIGN.md +++ b/SYSTEM_DESIGN.md @@ -277,7 +277,7 @@ Text alternative: exact reviewed source permits only a guarded Auth deployment t ## 4. Target deployment topology -The target keeps React, Firebase, and Stripe, but places stronger boundaries around them. Migrating the frontend from GitHub Pages/Netlify to Firebase Hosting is recommended before live commerce because it supports controlled SPA rewrites, preview channels, and security headers. #663 supplies the fail-closed build selector and inert Hosting rewrite configuration. #665 owns the isolated static staging host. CI-001C1 [#667](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/667) adds only a protected, read-only staging identity proof; it grants no Firebase deployment permission. CI-001D1 [#669](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/669) adds only the empty staging Firestore database and exact Rules/index boundary. CI-001D2 [#671](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/671) deploys and verifies the narrow email/password Auth configuration from exact merged source. CI-001D3 [#674](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/674) adds a source-only guard that can name only the two profile Functions in staging and cannot accept appended deployment arguments. The instrumentless project reports the `IDENTITY_PLATFORM` subtype and remains unlinked from billing; the club account currently sees no open billing account. The no-cost Auth ceiling is an operational limit, not authorization to link Cloud Billing. Backend Functions, App Check, reusable deployment authority, automatic exact-commit release, full backend readback, rollback, headers, production protection, outside-provider isolation, and DNS/TLS cutover remain separate work under #113/#133/#136/#460. The migration is not live merely because several staging layers and a source guard exist. +The target keeps React, Firebase, and Stripe, but places stronger boundaries around them. Migrating the frontend from GitHub Pages/Netlify to Firebase Hosting is recommended before live commerce because it supports controlled SPA rewrites, preview channels, and security headers. #663 supplies the fail-closed build selector and inert Hosting rewrite configuration. #665 owns the isolated static staging host. CI-001C1 [#667](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/667) adds only a protected, read-only staging identity proof; it grants no Firebase deployment permission. CI-001D1 [#669](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/669) adds only the empty staging Firestore database and exact Rules/index boundary. CI-001D2 [#671](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/671) deploys and verifies the narrow email/password Auth configuration from exact merged source. CI-001D3 [#674](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/674) adds a source-only guard that can name only the two profile Functions in staging and cannot accept appended deployment arguments. CI-001D4 [#676](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/676) adds an independent, argument-closed staging Hosting path. Its source contract binds the exact club account, project, quota project, Hosting-only scope, short-lived token path, Firebase CLI 15.24.0, and a bounded non-placeholder Enterprise site key; the existing artifact verifier must find that key in executable JavaScript. It does not by itself provision or register a key, configure service enforcement, or publish Hosting. The instrumentless project reports the `IDENTITY_PLATFORM` subtype and remains unlinked from billing; the club account currently sees no open billing account. The no-cost Auth ceiling is an operational limit, not authorization to link Cloud Billing. Backend Functions, live App Check, reusable deployment authority, automatic exact-commit release, full backend readback, rollback, headers, production protection, outside-provider isolation, and DNS/TLS cutover remain separate work under #113/#133/#136/#460. The migration is not live merely because several staging layers and source guards exist. ```mermaid flowchart TB diff --git a/docs/officers/PUBLISH_AND_CHECK.md b/docs/officers/PUBLISH_AND_CHECK.md index 93c5453..305734f 100644 --- a/docs/officers/PUBLISH_AND_CHECK.md +++ b/docs/officers/PUBLISH_AND_CHECK.md @@ -10,7 +10,7 @@ **Protected release status:** **NOT AVAILABLE YET.** Issue #135 provides the fail-closed source gate. Issue #133 must still configure protected `staging` and `production` environments, their named reviewers, and a short-lived cloud identity. Public browser build values must be named repository or organization variables because artifact preparation has no protected-environment access; #133/#136 must record and verify them separately. Do not add a long-lived Firebase key as a shortcut. -**Firebase staging status:** **STATIC HOSTING, EMPTY FIRESTORE, DISPOSABLE EMAIL/PASSWORD AUTH PROOF, AND A SOURCE-ONLY TWO-FUNCTION GUARD AVAILABLE; OFFICER AND PRODUCTION RELEASE NOT AVAILABLE YET.** WEB-001A1 [#663](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/663) requires controlled optimized builds to name staging or production and scans executable JavaScript for environment identity. WEB-001A2 [#665](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/665) created the club-owned `run-mprc-staging` project and published exact merged source `a614c68d9a1a2be631a3be874a686d61e5d170a0` to [run-mprc-staging.web.app](https://run-mprc-staging.web.app). CI-001D1 [#669](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/669) adds an empty delete-protected Firestore database and exact reviewed Rules/indexes; fixed anonymous server-only reads were denied and the root collection count remained zero. CI-001D2 [#671](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/671) deploys password-required email/password Auth from exact merged source, verifies provider/privacy/domain settings, passes disposable API/browser sign-in checks, and returns the project to zero users and records. CI-001D3 [#674](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/674) adds only a fail-closed code guard for the future paired profile Functions. Billing remains disabled, no open billing account is visible to the club account, and no Function/API/App Check change occurred. Officers do not sign in, enter information, run the command, attach billing, or use the site as a publish control. The site still has no Functions, App Check, provider sandbox, protected short-lived publication, release marker, tested predecessor rollback, complete security headers, custom domain, or DNS/TLS change. Production Firebase Hosting remains empty, and Netlify still serves `runmprc.com`. +**Firebase staging status:** **STATIC HOSTING, EMPTY FIRESTORE, DISPOSABLE EMAIL/PASSWORD AUTH PROOF, AND SOURCE-ONLY FUNCTION/HOSTING GUARDS AVAILABLE; OFFICER AND PRODUCTION RELEASE NOT AVAILABLE YET.** WEB-001A1 [#663](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/663) requires controlled optimized builds to name staging or production and scans executable JavaScript for environment identity. WEB-001A2 [#665](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/665) created the club-owned `run-mprc-staging` project and published exact merged source `a614c68d9a1a2be631a3be874a686d61e5d170a0` to [run-mprc-staging.web.app](https://run-mprc-staging.web.app). CI-001D1 [#669](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/669) adds an empty delete-protected Firestore database and exact reviewed Rules/indexes; fixed anonymous server-only reads were denied and the root collection count remained zero. CI-001D2 [#671](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/671) deploys password-required email/password Auth from exact merged source, verifies provider/privacy/domain settings, passes disposable API/browser sign-in checks, and returns the project to zero users and records. CI-001D3 [#674](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/674) adds only a fail-closed code guard for the future paired profile Functions. CI-001D4 [#676](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/676) adds a separate staging Hosting guard that requires the exact club account/project, Hosting-only scope, a short-lived token path, and a bounded Enterprise public site key in the executable artifact. Billing remains disabled, no open billing account is visible to the club account, and source does not prove a Function, key, App Check policy, or Hosting change. Officers do not sign in, enter information, run either command, configure App Check, attach billing, or use the site as a publish control. Until separate #676 provider/browser evidence exists, the site still has no Functions, live App Check, provider sandbox, protected short-lived publication, release marker, tested predecessor rollback, complete security headers, custom domain, or DNS/TLS change. Production Firebase Hosting remains empty, and Netlify still serves `runmprc.com`. **Live Netlify publication status:** a reusable protected release is **NOT AVAILABLE YET**. Ordinary Git-triggered production builds are paused by repository configuration. An overbroad #473 artifact was published and then rolled back on 2026-08-01; bounded #473 deploy `6a6dc9ea588b0c0008036312` is older history. #623 completed the inert-directory predecessor and remains the immediate rollback as deploy `6a7e072f8f346b0008510d29`, source `c2d87d1f69f15e128a0bc9b1b9f915b7c8417aec`. #659 completed one separate exact-artifact accessibility release. Deploy `6a7ece87c5ca4d0007c1a3fc`, source `7496fe0881fb52908c4ff2f40f488df09c94c908`, is production now. Its exact marker/artifact and signed-out route-focus/menu checks passed. The manifest is inactive, temporary refs are absent, and the rollback ref remains. Shop is the static catalog; Events and Calendar show a fixed retry-later notice; the directory remains inert. Event records remain unavailable because this did not deploy Firebase. GitHub Pages currently still claims the same custom domain; future source omits that claim, but #136/WEB-001 must publish and verify its removal. @@ -57,6 +57,7 @@ As of **2026-07-13**, with the internal tooling note below checked from source o - The separate #667 staging verifier uses a short-lived cloud identity after named approval. That identity can read only the staging project identity. The backend release still has no deployment authority. The website job receives public browser values only. - #669 used one bounded maintainer operation to provision empty staging Firestore and deploy exact Rules/indexes. It did not give the #667 identity or the general release workflow a deploy role. - #674 adds an argument-closed source wrapper for exactly `createMemberOnSignUp` and `ensureMemberProfile`. Its tests and merge are not Function deployment evidence. Billing approval, API enablement, App Check, provider readback, and synthetic profile proof remain separate. +- #676 adds a separate argument-closed source wrapper for Hosting only. It requires exact staging identity, the club account, short-lived token path, pinned CLI, and one bounded Enterprise public key in the executable artifact. Source/tests/merge are not key registration, Hosting publication, enforcement, or token evidence. - The Firebase CLI comes from the committed lockfile. The release does not install `latest`. - Source checked on 2026-07-22 pins the internal Firebase CLI to 15.24.0, and its emulator checks use Java 21. Officers do not install or run either tool; the platform maintainer owns them. This source change does not alter the release diagram or prove that Firebase was deployed. The provider and live-host facts below were not reverified for this tooling update. - Source checked on 2026-08-01 pins every root brace-expansion dependency family to reviewed compatible releases 1.1.18, 2.1.4, and 5.0.9 after a new advisory and follow-up bypass fixes. This is internal dependency evidence only. Officers do not install packages, run audit commands, or resolve dependency warnings; the platform maintainer owns those tasks. The separate minimatch finding remains open. This source change does not publish a website, deploy Firebase, change a provider, or prove live behavior. @@ -529,6 +530,42 @@ Text alternative: exact reviewed source and a narrow club-account Auth operation **Escalation:** platform owner first, security owner second. Use the private incident path if a real or unexpected account, provider, billing link, record, or credential-shaped output appears. +## Review the staging App Check guard — SOURCE ONLY, NOT LIVE + +**Purpose:** let a backup officer confirm what the #676 source guard permits and what still requires separate provider and browser evidence, without signing in, running a command, or handling a key or credential. + +**Approver:** platform owner plus the named security reviewer for #676. + +**Prerequisites:** merged #676 source pull request, green exact-main CI, and an issue statement that clearly says provider configuration and Hosting publication have not yet been proved. + +```mermaid +flowchart LR + Source["Exact merged #676 source"] --> Guard["Exact staging project, club account,\nHosting-only scope, short-lived token"] + Guard --> Artifact["Bounded Enterprise public key\nmust appear in built JavaScript"] + Artifact -. "Source proof only" .-> Pending["Provider registration, Hosting release,\nand enforcement still pending"] + Broad["Branch deploy, broad scope, debug token,\nbilling, production, or real data"] --> Stop["Stop"] +``` + +Text alternative: exact merged source may prepare only the staging Hosting site with the club account and a bounded Enterprise public key; source proof stops before provider registration, publication, or enforcement, and every broad, debug, billing, production, or real-data path stops. + +1. Open issue [#676](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/676) and its source pull request. +2. Confirm the source merge and all five exact-main CI jobs are recorded before any provider work. +3. Confirm the guard names only `run-mprc-staging`, `runmprc@gmail.com`, Hosting scope, and Firebase CLI 15.24.0. +4. Confirm tests reject another project/account, broad scope, credential files, appended arguments, placeholders, malformed keys, and a built artifact without the selected key. +5. Confirm local/test and ordinary credential-free preview builds remain unchanged. +6. Confirm the evidence still says key creation, app registration, Hosting publication, Authentication/Firestore enforcement, browser token behavior, Functions, billing, and production are separate states. +7. Record the issue, pull request, exact merge, CI run, approver, and check date. Do not paste a key, provider locator, token, account response, or private screenshot. + +**Expected result:** a backup officer can distinguish a reviewed staging deploy guard from a configured or protected staging service. Nothing becomes live merely because source merged. + +**Stop conditions:** stop if the source or evidence names another account/project, permits more than Hosting, asks for a credential/debug token, treats a public key as secret evidence, links billing, changes production, uses real data, or claims provider/live behavior from source or CI alone. + +**Success proof:** keep the #676 source PR, exact merge, exact-main CI link, source-test summary, named approver, check date, and explicit list of provider/live states still pending. + +**Undo:** before provider work there is nothing live to roll back. If the source guard is wrong, open one reviewed pull request to restore the last known-good exact contract. Do not edit provider settings or delete the staging project. + +**Escalation:** platform owner first, security owner second. Use the private incident path for credential-shaped output or an unexpected provider, account, project, deployment, billing, user, or record change. + ## Before a protected release — NOT AVAILABLE YET Do not use this section until #133 records that both GitHub environments are protected and tested. diff --git a/docs/officers/README.md b/docs/officers/README.md index 58ca79b..46493c4 100644 --- a/docs/officers/README.md +++ b/docs/officers/README.md @@ -69,7 +69,7 @@ WEB-002D [#659](https://github.com/Run-MPRC/Run-MPRC.github.io/issues/659) compl The general protected GitHub release is still **NOT AVAILABLE YET**. #667 configures only a separate staging read-only identity check: Dave Liu or Jeff Chang reviews exact `main`, and a keyless five-minute identity may read only the staging project identity. It cannot deploy Firebase or publish a website. #133 still owns backend deployment roles and production protection. Missing authority stops the release with a red failure before Firebase or website publication. -The empty staging Firestore boundary is available after #669. Project `run-mprc-staging` has a delete-protected empty database with the exact reviewed Rules and indexes. Fixed signed-out requests to server-only paths were denied, and the final root collection count was zero. #671 deploys and verifies password-required email/password Auth from exact merged source. Improved email privacy is on; only the two staging domains are authorized; every other provider is absent; billing is disabled; disposable API/browser checks passed; and cleanup returned Auth and Firestore to zero users/records. #674 adds a code guard for a future deployment of only the two profile Functions. It is not a deployment: billing remains disabled, the club account currently sees no open billing account, and no Function or App Check policy is live. This is not a usable member backend: Functions, App Check, provider sandboxes, reusable deployment authority, role/private-data proof, and officer operation remain **NOT AVAILABLE YET**. Officers do not sign in, enter records, run commands, edit the database, deploy Auth, or attach billing. Use the no-terminal [staging Firestore review](./PUBLISH_AND_CHECK.md#review-the-empty-staging-firestore-boundary--available-after-669) and [staging Auth review](./PUBLISH_AND_CHECK.md#review-the-staging-auth-boundary--available-after-671). +The empty staging Firestore boundary is available after #669. Project `run-mprc-staging` has a delete-protected empty database with the exact reviewed Rules and indexes. Fixed signed-out requests to server-only paths were denied, and the final root collection count was zero. #671 deploys and verifies password-required email/password Auth from exact merged source. Improved email privacy is on; only the two staging domains are authorized; every other provider is absent; billing is disabled; disposable API/browser checks passed; and cleanup returned Auth and Firestore to zero users/records. #674 adds a code guard for a future deployment of only the two profile Functions. #676 adds a separate code guard for a staging Hosting-only release that requires the exact club account/project and an Enterprise public site key in the built artifact. Neither guard is provider or deployment evidence: billing remains disabled, the club account currently sees no open billing account, and no Function or live App Check policy is proved by source. This is not a usable member backend: Functions, live App Check, provider sandboxes, reusable deployment authority, role/private-data proof, and officer operation remain **NOT AVAILABLE YET**. Officers do not sign in, enter records, run commands, edit the database, deploy Auth/Hosting, configure App Check, or attach billing. Use the no-terminal [staging Firestore review](./PUBLISH_AND_CHECK.md#review-the-empty-staging-firestore-boundary--available-after-669), [staging Auth review](./PUBLISH_AND_CHECK.md#review-the-staging-auth-boundary--available-after-671), and source-only [App Check guard review](./PUBLISH_AND_CHECK.md#review-the-staging-app-check-guard--source-only-not-live). GitHub Pages currently still claims `runmprc.com`, so its normal address redirects to the Netlify-served name. The source stops adding that claim, but #136/WEB-001 must publish and verify the provider setting before officers call Pages an independent copy. diff --git a/docs/officers/SYSTEM_MAPS.md b/docs/officers/SYSTEM_MAPS.md index c16a639..b42e406 100644 --- a/docs/officers/SYSTEM_MAPS.md +++ b/docs/officers/SYSTEM_MAPS.md @@ -91,6 +91,8 @@ flowchart TD Main --> AuthSource["#671 exact-main email/password Auth source"] AuthSource --> StagingAuth["Staging Auth-only deploy\nprovider readback"] StagingAuth --> AuthProof["Disposable API + browser sign-in\ncleanup to zero users"] + Main --> AppCheckGuard["#676 staging Hosting/App Check\nsource guard"] + AppCheckGuard -. "Provider registration, publication, and enforcement not proved by source" .-> Stop AuthProof -. "No Functions, App Check, real identity, or records" .-> Stop StagingHosting -. "No complete backend/provider test estate, protected deploy authority, marker, or rollback" .-> Stop HostingSource -. "Production branch, headers, authority, and cutover missing" .-> FutureHosting["Production Firebase Hosting — NOT AVAILABLE YET"] @@ -102,7 +104,7 @@ flowchart TD Dev["dev — legacy branch"] -. "do not use for new release work" .-> PR ``` -In words: merge, release request, and protected approval are separate; #663 supplies build checks, #665 publishes the club-owned engineering staging site, and #671 deploys only narrow email/password Auth after exact-main review. Provider and browser proof used disposable identities and returned the project to zero users/records. It does not supply Functions, App Check, real identity or private-data testing, production release, or reusable authority. Ordinary merges cannot publish Netlify and the completed #659 exception is inactive; its deploy `6a7ece87c5ca4d0007c1a3fc` remains live while completed #623 deploy `6a7e072f8f346b0008510d29` is the immediate rollback and completed #473 deploy `6a6dc9ea588b0c0008036312` is older history; the future Pages branch must stop claiming the Netlify domain, and every host still needs separate proof. +In words: merge, release request, and protected approval are separate; #663 supplies build checks, #665 publishes the club-owned engineering staging site, and #671 deploys only narrow email/password Auth after exact-main review. Provider and browser proof used disposable identities and returned the project to zero users/records. #676 adds only the exact staging Hosting/App Check source guard; its merge cannot prove a provider key, publication, enforcement, or token behavior. The current boundary does not supply Functions, live App Check, real identity or private-data testing, production release, or reusable authority. Ordinary merges cannot publish Netlify and the completed #659 exception is inactive; its deploy `6a7ece87c5ca4d0007c1a3fc` remains live while completed #623 deploy `6a7e072f8f346b0008510d29` is the immediate rollback and completed #473 deploy `6a6dc9ea588b0c0008036312` is older history; the future Pages branch must stop claiming the Netlify domain, and every host still needs separate proof. ## Account and permission ownership diff --git a/package.json b/package.json index b955da8..176c3df 100644 --- a/package.json +++ b/package.json @@ -43,6 +43,8 @@ "deploy:staging-auth": "npx --no-install firebase deploy --only auth --project run-mprc-staging --non-interactive", "predeploy:staging-profile-functions": "node scripts/firebase-profile-functions-staging-contract.js validate-deploy", "deploy:staging-profile-functions": "node scripts/firebase-profile-functions-staging-contract.js deploy", + "predeploy:staging-hosting": "node scripts/firebase-hosting-staging-contract.js validate-deploy", + "deploy:staging-hosting": "node scripts/firebase-hosting-staging-contract.js deploy", "eject": "react-scripts eject", "lint:all": "find . -name '*.{js,jsx,tsx,ts}' -exec pretty-quick {} + && eslint --fix ." }, diff --git a/scripts/firebase-hosting-contract.js b/scripts/firebase-hosting-contract.js index b039add..c69af94 100644 --- a/scripts/firebase-hosting-contract.js +++ b/scripts/firebase-hosting-contract.js @@ -27,6 +27,11 @@ const STAGING_FIELDS = Object.freeze([ 'REACT_APP_FIREBASE_MESSAGING_SENDER_ID', 'REACT_APP_FIREBASE_APP_ID', ]); +const APP_CHECK_SITE_KEY_FIELD = 'REACT_APP_RECAPTCHA_SITE_KEY'; +const APP_CHECK_SITE_KEY_PATTERN = /^[A-Za-z0-9_-]{30,128}$/u; +const APP_CHECK_PLACEHOLDER_PATTERN = ( + /(?:dummy|example|placeholder|public[-_]?site|replace|synthetic|test[-_]?key)/iu +); const MAX_EXECUTABLE_FILES = 10000; const MAX_EXECUTABLE_BYTES = 32 * 1024 * 1024; const MAX_TOTAL_EXECUTABLE_BYTES = 128 * 1024 * 1024; @@ -50,6 +55,14 @@ function includesProductionIdentity(value) { return PRODUCTION_IDENTIFIERS.some((identity) => value.includes(identity)); } +function validateStagingAppCheckSiteKey(environment) { + const siteKey = requiredValue(environment, APP_CHECK_SITE_KEY_FIELD); + if (!APP_CHECK_SITE_KEY_PATTERN.test(siteKey) + || APP_CHECK_PLACEHOLDER_PATTERN.test(siteKey) + || includesProductionIdentity(siteKey)) reject(); + return siteKey; +} + function validateStagingConfiguration(environment) { const values = Object.fromEntries( STAGING_FIELDS.map((key) => [key, requiredValue(environment, key)]), @@ -103,6 +116,9 @@ function validateDeployEnvironment(environment = process.env) { if (requiredValue(environment, 'GCLOUD_PROJECT') !== selected.projectId) { reject(); } + if (selected.environment === 'staging') { + validateStagingAppCheckSiteKey(environment); + } return selected; } @@ -146,6 +162,9 @@ function verifyExecutableArtifact(directory, environment = process.env) { ...(environment.REACT_APP_FIREBASE_MEASUREMENT_ID === undefined ? [] : [requiredValue(environment, 'REACT_APP_FIREBASE_MEASUREMENT_ID')]), + ...(environment[APP_CHECK_SITE_KEY_FIELD] === undefined + ? [] + : [requiredValue(environment, APP_CHECK_SITE_KEY_FIELD)]), ]; const foundIdentifiers = new Set(); let totalBytes = 0; diff --git a/scripts/firebase-hosting-staging-contract.js b/scripts/firebase-hosting-staging-contract.js new file mode 100644 index 0000000..6757466 --- /dev/null +++ b/scripts/firebase-hosting-staging-contract.js @@ -0,0 +1,221 @@ +'use strict'; + +const { spawnSync } = require('node:child_process'); +const fs = require('node:fs'); +const path = require('node:path'); + +const { + validateDeployEnvironment: validateHostingDeployEnvironment, +} = require('./firebase-hosting-contract'); + +const REJECTION = 'firebase_hosting_staging_contract_rejected'; +const DEFAULT_PROJECT_ID = 'demo-mprc-local'; +const STAGING_PROJECT_ID = 'run-mprc-staging'; +const CLUB_ACCOUNT = 'runmprc@gmail.com'; +const DEPLOY_SCOPE = 'hosting'; +const FIREBASE_CLI_VERSION = '15.24.0'; +const TEST_SCRIPT = 'node --test tests/firebase-hosting-foundation.test.js'; +const PREDEPLOY_SCRIPT = 'node scripts/firebase-hosting-staging-contract.js validate-deploy'; +const DEPLOY_SCRIPT = 'node scripts/firebase-hosting-staging-contract.js deploy'; + +function reject() { + throw new Error(REJECTION); +} + +function isPlainObject(value) { + return value !== null + && typeof value === 'object' + && !Array.isArray(value) + && Object.getPrototypeOf(value) === Object.prototype; +} + +function hasExactKeys(value, expected) { + return isPlainObject(value) + && JSON.stringify(Object.keys(value).sort()) + === JSON.stringify([...expected].sort()); +} + +function hasExactArray(value, expected) { + return Array.isArray(value) + && JSON.stringify(value) === JSON.stringify(expected); +} + +function requiredValue(environment, key) { + const value = environment?.[key]; + if (typeof value !== 'string' + || value.length === 0 + || value.length > 8192 + || value.trim() !== value) { + reject(); + } + return value; +} + +function validateSourceContract({ + firebaseConfig, + aliases, + packageJson, + packageLock, +}) { + if (!isPlainObject(firebaseConfig) + || !hasExactKeys( + firebaseConfig.hosting, + ['public', 'predeploy', 'ignore', 'rewrites'], + ) + || firebaseConfig.hosting.public !== 'build' + || !hasExactArray(firebaseConfig.hosting.predeploy, [ + 'node scripts/firebase-hosting-contract.js validate-deploy', + 'npm run build', + 'node scripts/firebase-hosting-contract.js verify build', + ]) + || !hasExactArray(firebaseConfig.hosting.ignore, [ + 'firebase.json', + '**/.*', + '**/node_modules/**', + ]) + || !hasExactArray(firebaseConfig.hosting.rewrites, [{ + source: '**', + destination: '/index.html', + }]) + || !hasExactKeys(aliases, ['projects']) + || !hasExactKeys(aliases.projects, ['default']) + || aliases.projects.default !== DEFAULT_PROJECT_ID + || packageJson?.scripts?.['test:firebase-hosting'] !== TEST_SCRIPT + || packageJson?.scripts?.['predeploy:staging-hosting'] !== PREDEPLOY_SCRIPT + || packageJson?.scripts?.['deploy:staging-hosting'] !== DEPLOY_SCRIPT + || packageJson?.devDependencies?.['firebase-tools'] !== FIREBASE_CLI_VERSION + || packageLock?.packages?.['']?.devDependencies?.['firebase-tools'] + !== FIREBASE_CLI_VERSION + || packageLock?.packages?.['node_modules/firebase-tools']?.version + !== FIREBASE_CLI_VERSION) { + reject(); + } + + return Object.freeze({ + account: CLUB_ACCOUNT, + cliVersion: FIREBASE_CLI_VERSION, + defaultProject: DEFAULT_PROJECT_ID, + projectId: STAGING_PROJECT_ID, + scope: DEPLOY_SCOPE, + }); +} + +function validateDeployEnvironment(environment = process.env) { + let selected; + try { + selected = validateHostingDeployEnvironment(environment); + } catch { + return reject(); + } + if (selected.environment !== 'staging' + || selected.projectId !== STAGING_PROJECT_ID + || requiredValue(environment, 'GOOGLE_CLOUD_QUOTA_PROJECT') + !== STAGING_PROJECT_ID + || requiredValue(environment, 'FIREBASE_DEPLOY_SCOPE') !== DEPLOY_SCOPE + || requiredValue(environment, 'RUN_MPRC_FIREBASE_ACCOUNT') !== CLUB_ACCOUNT + || requiredValue(environment, 'FIREBASE_TOKEN').length < 16 + || (environment.GOOGLE_APPLICATION_CREDENTIALS !== undefined + && environment.GOOGLE_APPLICATION_CREDENTIALS !== '') + || (environment.GOOGLE_GHA_CREDS_PATH !== undefined + && environment.GOOGLE_GHA_CREDS_PATH !== '') + || (environment.CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE !== undefined + && environment.CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE !== '') + || (environment.FIREBASE_SERVICE_ACCOUNT !== undefined + && environment.FIREBASE_SERVICE_ACCOUNT !== '')) { + reject(); + } + + return Object.freeze({ + account: CLUB_ACCOUNT, + projectId: STAGING_PROJECT_ID, + scope: DEPLOY_SCOPE, + }); +} + +function readJson(root, relativePath) { + try { + return JSON.parse(fs.readFileSync(path.join(root, relativePath), 'utf8')); + } catch { + return reject(); + } +} + +function validateRepository(root = path.resolve(__dirname, '..')) { + return validateSourceContract({ + firebaseConfig: readJson(root, 'firebase.json'), + aliases: readJson(root, '.firebaserc'), + packageJson: readJson(root, 'package.json'), + packageLock: readJson(root, 'package-lock.json'), + }); +} + +function firebaseDeployArguments() { + return Object.freeze([ + '--no-install', + 'firebase', + 'deploy', + '--only', + DEPLOY_SCOPE, + '--project', + STAGING_PROJECT_ID, + '--non-interactive', + ]); +} + +function deploy(environment = process.env, spawn = spawnSync) { + validateRepository(); + validateDeployEnvironment(environment); + + const executable = process.platform === 'win32' ? 'npx.cmd' : 'npx'; + const version = spawn( + executable, + ['--no-install', 'firebase', '--version'], + { encoding: 'utf8', env: environment }, + ); + if (version.error + || version.status !== 0 + || version.stdout.trim() !== FIREBASE_CLI_VERSION) { + reject(); + } + + const result = spawn(executable, firebaseDeployArguments(), { + env: environment, + stdio: 'inherit', + }); + if (result.error || !Number.isInteger(result.status)) return 1; + return result.status; +} + +function runCli(args = process.argv.slice(2)) { + if (args.length === 1 && args[0] === 'validate') { + validateRepository(); + process.stdout.write('firebase_hosting_staging_contract_valid\n'); + return 0; + } + if (args.length === 1 && args[0] === 'validate-deploy') { + validateRepository(); + validateDeployEnvironment(); + process.stdout.write('firebase_hosting_staging_deploy_contract_valid\n'); + return 0; + } + if (args.length === 1 && args[0] === 'deploy') return deploy(); + return reject(); +} + +if (require.main === module) { + try { + process.exitCode = runCli(); + } catch { + process.stderr.write(`${REJECTION}\n`); + process.exitCode = 1; + } +} + +module.exports = { + DEPLOY_SCOPE, + FIREBASE_CLI_VERSION, + deploy, + firebaseDeployArguments, + validateDeployEnvironment, + validateSourceContract, +}; diff --git a/tests/firebase-hosting-foundation.test.js b/tests/firebase-hosting-foundation.test.js index 1eb28ad..02a1985 100644 --- a/tests/firebase-hosting-foundation.test.js +++ b/tests/firebase-hosting-foundation.test.js @@ -7,6 +7,13 @@ const path = require('node:path'); const test = require('node:test'); const ROOT = path.resolve(__dirname, '..'); +const STAGING_CONTRACT_PATH = path.join( + ROOT, + 'scripts/firebase-hosting-staging-contract.js', +); +const STAGING_APP_CHECK_SITE_KEY = ( + '6LcA1B2C3D4E5F6G7H8J9K0M1N2P3Q4R5S6T7U8' +); const PRODUCTION_BUILD_ENVIRONMENT = Object.freeze({ REACT_APP_FIREBASE_ENVIRONMENT: 'production', REACT_APP_FIREBASE_API_KEY: 'AIzaSyD2u17HMhDPZ0Tn9D3H71fep1vZgT-njnw', @@ -26,11 +33,54 @@ const STAGING_BUILD_ENVIRONMENT = Object.freeze({ REACT_APP_FIREBASE_MESSAGING_SENDER_ID: '100000000001', REACT_APP_FIREBASE_APP_ID: '1:100000000001:web:abcdef0123456789', }); +const STAGING_DEPLOY_ENVIRONMENT = Object.freeze({ + ...STAGING_BUILD_ENVIRONMENT, + REACT_APP_RECAPTCHA_SITE_KEY: STAGING_APP_CHECK_SITE_KEY, + GCLOUD_PROJECT: 'mprc-staging-ci', +}); +const EXACT_STAGING_DEPLOY_ENVIRONMENT = Object.freeze({ + ...STAGING_BUILD_ENVIRONMENT, + REACT_APP_FIREBASE_API_KEY: 'synthetic-staging-api-key-1234567890', + REACT_APP_FIREBASE_AUTH_DOMAIN: 'run-mprc-staging.firebaseapp.com', + REACT_APP_FIREBASE_PROJECT_ID: 'run-mprc-staging', + REACT_APP_FIREBASE_STORAGE_BUCKET: 'run-mprc-staging.firebasestorage.app', + REACT_APP_FIREBASE_MESSAGING_SENDER_ID: '100000000002', + REACT_APP_FIREBASE_APP_ID: '1:100000000002:web:abcdef0123456789', + REACT_APP_RECAPTCHA_SITE_KEY: STAGING_APP_CHECK_SITE_KEY, + GCLOUD_PROJECT: 'run-mprc-staging', + GOOGLE_CLOUD_QUOTA_PROJECT: 'run-mprc-staging', + FIREBASE_DEPLOY_SCOPE: 'hosting', + RUN_MPRC_FIREBASE_ACCOUNT: 'runmprc@gmail.com', + FIREBASE_TOKEN: 'synthetic-short-lived-credential', +}); function read(relativePath) { return fs.readFileSync(path.join(ROOT, relativePath), 'utf8'); } +function readJson(relativePath) { + return JSON.parse(read(relativePath)); +} + +function clone(value) { + return JSON.parse(JSON.stringify(value)); +} + +function loadStagingContract() { + // eslint-disable-next-line global-require, import/no-unresolved + return require('../scripts/firebase-hosting-staging-contract'); +} + +function stagingSourceContract(overrides = {}) { + return { + firebaseConfig: readJson('firebase.json'), + aliases: readJson('.firebaserc'), + packageJson: readJson('package.json'), + packageLock: readJson('package-lock.json'), + ...overrides, + }; +} + test('WEB-001A1 keeps an unqualified Firebase CLI target in the local demo namespace', () => { const aliases = JSON.parse(read('.firebaserc')); @@ -165,15 +215,14 @@ test('WEB-001A1 binds a Hosting deploy to the selected Firebase project', () => const contract = require('../scripts/firebase-hosting-contract'); assert.deepEqual(contract.validateDeployEnvironment({ - ...STAGING_BUILD_ENVIRONMENT, - GCLOUD_PROJECT: 'mprc-staging-ci', + ...STAGING_DEPLOY_ENVIRONMENT, }), { environment: 'staging', projectId: 'mprc-staging-ci', }); assert.throws( () => contract.validateDeployEnvironment({ - ...STAGING_BUILD_ENVIRONMENT, + ...STAGING_DEPLOY_ENVIRONMENT, GCLOUD_PROJECT: 'mid-peninsula-running-club', }), /firebase_hosting_contract_rejected/u, @@ -184,6 +233,36 @@ test('WEB-001A1 binds a Hosting deploy to the selected Firebase project', () => ); }); +test('CI-001D4 requires a bounded non-placeholder App Check key only for staging deploys', () => { + // eslint-disable-next-line global-require, import/no-unresolved + const contract = require('../scripts/firebase-hosting-contract'); + + assert.deepEqual(contract.validateBuildEnvironment(STAGING_BUILD_ENVIRONMENT), { + environment: 'staging', + projectId: 'mprc-staging-ci', + }); + + const invalidSiteKeys = [ + undefined, + '', + ' public-site-key ', + 'configured-public-site-key', + 'A'.repeat(29), + 'A'.repeat(129), + '6Lc-invalid-site-key-with-asterisk-*', + PRODUCTION_BUILD_ENVIRONMENT.REACT_APP_FIREBASE_API_KEY, + ]; + invalidSiteKeys.forEach((siteKey) => { + assert.throws( + () => contract.validateDeployEnvironment({ + ...STAGING_DEPLOY_ENVIRONMENT, + REACT_APP_RECAPTCHA_SITE_KEY: siteKey, + }), + /firebase_hosting_contract_rejected/u, + ); + }); +}); + test('WEB-001A1 CLI failures are fixed and do not echo supplied configuration', () => { const canary = 'private-build-value-canary'; const result = spawnSync( @@ -239,3 +318,198 @@ test('WEB-001A1 executable staging artifacts prove staging identity and reject p /firebase_hosting_contract_rejected/u, ); }); + +test('CI-001D4 executable staging artifact contains the selected App Check key', (t) => { + // eslint-disable-next-line global-require, import/no-unresolved + const contract = require('../scripts/firebase-hosting-contract'); + const fixture = fs.mkdtempSync(path.join(process.env.TMPDIR || '/tmp', 'mprc-app-check-')); + t.after(() => fs.rmSync(fixture, { force: true, recursive: true })); + fs.mkdirSync(path.join(fixture, 'static', 'js'), { recursive: true }); + + fs.writeFileSync( + path.join(fixture, 'static', 'js', 'main.example.js'), + `const config=${JSON.stringify(STAGING_DEPLOY_ENVIRONMENT)};\n`, + 'utf8', + ); + assert.deepEqual(contract.verifyExecutableArtifact( + fixture, + STAGING_DEPLOY_ENVIRONMENT, + ), { + environment: 'staging', + executableFileCount: 1, + }); + + fs.writeFileSync( + path.join(fixture, 'static', 'js', 'main.example.js'), + `const config=${JSON.stringify(STAGING_BUILD_ENVIRONMENT)};\n`, + 'utf8', + ); + assert.throws( + () => contract.verifyExecutableArtifact(fixture, STAGING_DEPLOY_ENVIRONMENT), + /firebase_hosting_contract_rejected/u, + ); +}); + +test('CI-001D4 accepts only the exact staging Hosting source contract', () => { + const { validateSourceContract } = loadStagingContract(); + + assert.deepEqual(validateSourceContract(stagingSourceContract()), { + account: 'runmprc@gmail.com', + cliVersion: '15.24.0', + defaultProject: 'demo-mprc-local', + projectId: 'run-mprc-staging', + scope: 'hosting', + }); +}); + +test('CI-001D4 rejects changed Hosting scripts, aliases, config, or CLI pin', () => { + const { validateSourceContract } = loadStagingContract(); + const packageJson = readJson('package.json'); + const packageLock = readJson('package-lock.json'); + const firebaseConfig = readJson('firebase.json'); + + const changedScript = clone(packageJson); + changedScript.scripts['deploy:staging-hosting'] = 'firebase deploy --only hosting'; + const changedCli = clone(packageJson); + changedCli.devDependencies['firebase-tools'] = 'latest'; + const changedLock = clone(packageLock); + changedLock.packages['node_modules/firebase-tools'].version = '15.23.0'; + const changedHosting = clone(firebaseConfig); + changedHosting.hosting.predeploy = ['npm run build']; + + [ + stagingSourceContract({ packageJson: changedScript }), + stagingSourceContract({ packageJson: changedCli }), + stagingSourceContract({ packageLock: changedLock }), + stagingSourceContract({ firebaseConfig: changedHosting }), + stagingSourceContract({ aliases: { projects: { default: 'run-mprc-staging' } } }), + ].forEach((invalid) => { + assert.throws( + () => validateSourceContract(invalid), + /firebase_hosting_staging_contract_rejected/u, + ); + }); +}); + +test('CI-001D4 deploy context is exact, Hosting-only, and token-bound', () => { + const { validateDeployEnvironment } = loadStagingContract(); + + assert.deepEqual(validateDeployEnvironment(EXACT_STAGING_DEPLOY_ENVIRONMENT), { + account: 'runmprc@gmail.com', + projectId: 'run-mprc-staging', + scope: 'hosting', + }); + + const invalidEnvironments = [ + { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, GCLOUD_PROJECT: 'mid-peninsula-running-club' }, + { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, GOOGLE_CLOUD_QUOTA_PROJECT: 'another-project' }, + { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, FIREBASE_DEPLOY_SCOPE: 'hosting,auth' }, + { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, FIREBASE_DEPLOY_SCOPE: 'functions' }, + { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, RUN_MPRC_FIREBASE_ACCOUNT: 'another@example.invalid' }, + { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, FIREBASE_TOKEN: '' }, + { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, REACT_APP_FIREBASE_PROJECT_ID: 'mprc-staging-ci' }, + { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, REACT_APP_RECAPTCHA_SITE_KEY: 'public-site-key' }, + { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, GOOGLE_APPLICATION_CREDENTIALS: '/tmp/credential.json' }, + { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, GOOGLE_GHA_CREDS_PATH: '/tmp/github-credential.json' }, + { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE: '/tmp/gcloud-credential.json' }, + { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, FIREBASE_SERVICE_ACCOUNT: '{}' }, + ]; + invalidEnvironments.forEach((invalid) => { + assert.throws( + () => validateDeployEnvironment(invalid), + /firebase_hosting_staging_contract_rejected/u, + ); + }); +}); + +test('CI-001D4 pins an argument-closed Hosting deploy command', () => { + const { + DEPLOY_SCOPE, + FIREBASE_CLI_VERSION, + firebaseDeployArguments, + } = loadStagingContract(); + const packageJson = readJson('package.json'); + + assert.equal(DEPLOY_SCOPE, 'hosting'); + assert.equal(FIREBASE_CLI_VERSION, '15.24.0'); + assert.deepEqual(firebaseDeployArguments(), [ + '--no-install', + 'firebase', + 'deploy', + '--only', + 'hosting', + '--project', + 'run-mprc-staging', + '--non-interactive', + ]); + assert.equal( + packageJson.scripts['predeploy:staging-hosting'], + 'node scripts/firebase-hosting-staging-contract.js validate-deploy', + ); + assert.equal( + packageJson.scripts['deploy:staging-hosting'], + 'node scripts/firebase-hosting-staging-contract.js deploy', + ); +}); + +test('CI-001D4 checks the lockfile CLI before exact Hosting deployment', () => { + const { deploy, firebaseDeployArguments } = loadStagingContract(); + const calls = []; + const fakeSpawn = (executable, args, options) => { + calls.push({ executable, args, stdio: options.stdio }); + if (args.includes('--version')) return { status: 0, stdout: '15.24.0\n' }; + return { status: 0 }; + }; + + assert.equal(deploy(EXACT_STAGING_DEPLOY_ENVIRONMENT, fakeSpawn), 0); + assert.deepEqual(calls.map(({ args }) => args), [ + ['--no-install', 'firebase', '--version'], + firebaseDeployArguments(), + ]); + assert.equal(calls[0].stdio, undefined); + assert.equal(calls[1].stdio, 'inherit'); + assert.throws( + () => deploy(EXACT_STAGING_DEPLOY_ENVIRONMENT, () => ({ + status: 0, + stdout: '99.0.0\n', + })), + /firebase_hosting_staging_contract_rejected/u, + ); +}); + +test('CI-001D4 CLI failures are fixed and reject appended arguments', () => { + const canary = 'private-hosting-context-canary'; + const invalidContext = spawnSync( + process.execPath, + [STAGING_CONTRACT_PATH, 'validate-deploy'], + { + cwd: ROOT, + encoding: 'utf8', + env: { + ...process.env, + ...EXACT_STAGING_DEPLOY_ENVIRONMENT, + GCLOUD_PROJECT: canary, + FIREBASE_TOKEN: canary, + }, + }, + ); + const unexpectedArgument = spawnSync( + process.execPath, + [STAGING_CONTRACT_PATH, 'deploy', '--only', 'functions'], + { + cwd: ROOT, + encoding: 'utf8', + env: { ...process.env, ...EXACT_STAGING_DEPLOY_ENVIRONMENT }, + }, + ); + + [invalidContext, unexpectedArgument].forEach((result) => { + assert.equal(result.status, 1); + assert.equal(result.stdout, ''); + assert.equal( + result.stderr, + 'firebase_hosting_staging_contract_rejected\n', + ); + assert.doesNotMatch(`${result.stdout}${result.stderr}`, new RegExp(canary, 'u')); + }); +}); From 0195402c86c685ae0ce44ce180c0b70a70a9ef77 Mon Sep 17 00:00:00 2001 From: Dave Liu <7david12liu@gmail.com> Date: Wed, 26 Aug 2026 15:02:07 -0700 Subject: [PATCH 2/2] Test staging guard rejects production context --- tests/firebase-hosting-foundation.test.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/firebase-hosting-foundation.test.js b/tests/firebase-hosting-foundation.test.js index 02a1985..171c031 100644 --- a/tests/firebase-hosting-foundation.test.js +++ b/tests/firebase-hosting-foundation.test.js @@ -401,6 +401,14 @@ test('CI-001D4 deploy context is exact, Hosting-only, and token-bound', () => { }); const invalidEnvironments = [ + { + ...PRODUCTION_BUILD_ENVIRONMENT, + GCLOUD_PROJECT: 'mid-peninsula-running-club', + GOOGLE_CLOUD_QUOTA_PROJECT: 'mid-peninsula-running-club', + FIREBASE_DEPLOY_SCOPE: 'hosting', + RUN_MPRC_FIREBASE_ACCOUNT: 'runmprc@gmail.com', + FIREBASE_TOKEN: 'synthetic-short-lived-credential', + }, { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, GCLOUD_PROJECT: 'mid-peninsula-running-club' }, { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, GOOGLE_CLOUD_QUOTA_PROJECT: 'another-project' }, { ...EXACT_STAGING_DEPLOY_ENVIRONMENT, FIREBASE_DEPLOY_SCOPE: 'hosting,auth' },