From 8a5007427a5fa27ffba2b5ef63be415733708d88 Mon Sep 17 00:00:00 2001 From: Mohit Raj <166033762+Mohit0628@users.noreply.github.com> Date: Fri, 16 Oct 2026 01:34:55 +0530 Subject: [PATCH 1/2] fix(trade): label GMX fallback candles as "GMX Oracle Reference" fetchOracleCandles falls back to the GMX API (ENV.ORACLE_URL) but labelled the series "SO4 Oracle Reference". With the third-party SO4 oracle worker removed, that label misattributes third-party GMX (Arbitrum) prices to SO4. Rename all three GMX-path return sites (aborted early-return, success return, catch fallback) to "GMX Oracle Reference". Refs #830 --- .changelog/unreleased/830-gmx-oracle-label.md | 8 ++++++++ apps/web/src/features/trade/lib/oracle.ts | 6 +++--- 2 files changed, 11 insertions(+), 3 deletions(-) create mode 100644 .changelog/unreleased/830-gmx-oracle-label.md diff --git a/.changelog/unreleased/830-gmx-oracle-label.md b/.changelog/unreleased/830-gmx-oracle-label.md new file mode 100644 index 00000000..f090a052 --- /dev/null +++ b/.changelog/unreleased/830-gmx-oracle-label.md @@ -0,0 +1,8 @@ +--- +type: fixed +area: trade +pr: 830 +breaking: false +--- + +The candle chart now labels third-party GMX (Arbitrum) reference prices as "GMX Oracle Reference" instead of the misleading "SO4 Oracle Reference". diff --git a/apps/web/src/features/trade/lib/oracle.ts b/apps/web/src/features/trade/lib/oracle.ts index 5a1985a8..518f48b1 100644 --- a/apps/web/src/features/trade/lib/oracle.ts +++ b/apps/web/src/features/trade/lib/oracle.ts @@ -393,7 +393,7 @@ export async function fetchOracleCandles( const res = await fetch(`${GMX_BASE}/prices/candles?${params}`, { signal }) if (!res.ok) throw new Error(`HTTP ${res.status}`) const json = (await res.json()) as { candles: Array> } - if (signal?.aborted) return emptyResponse("SO4 Oracle Reference") + if (signal?.aborted) return emptyResponse("GMX Oracle Reference") const rawBars: Array = json.candles .map(([time, open, high, low, close]) => ({ time, open, high, low, close })) @@ -402,13 +402,13 @@ export async function fetchOracleCandles( return { candles: validateAndSortCandles(rawBars), sourceType: "oracle_reference", - venueName: "SO4 Oracle Reference", + venueName: "GMX Oracle Reference", symbol: base, period, network: ENV.NETWORK, } } catch { - return emptyResponse("SO4 Oracle Reference") + return emptyResponse("GMX Oracle Reference") } } From 28efd34f330696829ffe3c6be676884230bf9caa Mon Sep 17 00:00:00 2001 From: Mohit Raj <166033762+Mohit0628@users.noreply.github.com> Date: Fri, 16 Oct 2026 01:37:42 +0530 Subject: [PATCH 2/2] chore(trade): name changelog entry after PR 978 Follow the changelog convention of using the pull request number in the filename and frontmatter (was the issue number 830). --- .../{830-gmx-oracle-label.md => 978-gmx-oracle-label.md} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename .changelog/unreleased/{830-gmx-oracle-label.md => 978-gmx-oracle-label.md} (96%) diff --git a/.changelog/unreleased/830-gmx-oracle-label.md b/.changelog/unreleased/978-gmx-oracle-label.md similarity index 96% rename from .changelog/unreleased/830-gmx-oracle-label.md rename to .changelog/unreleased/978-gmx-oracle-label.md index f090a052..8ea3aab3 100644 --- a/.changelog/unreleased/830-gmx-oracle-label.md +++ b/.changelog/unreleased/978-gmx-oracle-label.md @@ -1,7 +1,7 @@ --- type: fixed area: trade -pr: 830 +pr: 978 breaking: false ---