Skip to content

Commit bcc28ea

Browse files
authored
Merge pull request #21 from Sekers/feature/live-testing-rule
Allow live Graph testing in any tenant, reaching only your own accounts
2 parents 08d540d + f4a0f05 commit bcc28ea

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

‎.github/pull_request_template.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@
1717
- [ ] `CHANGELOG.md` has an entry in the right section under `[Unreleased]` (added if missing), or the change is not user-visible
1818
- [ ] `.\Tests\Invoke-Tests.ps1` passes
1919
- [ ] Contains no real tenant names, email domains, secrets, or configuration files
20-
- [ ] Any live Microsoft Graph testing was done in a test tenant and is described above
20+
- [ ] Any live Microsoft Graph testing is described above, and sent messages and files only to accounts you control

‎CONTRIBUTING.md‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,9 @@ Thank you for helping improve ScriptMessage. This guide covers the everyday work
2626
- **Never commit a real configuration file, secret, or certificate.** Never name a real organization, tenant, or
2727
email domain in code, tests, examples, or commit messages; use an RFC 2606 reserved domain instead, such as
2828
`example.com`. Those can never be registered, so a placeholder that gets run unedited reaches nobody.
29-
- **The automated tests never connect to a tenant.** If a change needs a live Microsoft Graph test, run it in
30-
your own test tenant and describe what you tested in the pull request.
29+
- **The automated tests never connect to a tenant.** If a change needs a live Microsoft Graph test, you don't need
30+
a test tenant: any tenant you're allowed to test in will do, as long as every message and file you send goes
31+
only to accounts you control. Describe what you tested in the pull request.
3132
- **Text files are UTF-8 with LF line endings and no byte order mark, and PowerShell files contain only ASCII.**
3233
Windows PowerShell 5.1 misreads non-ASCII characters in PowerShell files saved without a byte order mark.
3334
`.gitattributes` handles line endings, the test suite checks all three rules, and [AGENTS.md](./AGENTS.md)

‎RELEASING.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,5 +215,5 @@ enforceable:
215215
- [ ] The wiki (`Sekers/ScriptMessage.wiki`) describes this release, and its update was pushed after the Release
216216
workflow passed.
217217
- [ ] `main` was merged back into `develop` with a merge commit.
218-
- [ ] Anything that needs a live Microsoft Graph test was tested separately in a test tenant. The automated tests
219-
never connect to a tenant.
218+
- [ ] Anything that needs a live Microsoft Graph test was tested separately, sending messages and files only to
219+
accounts the tester controls. The automated tests never connect to a tenant.

0 commit comments

Comments
 (0)