Skip to content
This repository was archived by the owner on Jul 31, 2026. It is now read-only.

Commit ea680cb

Browse files
ci: replace the dead live smoke test with the unit tests, fix CODEOWNERS (#39)
The GitHub Actions Test job ran the action for real against secrets.LOGGIA_*, and the API now answers "Batch test run not found": the suite and environment those secrets point at belong to Shiplight Cloud v1 and no longer exist. There is nowhere to repoint it. This action only speaks to the v1 API, and the current platform's CI path does not involve this action at all, so no v2 equivalent exists. Removed the job and enabled the unit tests that were sitting commented out in the same workflow. They pass (3 tests, covering token validation and test-context parsing) and they need no live backend, so CI is green and testing something real rather than red and testing nothing. Also dropped the workflow's permissions from write-all to contents: read, which is all the remaining job needs now that nothing comments on pull requests. CODEOWNERS still carried the actions/typescript-action template default, @actions/actions-oss-maintainers, a team that does not exist in this org, so review requests silently went nowhere. Now @feng-shiplight. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 59d9d8b commit ea680cb

2 files changed

Lines changed: 6 additions & 27 deletions

File tree

.github/workflows/ci.yml

Lines changed: 5 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ on:
99
- main
1010
- master
1111

12-
permissions: write-all
12+
permissions:
13+
contents: read
1314

1415
jobs:
1516
test-typescript:
@@ -40,28 +41,6 @@ jobs:
4041
id: npm-lint
4142
run: npm run lint
4243

43-
# - name: Test
44-
# id: npm-ci-test
45-
# run: npm run ci-test
46-
47-
test-action:
48-
name: GitHub Actions Test
49-
runs-on: ubuntu-latest
50-
51-
steps:
52-
- name: Checkout
53-
id: checkout
54-
uses: actions/checkout@v4
55-
56-
- name: Test Local Action
57-
id: test-action
58-
uses: ./
59-
with:
60-
api-token: ${{ secrets.LOGGIA_API_TOKEN }}
61-
test-suite-id: ${{ secrets.LOGGIA_TEST_SUITE_ID }}
62-
environment-id: ${{ secrets.LOGGIA_ENVIRONMENT_ID }}
63-
environment-url: ${{ secrets.LOGGIA_TEST_SUITE_ENVIRONMENT_URL }}
64-
65-
- name: Print Output
66-
id: output
67-
run: echo "${{ steps.test-action.outputs.time }}"
44+
- name: Test
45+
id: npm-ci-test
46+
run: npm run ci-test

CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
############################################################################
55

66
# Default owners, unless a later match takes precedence.
7-
* @actions/actions-oss-maintainers
7+
* @feng-shiplight

0 commit comments

Comments
 (0)