From c1c183a3dce7ebb2abac6b31237ee4394fc61ed7 Mon Sep 17 00:00:00 2001 From: Wiktor Wisniewski Date: Tue, 17 Nov 2026 16:30:48 +0100 Subject: [PATCH] Fix inventory turnover sales attribution and reconciliation --- .../solution/solve.sh | 8 +- .../tests/test_outputs.py | 16 ++-- tests/test_inventory_turnover_verifier.py | 87 +++++++++++++++++++ 3 files changed, 98 insertions(+), 13 deletions(-) create mode 100644 tests/test_inventory_turnover_verifier.py diff --git a/tasks/dbt-inventory-turnover-analysis/solution/solve.sh b/tasks/dbt-inventory-turnover-analysis/solution/solve.sh index e519fab1..f5bd1b22 100755 --- a/tasks/dbt-inventory-turnover-analysis/solution/solve.sh +++ b/tasks/dbt-inventory-turnover-analysis/solution/solve.sh @@ -137,6 +137,7 @@ WITH ref_date AS ( fulfilled_orders AS ( SELECT o.order_id, + o.warehouse_id, CAST(COALESCE(o.shipped_at, o.delivered_at) AS DATE) AS fulfilled_date FROM {{ o_rel }} o CROSS JOIN ref_date rd @@ -165,7 +166,7 @@ period_bounds AS ( ), windowed_orders AS ( - SELECT fo.order_id, fo.fulfilled_date + SELECT fo.order_id, fo.warehouse_id, fo.fulfilled_date FROM fulfilled_orders fo CROSS JOIN period_bounds pb {% if target.type == 'snowflake' %} @@ -179,14 +180,13 @@ windowed_orders AS ( sales_by_sku_warehouse AS ( SELECT pv.sku, - il.warehouse_id, + wo.warehouse_id, SUM(COALESCE(ol.quantity_ordered, 0)) AS total_units_sold FROM {{ ol_rel }} ol JOIN windowed_orders wo ON ol.order_id = wo.order_id JOIN {{ pv_rel }} pv ON ol.variant_id = pv.variant_id - JOIN {{ inv_rel }} il ON pv.variant_id = il.variant_id WHERE pv.sku IS NOT NULL - AND il.warehouse_id IS NOT NULL + AND wo.warehouse_id IS NOT NULL GROUP BY 1, 2 ), diff --git a/tasks/dbt-inventory-turnover-analysis/tests/test_outputs.py b/tasks/dbt-inventory-turnover-analysis/tests/test_outputs.py index 8eeaf716..85e48355 100644 --- a/tasks/dbt-inventory-turnover-analysis/tests/test_outputs.py +++ b/tasks/dbt-inventory-turnover-analysis/tests/test_outputs.py @@ -371,14 +371,14 @@ def test_turnover_days_supply_relationship(conn): def test_sales_reconciliation_sample(conn): - """For top SKUs by current_quantity_on_hand, total_units_sold matches source aggregation.""" + """Reconcile sales, prioritizing stocked SKUs without skipping zero-stock output.""" c, db_type = conn sample = execute_query(c, db_type, """ SELECT sku, warehouse_id FROM analytics.rpt_inventory_turnover_analysis - WHERE current_quantity_on_hand > 0 GROUP BY sku, warehouse_id - ORDER BY MAX(current_quantity_on_hand) DESC + ORDER BY MAX(current_quantity_on_hand) DESC, + MAX(total_units_sold) DESC, sku, warehouse_id LIMIT 20 """) if not sample: @@ -418,7 +418,7 @@ def test_sales_reconciliation_sample(conn): AND COALESCE(o.shipped_at, o.delivered_at) IS NOT NULL ), windowed_orders AS ( - SELECT o.order_id + SELECT o.order_id, o.warehouse_id FROM main.stg_orders__orders o CROSS JOIN ref_date rd WHERE o.fulfillment_status = 'FULFILLED' @@ -430,9 +430,8 @@ def test_sales_reconciliation_sample(conn): FROM main.stg_orders__order_lines ol JOIN windowed_orders wo ON ol.order_id = wo.order_id JOIN main.stg_product__product_variants pv ON ol.variant_id = pv.variant_id - JOIN main.stg_inventory__inventory_levels il ON pv.variant_id = il.variant_id WHERE pv.sku = %s - AND il.warehouse_id = %s + AND wo.warehouse_id = %s """, [sku, warehouse_id]) else: src_sold = execute_scalar(c, db_type, """ @@ -443,7 +442,7 @@ def test_sales_reconciliation_sample(conn): AND COALESCE(o.shipped_at, o.delivered_at) IS NOT NULL ), windowed_orders AS ( - SELECT o.order_id + SELECT o.order_id, o.warehouse_id FROM main.stg_orders__orders o CROSS JOIN ref_date rd WHERE o.fulfillment_status = 'FULFILLED' @@ -455,9 +454,8 @@ def test_sales_reconciliation_sample(conn): FROM main.stg_orders__order_lines ol JOIN windowed_orders wo ON ol.order_id = wo.order_id JOIN main.stg_product__product_variants pv ON ol.variant_id = pv.variant_id - JOIN main.stg_inventory__inventory_levels il ON pv.variant_id = il.variant_id WHERE pv.sku = ? - AND il.warehouse_id = ? + AND wo.warehouse_id = ? """, [sku, warehouse_id]) # Allow small tolerance for aggregation differences diff --git a/tests/test_inventory_turnover_verifier.py b/tests/test_inventory_turnover_verifier.py new file mode 100644 index 00000000..261a775b --- /dev/null +++ b/tests/test_inventory_turnover_verifier.py @@ -0,0 +1,87 @@ +"""Exercise the real sales verifier against small DuckDB relations. + +Run: python -m pytest tests/test_inventory_turnover_verifier.py -q +Requires pytest and duckdb; no dbt project or external warehouse is needed. +""" +import importlib.util +from pathlib import Path + +import duckdb +import pytest + +TASK = Path(__file__).resolve().parents[1] / 'tasks/dbt-inventory-turnover-analysis' + + +@pytest.fixture +def verifier(monkeypatch): + monkeypatch.setenv('DB_TYPE', 'duckdb') + spec = importlib.util.spec_from_file_location('inventory_verifier', TASK / 'tests/test_outputs.py') + module = importlib.util.module_from_spec(spec) + spec.loader.exec_module(module) + return module + + +@pytest.fixture +def db(): + con = duckdb.connect() + con.execute('CREATE SCHEMA analytics') + con.execute('CREATE TABLE main.stg_orders__orders(order_id VARCHAR, warehouse_id VARCHAR, fulfillment_status VARCHAR, shipped_at TIMESTAMP, delivered_at TIMESTAMP)') + con.execute('CREATE TABLE main.stg_orders__order_lines(order_id VARCHAR, variant_id VARCHAR, quantity_ordered DECIMAL(18,2))') + con.execute('CREATE TABLE main.stg_product__product_variants(variant_id VARCHAR, sku VARCHAR)') + con.execute('CREATE TABLE main.stg_inventory__inventory_levels(variant_id VARCHAR, warehouse_id VARCHAR)') + con.execute('CREATE TABLE analytics.rpt_inventory_turnover_analysis(sku VARCHAR, warehouse_id VARCHAR, total_units_sold DECIMAL(18,2), current_quantity_on_hand INTEGER)') + con.execute("INSERT INTO main.stg_product__product_variants VALUES ('v', 'sku')") + con.execute("INSERT INTO main.stg_orders__orders VALUES ('o', 'A', 'FULFILLED', '2025-01-03', NULL)") + con.execute("INSERT INTO main.stg_orders__order_lines VALUES ('o', 'v', 3)") + yield con + con.close() + + +@pytest.mark.parametrize('snapshots', [0, 1, 2, 5]) +def test_snapshot_count_does_not_change_sales(db, verifier, snapshots): + for _ in range(snapshots): + db.execute("INSERT INTO main.stg_inventory__inventory_levels VALUES ('v', 'A')") + db.execute("INSERT INTO analytics.rpt_inventory_turnover_analysis VALUES ('sku', 'A', 3, 100)") + verifier.test_sales_reconciliation_sample((db, 'duckdb')) + + +def test_sales_are_not_assigned_to_another_inventory_warehouse(db, verifier): + db.execute("INSERT INTO main.stg_inventory__inventory_levels VALUES ('v', 'A'), ('v', 'B')") + db.execute("INSERT INTO analytics.rpt_inventory_turnover_analysis VALUES ('sku', 'A', 3, 100), ('sku', 'B', 0, 99)") + verifier.test_sales_reconciliation_sample((db, 'duckdb')) + + +def test_doubled_sales_are_rejected(db, verifier): + db.execute("INSERT INTO main.stg_inventory__inventory_levels VALUES ('v', 'A'), ('v', 'A')") + db.execute("INSERT INTO analytics.rpt_inventory_turnover_analysis VALUES ('sku', 'A', 6, 100)") + with pytest.raises(AssertionError, match='model=6'): + verifier.test_sales_reconciliation_sample((db, 'duckdb')) + + +def test_zero_sales_are_rejected_when_order_exists(db, verifier): + db.execute("INSERT INTO main.stg_inventory__inventory_levels VALUES ('v', 'A')") + db.execute("INSERT INTO analytics.rpt_inventory_turnover_analysis VALUES ('sku', 'A', 0, 100)") + with pytest.raises(AssertionError, match='model=0'): + verifier.test_sales_reconciliation_sample((db, 'duckdb')) + + +def test_zero_stock_does_not_skip_sales_reconciliation(db, verifier): + db.execute("INSERT INTO main.stg_inventory__inventory_levels VALUES ('v', 'A')") + db.execute("INSERT INTO analytics.rpt_inventory_turnover_analysis VALUES ('sku', 'A', 6, 0)") + with pytest.raises(AssertionError, match='model=6'): + verifier.test_sales_reconciliation_sample((db, 'duckdb')) + + +def test_window_status_and_delivered_fallback(db, verifier): + db.execute("""INSERT INTO main.stg_orders__orders VALUES + ('boundary', 'A', 'FULFILLED', '2024-07-07', NULL), + ('old', 'A', 'FULFILLED', '2024-07-06', NULL), + ('pending', 'A', 'PENDING', '2025-01-02', NULL), + ('missing', 'A', 'FULFILLED', NULL, NULL), + ('delivered', 'A', 'FULFILLED', NULL, '2025-01-02')""") + db.execute("""INSERT INTO main.stg_orders__order_lines VALUES + ('boundary','v',2),('old','v',100),('pending','v',100), + ('missing','v',100),('delivered','v',4)""") + db.execute("INSERT INTO main.stg_inventory__inventory_levels VALUES ('v', 'A')") + db.execute("INSERT INTO analytics.rpt_inventory_turnover_analysis VALUES ('sku', 'A', 9, 100)") + verifier.test_sales_reconciliation_sample((db, 'duckdb'))