@@ -158,7 +163,6 @@
Talk to Von Neumarkt
-
{% if expert_tabs_enabled %}
diff --git a/tests/backend/test_display_elements_service.py b/tests/backend/test_display_elements_service.py
index 57219e104..24df2d8e7 100644
--- a/tests/backend/test_display_elements_service.py
+++ b/tests/backend/test_display_elements_service.py
@@ -137,6 +137,29 @@ def test_extract_markdown_tables_parses_rows_and_typed_cells() -> None:
assert second_row_types == ["text", "boolean", "date", "number"]
+def test_extract_markdown_tables_preserves_source_lines_after_code_fences() -> None:
+ tables = extract_markdown_tables(
+ (
+ "Before\n"
+ "```text\n"
+ "| not | a table |\n"
+ "| --- | --- |\n"
+ "```\n"
+ "Between\n"
+ "| Task | Status |\n"
+ "| --- | --- |\n"
+ "| Alpha | done |\n"
+ "After\n"
+ )
+ )
+
+ assert len(tables) == 1
+ assert tables[0]["source_span"] == {
+ "start_line": 7,
+ "end_line": 9,
+ }
+
+
def test_build_turn_display_elements_includes_table_elements_for_markdown_tables() -> None:
contract = build_turn_display_elements(
response_text=(
@@ -166,6 +189,15 @@ def test_build_turn_display_elements_includes_table_elements_for_markdown_tables
table_element = table_elements[0]
assert table_element["payload"]["columns"][0]["label"] == "Task"
assert table_element["payload"]["rows"][0]["cells"][1]["value_raw"] == "done"
+ assert table_element["presentation"] == {
+ "mode": "inline_primary",
+ "source_element_id": "screen_text",
+ "source_span": {
+ "start_line": 1,
+ "end_line": 4,
+ },
+ }
+ assert table_element["provenance"]["source"] == "screen_markdown_table"
assert "screen_markdown_tables_detected" in contract["reason_codes"]
assert contract["validation"]["valid"] is True
@@ -210,6 +242,8 @@ def test_build_turn_display_elements_includes_supplied_table_elements() -> None:
table_element["payload"]["rows"][0]["provenance"]["source_concept_id"]
== "#V#task_alpha"
)
+ assert table_element["presentation"] == {"mode": "augment"}
+ assert table_element["provenance"]["source"] == "screen_structured_table"
assert "screen_structured_tables_supplied" in contract["reason_codes"]
assert contract["validation"]["valid"] is True
@@ -1328,6 +1362,121 @@ def test_validate_turn_display_elements_rejects_invalid_table_shape() -> None:
assert any("must reference a declared column" in message for message in errors)
+def _table_presentation_validation_contract(
+ *,
+ source_element_id: str = "screen_text",
+ source_element_type: str = "text_block",
+ source_channel: str = "screen",
+ source_text: str = "| Task | Status |\n| --- | --- |\n| Alpha | done |",
+ source_span: dict[str, int] | None = None,
+) -> dict[str, object]:
+ return {
+ "schema_version": "turn_display_elements_v1",
+ "elements": [
+ {
+ "element_id": "screen_text",
+ "element_type": source_element_type,
+ "channel": source_channel,
+ "order": 10,
+ "intent": "primary_response",
+ "payload": {"text": source_text},
+ "provenance": {"source": "response_text"},
+ },
+ {
+ "element_id": "screen_table_1",
+ "element_type": "table",
+ "channel": "screen",
+ "order": 16,
+ "intent": "structured_tabular_view",
+ "payload": {
+ "columns": [
+ {
+ "column_id": "task",
+ "label": "Task",
+ "data_type": "text",
+ }
+ ],
+ "rows": [
+ {
+ "row_id": "row_1",
+ "cells": [
+ {
+ "column_id": "task",
+ "value_raw": "Alpha",
+ "value_display": "Alpha",
+ "value_type": "text",
+ }
+ ],
+ }
+ ],
+ },
+ "presentation": {
+ "mode": "inline_primary",
+ "source_element_id": source_element_id,
+ "source_span": source_span or {
+ "start_line": 1,
+ "end_line": 3,
+ },
+ },
+ "provenance": {"source": "screen_markdown_table"},
+ },
+ ],
+ "reason_codes": [],
+ }
+
+
+def test_validate_turn_display_elements_rejects_reversed_table_presentation_span() -> None:
+ valid, errors = validate_turn_display_elements(
+ _table_presentation_validation_contract(
+ source_span={"start_line": 4, "end_line": 2},
+ )
+ )
+
+ assert valid is False
+ assert any("must not precede start_line" in message for message in errors)
+
+
+def test_validate_turn_display_elements_rejects_missing_table_presentation_source() -> None:
+ valid, errors = validate_turn_display_elements(
+ _table_presentation_validation_contract(source_element_id="missing_text")
+ )
+
+ assert valid is False
+ assert any("must identify exactly one element" in message for message in errors)
+
+
+def test_validate_turn_display_elements_rejects_wrong_table_presentation_source_type() -> None:
+ valid, errors = validate_turn_display_elements(
+ _table_presentation_validation_contract(source_element_type="json_block")
+ )
+
+ assert valid is False
+ assert any("must reference a screen text_block" in message for message in errors)
+
+
+def test_validate_turn_display_elements_rejects_table_presentation_span_outside_source() -> None:
+ valid, errors = validate_turn_display_elements(
+ _table_presentation_validation_contract(
+ source_span={"start_line": 1, "end_line": 4},
+ )
+ )
+
+ assert valid is False
+ assert any("must fall within the referenced text" in message for message in errors)
+
+
+def test_validate_turn_display_elements_rejects_span_without_markdown_table() -> None:
+ valid, errors = validate_turn_display_elements(
+ _table_presentation_validation_contract(
+ source_text="Before\nNot a table\nAfter",
+ source_span={"start_line": 1, "end_line": 3},
+ )
+ )
+
+ assert valid is False
+ assert any("must identify a Markdown table" in message for message in errors)
+
+
def test_validate_turn_display_elements_rejects_invalid_workflow_links() -> None:
valid, errors = validate_turn_display_elements(
{
diff --git a/tests/frontend/chatAttachmentWorkflowInput.test.js b/tests/frontend/chatAttachmentWorkflowInput.test.js
index 1666eb0f6..8cdde17b5 100644
--- a/tests/frontend/chatAttachmentWorkflowInput.test.js
+++ b/tests/frontend/chatAttachmentWorkflowInput.test.js
@@ -45,6 +45,11 @@ describe('chat attachment workflow input binding', () => {
+
+
+
+
+
`;
@@ -130,13 +135,20 @@ describe('chat attachment workflow input binding', () => {
type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet'
}
);
+ const promptInput = document.getElementById('promptInput');
+ promptInput.value = 'Represent the PhD students and supervision information.';
await __testOnly_uploadFilesToVon([uploadedFile]);
- const promptInput = document.getElementById('promptInput');
- expect(promptInput.value).toContain('Attached file uploaded.');
+ expect(promptInput.value).toBe(
+ 'Represent the PhD students and supervision information.'
+ );
expect(promptInput.value).not.toContain('supervision.xlsx');
expect(promptInput.value).not.toContain(fileCopyConceptId);
- promptInput.value += '\nRepresent the PhD students and supervision information.';
+ const pendingAttachmentStatus = document.getElementById(
+ 'pendingAttachmentStatus'
+ );
+ expect(pendingAttachmentStatus.classList.contains('hidden')).toBe(false);
+ expect(pendingAttachmentStatus.textContent).toContain('supervision.xlsx');
await sendMessage();
@@ -146,6 +158,7 @@ describe('chat attachment workflow input binding', () => {
});
expect(generateBodies[0].prompt).not.toContain(fileCopyConceptId);
expect(generateBodies[0].prompt).not.toContain('supervision.xlsx');
+ expect(pendingAttachmentStatus.classList.contains('hidden')).toBe(true);
promptInput.value = 'A separate follow-up without an attachment.';
await sendMessage();
@@ -154,6 +167,255 @@ describe('chat attachment workflow input binding', () => {
expect(generateBodies[1]).not.toHaveProperty('workflow_inputs');
}, 15000);
+ test('a slow upload exposes progress and coalesces repeated attachment actions', async () => {
+ const { __testOnly_uploadFilesToVon } = require(chatTabModulePath);
+ const fileCopyConceptId = '#V#uploaded_file_copy_slow_guard_test';
+ let resolveUpload;
+ let uploadFetchCount = 0;
+ const uploadResponse = new Promise((resolve) => {
+ resolveUpload = resolve;
+ });
+
+ global.fetch = jest.fn((url, options = {}) => {
+ if (url === '/von/api/files/upload') {
+ uploadFetchCount += 1;
+ return uploadResponse;
+ }
+ if (typeof url === 'string' && url.startsWith('/von/api/render_markdown')) {
+ const body = JSON.parse(options.body || '{}');
+ return Promise.resolve({
+ ok: true,
+ json: async () => ({ html: String(body.text || '') })
+ });
+ }
+ if (typeof url === 'string' && url.startsWith('/von/history/length')) {
+ return Promise.resolve({
+ ok: true,
+ json: async () => ({ history_length: 0, authenticated: true })
+ });
+ }
+ return Promise.resolve({ ok: true, json: async () => ({}) });
+ });
+
+ const uploadedFile = new File(
+ ['candidate,supervisor\nExample,Professor Example\n'],
+ 'slow-supervision.xlsx',
+ {
+ type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
+ lastModified: 1785167279463
+ }
+ );
+ const promptInput = document.getElementById('promptInput');
+ promptInput.value = 'Keep this draft exactly as written.';
+
+ const firstUpload = __testOnly_uploadFilesToVon([uploadedFile]);
+ await Promise.resolve();
+ const repeatedUpload = __testOnly_uploadFilesToVon([uploadedFile]);
+
+ expect(repeatedUpload).toBe(firstUpload);
+ expect(uploadFetchCount).toBe(1);
+ expect(promptInput.value).toBe('Keep this draft exactly as written.');
+ expect(document.getElementById('chatAttachmentStatus').classList.contains('hidden')).toBe(false);
+ expect(document.getElementById('uploadFileStatus').textContent).toContain(
+ 'already in progress'
+ );
+ expect(document.getElementById('uploadFileButton').disabled).toBe(true);
+
+ resolveUpload({
+ ok: true,
+ json: async () => ({
+ success: true,
+ uploaded: {
+ concept_id: fileCopyConceptId,
+ type_concept_id: '#V#computer_file_copy'
+ },
+ storage: {
+ backend: 'test',
+ key: 'uploads/test/slow-supervision.xlsx'
+ },
+ chat_history_recorded: true
+ })
+ });
+ await Promise.all([firstUpload, repeatedUpload]);
+ await Promise.resolve();
+
+ expect(uploadFetchCount).toBe(1);
+ expect(promptInput.value).toBe('Keep this draft exactly as written.');
+ expect(document.getElementById('uploadFileButton').disabled).toBe(false);
+ expect(document.getElementById('pendingAttachmentStatus').textContent).toContain(
+ 'slow-supervision.xlsx'
+ );
+ const confirmationCount = (
+ document.getElementById('scrollableField').textContent.match(
+ /File uploaded and registered as/g
+ ) || []
+ ).length;
+ expect(confirmationCount).toBe(1);
+ }, 15000);
+
+ test('uploads independently in two conversations without discarding either file', async () => {
+ const {
+ __testOnly_setActiveChatSession,
+ __testOnly_uploadFilesToVon
+ } = require(chatTabModulePath);
+ const deferredUploads = new Map();
+ const uploadFileNames = [];
+
+ global.fetch = jest.fn((url, options = {}) => {
+ if (url === '/von/api/files/upload') {
+ const fileName = options.body.get('file').name;
+ uploadFileNames.push(fileName);
+ return new Promise((resolve) => {
+ deferredUploads.set(fileName, resolve);
+ });
+ }
+ if (typeof url === 'string' && url.startsWith('/von/api/render_markdown')) {
+ const body = JSON.parse(options.body || '{}');
+ return Promise.resolve({
+ ok: true,
+ json: async () => ({ html: String(body.text || '') })
+ });
+ }
+ return Promise.resolve({ ok: true, json: async () => ({}) });
+ });
+
+ const fileA = new File(['A'], 'conversation-a.xlsx', {
+ type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet'
+ });
+ const fileB = new File(['B'], 'conversation-b.xlsx', {
+ type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet'
+ });
+
+ const uploadA = __testOnly_uploadFilesToVon([fileA]);
+ await Promise.resolve();
+ __testOnly_setActiveChatSession('conversation-b', 'Conversation B');
+ expect(document.getElementById('uploadFileButton').disabled).toBe(false);
+
+ const uploadB = __testOnly_uploadFilesToVon([fileB]);
+ await Promise.resolve();
+
+ expect(uploadB).not.toBe(uploadA);
+ expect(uploadFileNames).toEqual([
+ 'conversation-a.xlsx',
+ 'conversation-b.xlsx'
+ ]);
+
+ deferredUploads.get('conversation-b.xlsx')({
+ ok: true,
+ json: async () => ({
+ success: true,
+ uploaded: {
+ concept_id: '#V#uploaded_file_copy_conversation_b',
+ type_concept_id: '#V#computer_file_copy'
+ },
+ storage: {
+ backend: 'test',
+ key: 'uploads/test/conversation-b.xlsx'
+ },
+ chat_history_recorded: true
+ })
+ });
+ await uploadB;
+ expect(document.getElementById('pendingAttachmentStatus').textContent).toContain(
+ 'conversation-b.xlsx'
+ );
+
+ deferredUploads.get('conversation-a.xlsx')({
+ ok: true,
+ json: async () => ({
+ success: true,
+ uploaded: {
+ concept_id: '#V#uploaded_file_copy_conversation_a',
+ type_concept_id: '#V#computer_file_copy'
+ },
+ storage: {
+ backend: 'test',
+ key: 'uploads/test/conversation-a.xlsx'
+ },
+ chat_history_recorded: true
+ })
+ });
+ await uploadA;
+
+ expect(document.getElementById('pendingAttachmentStatus').textContent).toContain(
+ 'conversation-b.xlsx'
+ );
+ __testOnly_setActiveChatSession('attachment-session', 'Attachment test');
+ expect(document.getElementById('pendingAttachmentStatus').textContent).toContain(
+ 'conversation-a.xlsx'
+ );
+ }, 15000);
+
+ test('does not leak upload progress or completion into another conversation', async () => {
+ const {
+ __testOnly_setActiveChatSession,
+ __testOnly_uploadFilesToVon
+ } = require(chatTabModulePath);
+ let resolveUpload;
+ const uploadResponse = new Promise((resolve) => {
+ resolveUpload = resolve;
+ });
+
+ global.fetch = jest.fn((url, options = {}) => {
+ if (url === '/von/api/files/upload') {
+ return uploadResponse;
+ }
+ if (typeof url === 'string' && url.startsWith('/von/api/render_markdown')) {
+ const body = JSON.parse(options.body || '{}');
+ return Promise.resolve({
+ ok: true,
+ json: async () => ({ html: String(body.text || '') })
+ });
+ }
+ return Promise.resolve({ ok: true, json: async () => ({}) });
+ });
+
+ const uploadedFile = new File(['A'], 'stay-in-a.xlsx', {
+ type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet'
+ });
+ const upload = __testOnly_uploadFilesToVon([uploadedFile]);
+ await Promise.resolve();
+ expect(document.getElementById('uploadFileStatus').textContent).toContain(
+ 'stay-in-a.xlsx'
+ );
+
+ __testOnly_setActiveChatSession('conversation-b', 'Conversation B');
+ document.getElementById('scrollableField').textContent = '';
+ expect(document.getElementById('uploadFileStatus').textContent).toBe('');
+ expect(document.getElementById('uploadFileButton').disabled).toBe(false);
+
+ resolveUpload({
+ ok: true,
+ json: async () => ({
+ success: true,
+ uploaded: {
+ concept_id: '#V#uploaded_file_copy_stay_in_a',
+ type_concept_id: '#V#computer_file_copy'
+ },
+ storage: {
+ backend: 'test',
+ key: 'uploads/test/stay-in-a.xlsx'
+ },
+ chat_history_recorded: true
+ })
+ });
+ await upload;
+
+ expect(document.getElementById('uploadFileStatus').textContent).toBe('');
+ expect(document.getElementById('pendingAttachmentStatus').classList.contains('hidden')).toBe(true);
+ expect(document.getElementById('scrollableField').textContent).not.toContain(
+ 'File uploaded and registered as'
+ );
+
+ __testOnly_setActiveChatSession('attachment-session', 'Attachment test');
+ expect(document.getElementById('uploadFileStatus').textContent).toContain(
+ 'Upload complete'
+ );
+ expect(document.getElementById('pendingAttachmentStatus').textContent).toContain(
+ 'stay-in-a.xlsx'
+ );
+ }, 15000);
+
test('a rejected generate request retains the attachment for retry', async () => {
const {
__testOnly_uploadFilesToVon,
@@ -220,11 +482,17 @@ describe('chat attachment workflow input binding', () => {
await __testOnly_uploadFilesToVon([uploadedFile]);
const promptInput = document.getElementById('promptInput');
- promptInput.value += '\nRepresent this spreadsheet.';
+ const pendingAttachmentStatus = document.getElementById(
+ 'pendingAttachmentStatus'
+ );
+ promptInput.value = 'Represent this spreadsheet.';
await sendMessage();
+ expect(pendingAttachmentStatus.classList.contains('hidden')).toBe(false);
+ expect(pendingAttachmentStatus.textContent).toContain('retry.xlsx');
promptInput.value = 'Retry the spreadsheet representation.';
await sendMessage();
+ expect(pendingAttachmentStatus.classList.contains('hidden')).toBe(true);
expect(generateBodies).toHaveLength(2);
expect(generateBodies[0].workflow_inputs).toEqual({
@@ -295,11 +563,18 @@ describe('chat attachment workflow input binding', () => {
await __testOnly_uploadFilesToVon([uploadedFile]);
const promptInput = document.getElementById('promptInput');
+ const pendingAttachmentStatus = document.getElementById(
+ 'pendingAttachmentStatus'
+ );
+ expect(pendingAttachmentStatus.textContent).toContain('session.xlsx');
__testOnly_setActiveChatSession('unrelated-session', 'Unrelated');
+ expect(pendingAttachmentStatus.classList.contains('hidden')).toBe(true);
promptInput.value = 'An unrelated question.';
await sendMessage();
__testOnly_setActiveChatSession('attachment-session', 'Attachment test');
+ expect(pendingAttachmentStatus.classList.contains('hidden')).toBe(false);
+ expect(pendingAttachmentStatus.textContent).toContain('session.xlsx');
promptInput.value = 'Represent the uploaded spreadsheet.';
await sendMessage();
diff --git a/tests/frontend/chatDisplayElementOwnership.test.js b/tests/frontend/chatDisplayElementOwnership.test.js
new file mode 100644
index 000000000..d8d48339a
--- /dev/null
+++ b/tests/frontend/chatDisplayElementOwnership.test.js
@@ -0,0 +1,320 @@
+/** @jest-environment jsdom */
+
+const chatTabModulePath = '../../src/frontend/web/von_interface/static/js/chatTab.js';
+
+jest.mock('../../src/frontend/web/von_interface/static/js/apiService.js', () => ({
+ annotateTurn: jest.fn(),
+ getUserContext: jest.fn(),
+ getWindowSessionId: jest.fn(() => 'window-display-ownership-test')
+}));
+
+jest.mock('../../src/frontend/web/von_interface/static/js/domUtils.js', () => ({
+ elements: {},
+ renderSpanSuggestions: jest.fn(),
+ getCurrentUserConceptId: jest.fn(() => null)
+}));
+
+jest.mock('../../src/frontend/web/von_interface/static/js/utils/textDecorator.js', () => ({
+ applyCartoucheAppearance: jest.fn(),
+ cartouchifyElementText: jest.fn(),
+ cartouchifyVontologyTokensInElement: jest.fn(),
+ createVontologyAliasCartouche: jest.fn(),
+ createVontologyCartouche: jest.fn(),
+ findPotentialConceptAliasMatches: jest.fn(() => []),
+ getCartoucheAppearanceSettings: jest.fn(() => ({})),
+ linkifyVontologyTokensInElement: jest.fn(),
+ normalisePotentialConceptAlias: jest.fn((value) => value),
+ normalisePotentialConceptId: jest.fn((value) => value),
+ replaceTextNodeWithVontologyAliasCartouches: jest.fn(() => [])
+}));
+
+const {
+ __testOnly_renderDisplayElementsIntoContainer
+} = require(chatTabModulePath);
+
+function buildTablePayload(label, value) {
+ return {
+ columns: [
+ { column_id: 'name', label: 'Name', data_type: 'text' },
+ { column_id: 'status', label: 'Status', data_type: 'text' }
+ ],
+ rows: [
+ {
+ row_id: `row_${label}`,
+ cells: [
+ {
+ column_id: 'name',
+ value_raw: label,
+ value_display: label,
+ value_type: 'text'
+ },
+ {
+ column_id: 'status',
+ value_raw: value,
+ value_display: value,
+ value_type: 'text'
+ }
+ ]
+ }
+ ]
+ };
+}
+
+describe('chat display-element renderer ownership', () => {
+ test('keeps inline-derived tables primary while rendering explicit structured tables', () => {
+ const container = document.createElement('div');
+ container.dataset.renderMode = 'rendered';
+ container.dataset.originalText = [
+ 'Before the tables.',
+ '| Name | Status |',
+ '| --- | --- |',
+ '| Alpha | **Yes** |',
+ '',
+ '| Name | Status |',
+ '| --- | --- |',
+ '| Beta | `pending` |',
+ 'After the tables.'
+ ].join('\n');
+ container.innerHTML = [
+ '
Before the tables.
',
+ '
',
+ '
',
+ '
After the tables.
'
+ ].join('');
+
+ __testOnly_renderDisplayElementsIntoContainer(container, {
+ display_elements: {
+ schema_version: 'turn_display_elements_v1',
+ elements: [
+ {
+ element_id: 'screen_text',
+ element_type: 'text_block',
+ channel: 'screen',
+ order: 10,
+ intent: 'primary_response',
+ payload: { text: container.dataset.originalText },
+ provenance: { source: 'response_text' }
+ },
+ {
+ element_id: 'screen_table_1',
+ element_type: 'table',
+ channel: 'screen',
+ order: 16,
+ intent: 'structured_tabular_view',
+ payload: {
+ ...buildTablePayload('Alpha', '**Yes**'),
+ source_span: { start_line: 2, end_line: 4 }
+ },
+ presentation: {
+ mode: 'inline_primary',
+ source_element_id: 'screen_text',
+ source_span: { start_line: 2, end_line: 4 }
+ },
+ provenance: {
+ source: 'screen_markdown_table',
+ table_index: 1
+ }
+ },
+ {
+ element_id: 'screen_table_2',
+ element_type: 'table',
+ channel: 'screen',
+ order: 17,
+ intent: 'structured_tabular_view',
+ payload: {
+ ...buildTablePayload('Beta', '`pending`'),
+ source_span: { start_line: 6, end_line: 8 }
+ },
+ provenance: {
+ source: 'screen_markdown_table',
+ table_index: 2
+ }
+ },
+ {
+ element_id: 'screen_structured_table_1',
+ element_type: 'table',
+ channel: 'screen',
+ order: 18,
+ intent: 'structured_tabular_view',
+ payload: {
+ ...buildTablePayload('Alpha', 'Yes with provenance'),
+ title: 'Explicit comparison'
+ },
+ presentation: { mode: 'augment' },
+ provenance: {
+ source: 'screen_structured_table',
+ table_index: 1
+ }
+ }
+ ]
+ }
+ });
+
+ expect(container.dataset.inlinePrimaryTableCount).toBe('2');
+ expect(container.querySelectorAll('.inline-primary-table')).toHaveLength(2);
+ expect(container.querySelectorAll('.chat-display-elements-table')).toHaveLength(1);
+ expect(
+ container.querySelector('.chat-display-elements-table-title').textContent
+ ).toBe('Explicit comparison');
+ expect(container.textContent).toContain('Before the tables.');
+ expect(container.textContent).toContain('After the tables.');
+ expect(container.textContent).toContain('Yes with provenance');
+ expect(container.textContent).not.toContain('**Yes**');
+ expect(container.textContent).not.toContain('`pending`');
+ });
+
+ test('raw view remains faithful and never appends display cards', () => {
+ const originalText = [
+ 'Before.',
+ '| Name | Status |',
+ '| --- | --- |',
+ '| Alpha | **Yes** |',
+ 'After.'
+ ].join('\n');
+ const container = document.createElement('div');
+ container.dataset.renderMode = 'text';
+ container.dataset.originalText = originalText;
+ container.textContent = originalText;
+
+ __testOnly_renderDisplayElementsIntoContainer(container, {
+ display_elements: {
+ schema_version: 'turn_display_elements_v1',
+ elements: [
+ {
+ element_id: 'screen_table_1',
+ element_type: 'table',
+ channel: 'screen',
+ order: 16,
+ intent: 'structured_tabular_view',
+ payload: {
+ ...buildTablePayload('Alpha', '**Yes**'),
+ source_span: { start_line: 2, end_line: 4 }
+ },
+ presentation: {
+ mode: 'inline_primary',
+ source_element_id: 'screen_text',
+ source_span: { start_line: 2, end_line: 4 }
+ },
+ provenance: { source: 'screen_markdown_table' }
+ }
+ ]
+ }
+ });
+
+ expect(container.textContent).toBe(originalText);
+ expect(container.querySelector('.chat-display-elements')).toBeNull();
+ });
+
+ test('keeps structured fallback when the declared inline source is missing', () => {
+ const originalText = [
+ '| Name | Status |',
+ '| --- | --- |',
+ '| Alpha | Yes |'
+ ].join('\n');
+ const container = document.createElement('div');
+ container.dataset.renderMode = 'rendered';
+ container.dataset.originalText = originalText;
+ container.innerHTML = '
';
+
+ __testOnly_renderDisplayElementsIntoContainer(container, {
+ display_elements: {
+ schema_version: 'turn_display_elements_v1',
+ elements: [
+ {
+ element_id: 'screen_table_1',
+ element_type: 'table',
+ channel: 'screen',
+ order: 16,
+ intent: 'structured_tabular_view',
+ payload: {
+ ...buildTablePayload('Alpha', 'Yes'),
+ source_span: { start_line: 1, end_line: 3 }
+ },
+ presentation: {
+ mode: 'inline_primary',
+ source_element_id: 'missing_text',
+ source_span: { start_line: 1, end_line: 3 }
+ },
+ provenance: { source: 'screen_markdown_table' }
+ }
+ ]
+ }
+ });
+
+ expect(container.dataset.inlinePrimaryTableCount).toBe('0');
+ expect(container.querySelectorAll('table')).toHaveLength(2);
+ expect(container.querySelector('.chat-display-elements-table')).not.toBeNull();
+ });
+
+ test('keeps all structured fallbacks when inline table rendering is incomplete', () => {
+ const originalText = [
+ '| Name | Status |',
+ '| --- | --- |',
+ '| Alpha | Yes |',
+ '',
+ '| Name | Status |',
+ '| --- | --- |',
+ '| Beta | pending |'
+ ].join('\n');
+ const container = document.createElement('div');
+ container.dataset.renderMode = 'rendered';
+ container.dataset.originalText = originalText;
+ container.innerHTML = '
';
+
+ __testOnly_renderDisplayElementsIntoContainer(container, {
+ display_elements: {
+ schema_version: 'turn_display_elements_v1',
+ elements: [
+ {
+ element_id: 'screen_text',
+ element_type: 'text_block',
+ channel: 'screen',
+ order: 10,
+ intent: 'primary_response',
+ payload: { text: originalText },
+ provenance: { source: 'response_text' }
+ },
+ {
+ element_id: 'screen_table_1',
+ element_type: 'table',
+ channel: 'screen',
+ order: 16,
+ intent: 'structured_tabular_view',
+ payload: {
+ ...buildTablePayload('Alpha', 'Yes'),
+ source_span: { start_line: 1, end_line: 3 }
+ },
+ presentation: {
+ mode: 'inline_primary',
+ source_element_id: 'screen_text',
+ source_span: { start_line: 1, end_line: 3 }
+ },
+ provenance: { source: 'screen_markdown_table' }
+ },
+ {
+ element_id: 'screen_table_2',
+ element_type: 'table',
+ channel: 'screen',
+ order: 17,
+ intent: 'structured_tabular_view',
+ payload: {
+ ...buildTablePayload('Beta', 'pending'),
+ source_span: { start_line: 5, end_line: 7 }
+ },
+ presentation: {
+ mode: 'inline_primary',
+ source_element_id: 'screen_text',
+ source_span: { start_line: 5, end_line: 7 }
+ },
+ provenance: { source: 'screen_markdown_table' }
+ }
+ ]
+ }
+ });
+
+ expect(container.dataset.inlinePrimaryTableCount).toBe('0');
+ expect(container.querySelectorAll('.chat-display-elements-table')).toHaveLength(2);
+ expect(container.textContent).toContain('Alpha');
+ expect(container.textContent).toContain('Beta');
+ });
+});
diff --git a/tests/frontend/chatTabMarkdownRender.test.js b/tests/frontend/chatTabMarkdownRender.test.js
index e71b67be4..9720daee5 100644
--- a/tests/frontend/chatTabMarkdownRender.test.js
+++ b/tests/frontend/chatTabMarkdownRender.test.js
@@ -767,6 +767,63 @@ describe('chat markdown rendering (assistant)', () => {
'',
''
].join('');
+ const displayElements = {
+ schema_version: 'turn_display_elements_v1',
+ elements: [
+ {
+ element_id: 'screen_text',
+ element_type: 'text_block',
+ channel: 'screen',
+ order: 10,
+ intent: 'primary_response',
+ payload: { text: assistantResponse },
+ provenance: { source: 'response_text' }
+ },
+ {
+ element_id: 'screen_table_1',
+ element_type: 'table',
+ channel: 'screen',
+ order: 16,
+ intent: 'structured_tabular_view',
+ payload: {
+ columns: [
+ { column_id: 'name', label: 'Name', data_type: 'text' },
+ { column_id: 'degree', label: 'Degree', data_type: 'text' },
+ { column_id: 'role', label: 'Role', data_type: 'text' }
+ ],
+ rows: [
+ {
+ row_id: 'row_1',
+ cells: [
+ { column_id: 'name', value_raw: 'Alice', value_display: 'Alice', value_type: 'text' },
+ { column_id: 'degree', value_raw: 'PhD', value_display: 'PhD', value_type: 'text' },
+ { column_id: 'role', value_raw: 'Student', value_display: 'Student', value_type: 'text' }
+ ]
+ },
+ {
+ row_id: 'row_2',
+ cells: [
+ { column_id: 'name', value_raw: 'Bob', value_display: 'Bob', value_type: 'text' },
+ { column_id: 'degree', value_raw: 'MSc', value_display: 'MSc', value_type: 'text' },
+ { column_id: 'role', value_raw: 'Tutor', value_display: 'Tutor', value_type: 'text' }
+ ]
+ }
+ ]
+ },
+ presentation: {
+ mode: 'inline_primary',
+ source_element_id: 'screen_text',
+ source_span: { start_line: 1, end_line: 4 }
+ },
+ provenance: {
+ source: 'screen_markdown_table',
+ table_index: 1
+ }
+ }
+ ],
+ reason_codes: ['screen_markdown_tables_detected'],
+ validation: { valid: true, errors: [] }
+ };
global.fetch = jest.fn((url) => {
const common = mockCommonChatSessionResponse(url);
@@ -791,7 +848,11 @@ describe('chat markdown rendering (assistant)', () => {
ok: true,
json: async () => ({
response: assistantResponse,
- llm_debug: { model: 'gpt-5.4-mini-2026-03-17' }
+ display_elements: displayElements,
+ llm_debug: {
+ model: 'gpt-5.4-mini-2026-03-17',
+ display_elements: displayElements
+ }
})
});
}
@@ -806,6 +867,9 @@ describe('chat markdown rendering (assistant)', () => {
const assistantMarkdown = scrollableField.querySelector('.chat-markdown.markdown-rendered');
expect(assistantMarkdown).not.toBeNull();
expect(assistantMarkdown.querySelector('table')).not.toBeNull();
+ expect(assistantMarkdown.querySelectorAll('table')).toHaveLength(1);
+ expect(assistantMarkdown.querySelector('.chat-display-elements-table')).toBeNull();
+ expect(assistantMarkdown.dataset.inlinePrimaryTableCount).toBe('1');
expect(assistantMarkdown.textContent).toContain('Alice');
const assistantContainer = assistantMarkdown.closest('.message-container');
@@ -829,6 +893,8 @@ describe('chat markdown rendering (assistant)', () => {
expect(assistantMarkdown.dataset.renderMode).toBe('rendered');
expect(assistantMarkdown.classList.contains('chat-markdown')).toBe(true);
expect(assistantMarkdown.querySelector('table')).not.toBeNull();
+ expect(assistantMarkdown.querySelectorAll('table')).toHaveLength(1);
+ expect(assistantMarkdown.querySelector('.chat-display-elements-table')).toBeNull();
expect(renderBadge.textContent).toContain('View: Rendered');
expect(toggleButton.textContent).toBe('Text');
});