From 6ab41c6e37b79757b7e62ae5199a2ef1b9778058 Mon Sep 17 00:00:00 2001
From: Lily Shen <115414357+lilyshen0722@users.noreply.github.com>
Date: Thu, 15 Oct 2026 19:34:18 -0700
Subject: [PATCH 1/2] test(hosted): pin that the hosted offer's limits come
 from the cap source, not a literal

Sprint Review's finding on #2250 (review 5542338255): the arm "states the
limits the meter enforces" compares the tool description with hostedCaps(),
the same source it is built from, so a hardcoded literal matching today's caps
passes it. Measured there: literal swapped in, 22/22 still green.

The new arm loads nativeRuntimeService in isolation under other caps
(HOSTED_TURNS_PER_DAY=7, _PRO=70, HOSTED_AGENTS_PER_USER=2) and asserts the
description follows them. Mutation: the hardcoded literal from the review
fails it (1 failed, 9 passed); the derived line passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0157AG2wo8mJYqKezXNs48Ya
---
 .../nativeRuntimeService.toolGating.test.js      | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/backend/__tests__/unit/services/nativeRuntimeService.toolGating.test.js b/backend/__tests__/unit/services/nativeRuntimeService.toolGating.test.js
index 252ae3871c..dc308fee32 100644
--- a/backend/__tests__/unit/services/nativeRuntimeService.toolGating.test.js
+++ b/backend/__tests__/unit/services/nativeRuntimeService.toolGating.test.js
@@ -93,6 +93,22 @@ describe('toolsForConfig', () => {
     expect(offer.function.description).toMatch(/no invitation code/);
   });
 
+  // Sprint Review on #2250: the arm above compares the description with
+  // hostedCaps(), the source it is built from, so a hardcoded literal matching
+  // today's caps passes it too. Loaded under other caps, only a description
+  // derived from the cap source follows.
+  test('the hosted offer follows the cap source, so it cannot be a copied literal', () => {
+    const caps = { HOSTED_TURNS_PER_DAY: '7', HOSTED_TURNS_PER_DAY_PRO: '70', HOSTED_AGENTS_PER_USER: '2' };
+    withEnv(caps, () => {
+      jest.isolateModules(() => {
+        // eslint-disable-next-line global-require
+        const { TOOLS: reloaded } = require('../../../services/nativeRuntimeService');
+        const offer = reloaded.find((t) => t.function.name === 'commonly_offer_hosted_agent');
+        expect(offer.function.description).toContain('2 hosted agents per account and 7 turns a day (70 on Pro)');
+      });
+    });
+  });
+
   test('agent_status is declaration-gated like every other tool', () => {
     // Scout declares it; a legacy config or a minimal allowlist does not
     // receive it implicitly.

From 020641add2a353230febbc8f0c5096804f666415 Mon Sep 17 00:00:00 2001
From: Lily Shen <115414357+lilyshen0722@users.noreply.github.com>
Date: Thu, 15 Oct 2026 20:00:34 -0700
Subject: [PATCH 2/2] test(hosted): pin the label on the "Connect your first
 agent" card, and mock only the writer
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Sprint Review's two findings on #2252 (review 5542388348):
- `expect(agentLabel).toBeTruthy()` passed with the whole fallback chain
  replaced by 'x' (96/96 green), yet the label is user-visible in the card's
  "Completed automatically — <label> connected" line. The arms now pin the
  value: 'scout' with no display names, the bot's displayName first, and the
  installation's displayName before the agent name. Mutations: the constant
  fails two arms; dropping the middle link fails one.
- The starterTaskService mock listed one export, so it silently dropped the
  rest. It now spreads jest.requireActual and replaces only the writer.

The new arm sends its own Authorization header. The route's limiter keys on
it, and this file's other requests already reach its 30-a-minute ceiling, so
two more from the shared key 429'd a later deprovision test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0157AG2wo8mJYqKezXNs48Ya
---
 backend/__tests__/unit/routes/hosted.test.js | 29 +++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/backend/__tests__/unit/routes/hosted.test.js b/backend/__tests__/unit/routes/hosted.test.js
index 1bc46fadff..21c4908049 100644
--- a/backend/__tests__/unit/routes/hosted.test.js
+++ b/backend/__tests__/unit/routes/hosted.test.js
@@ -69,7 +69,10 @@ jest.mock('../../../services/nativeRuntimeService', () => ({
 const mockMarkByoOpened = jest.fn();
 jest.mock('../../../services/onboardingMarks', () => ({ markByoOpened: (...args) => mockMarkByoOpened(...args) }));
 const mockCompleteConnectAgent = jest.fn();
+// Spread the real module so only the writer is replaced (Sprint Review on
+// #2252: a factory that lists exports silently drops the rest).
 jest.mock('../../../services/starterTaskService', () => ({
+  ...jest.requireActual('../../../services/starterTaskService'),
   completeConnectAgentStarterTask: (...args) => mockCompleteConnectAgent(...args),
 }));
 jest.mock('../../../routes/registry/tokens', () => ({
@@ -486,7 +489,31 @@ describe('/api/hosted on the native engine', () => {
     expect(mockCompleteConnectAgent).toHaveBeenCalledTimes(1);
     const [{ podIds, agentLabel }] = mockCompleteConnectAgent.mock.calls[0];
     expect(podIds.map(String)).toEqual(['pod-1']);
-    expect(agentLabel).toBeTruthy();
+    // The label reaches the person in the card's update line, so pin the
+    // value, not truthiness (Sprint Review on #2252: a constant passed that).
+    expect(agentLabel).toBe('scout');
+  });
+
+  it('names the agent on the card by its display name first', async () => {
+    // Its own rate-limit bucket: the limiter keys on Authorization (auth is
+    // mocked), and this file's other requests already sit at its 30-a-minute
+    // ceiling, so two more from the shared key 429 a later test.
+    const ownBucket = { Authorization: 'Bearer hosted-label-test' };
+    mockUserFindOne.mockResolvedValue({
+      _id: 'bot-1', username: 'scout', agentRuntimeTokens: [], botMetadata: { displayName: 'Research Scout' },
+    });
+    mockFindOne.mockResolvedValue(nativeInstallation());
+    await request(app).post('/api/hosted/provision').set(ownBucket).send({ agentName: 'scout' });
+    expect(mockCompleteConnectAgent.mock.calls[0][0].agentLabel).toBe('Research Scout');
+
+    mockCompleteConnectAgent.mockClear();
+    mockUserFindOne.mockResolvedValue({ _id: 'bot-1', username: 'scout', agentRuntimeTokens: [] });
+    mockFindOne.mockResolvedValue(makeInstallation({
+      displayName: 'Lab Notes',
+      config: new Map([['runtime', { runtimeType: 'hosted' }], ['hosted', { engine: 'native', provisionedAt: PROVISIONED }]]),
+    }));
+    await request(app).post('/api/hosted/provision').set(ownBucket).send({ agentName: 'scout' });
+    expect(mockCompleteConnectAgent.mock.calls[0][0].agentLabel).toBe('Lab Notes');
   });
 
   it('provision of a native install 503s when the native runtime is unavailable, even with the worker up', async () => {