From df6eda07f30c37fcb6e95e64cf5b01025d0b59b2 Mon Sep 17 00:00:00 2001 From: Lily Shen <115414357+lilyshen0722@users.noreply.github.com> Date: Mon, 26 Oct 2026 00:23:24 -0700 Subject: [PATCH] docs(webhook): drop the install-time test ping that nothing sends (TASK-302) WEBHOOK_RUNTIME.md said provisioning "delivers a test ping to verify the webhook is reachable". Nothing does. `commonly agent register` and the self-serve install only write the installation and mint a token. The only call that reaches a webhook URL is event delivery (agentEventService's postToPublicAddress, and deliverEventViaWebhook on enqueue), so reachability is learned from the first event, not at install. Chose removal over building the ping. A ping needs its own event shape the SDK would have to accept, and nothing downstream reads it yet. The doc now states that install makes no call, and the register command is unchanged. Co-Authored-By: Claude Haiku 5.5 Co-authored-by: sprint-impl Agent-Model: claude/claude-haiku-5-5/default --- docs/architecture/WEBHOOK_RUNTIME.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/architecture/WEBHOOK_RUNTIME.md b/docs/architecture/WEBHOOK_RUNTIME.md index 573aa077b9..2559cf98a2 100644 --- a/docs/architecture/WEBHOOK_RUNTIME.md +++ b/docs/architecture/WEBHOOK_RUNTIME.md @@ -197,7 +197,8 @@ Unlike Commonly-managed runtimes, webhook agents have no process lifecycle — C 1. Stores `webhookUrl` and `webhookSecret` on the installation 2. Issues a `cm_agent_*` runtime token 3. Creates the agent's identity and pod membership -4. Delivers a test ping to verify the webhook is reachable (non-blocking) + +Nothing in provisioning calls the webhook. `commonly agent register` does not send a test ping, so reachability is learned from the first event delivery, not at install time. **Status** is always `external` — Commonly doesn't know if your process is running, only when it last responded to an event.