diff --git a/CHANGELOG.md b/CHANGELOG.md index 1ee0d05f..bd3f4e66 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -83,6 +83,7 @@ - **`/aios:update` no longer stops on the sandbox** (#316): its scratch files live in the vault's `.aios-run/`, not in `/tmp`. - **A symlinked `~/aios` is searched properly** (#319): the update's leftover sweep had silently checked nothing there. - **The image model is a setting** (#321, thanks to its contributor): `NANO_BANANA_MODEL`, or a per-call `model`. +- **A team's reports no longer overwrite each other** (#331, a patch after the release): crews named their report to the lead after the lead, so two arriving together kept only one. Each report is now named after its sender. Nothing to do: the next team you launch uses it. **Action required** — check each first; do only what applies: 1. **`hooks/install/install-settings.py` changed, so the update runs it** without `--apply` first and reads you what it prints. New this time: `+ add G` (agent hints) and `~ move` lines for hooks registered at their old top-level path. Each `~ move` changes only that path, keeping your interpreter and root. Then run it with `--apply` under the execution-disclosure protocol. diff --git a/hooks/agents/team-plan.py b/hooks/agents/team-plan.py index d1610117..13de8bad 100755 --- a/hooks/agents/team-plan.py +++ b/hooks/agents/team-plan.py @@ -94,7 +94,11 @@ def task_for(row): head = "Wear the `%s` agent (/aios:agent %s)." % (row["agent"], row["agent"]) if NOTE_REF: head += " Read the Charter in the ## Team section of %s first." % NOTE_REF - tail = ("When it is done, report back with one spawn-inbox `send` to %s: what you did and what is open." % report + # The request file is named after the SENDER: crews reporting to one lead named it after the + # lead, so two reports in the same second overwrote each other and one was lost unseen. + tail = ("When it is done, report back with one spawn-inbox `send` to %s, written as " + "~/.aios/spawn-inbox/%s-report.json (never a file named after %s): what you did and what is open." + % (report, row["session"], report) if report != "operator" else "When it is done, tell the operator what you did and what is open.") return "%s %s %s" % (head, row["first task"].rstrip(), tail) diff --git a/tests/team-plan.test.sh b/tests/team-plan.test.sh index a615d404..ad171e44 100755 --- a/tests/team-plan.test.sh +++ b/tests/team-plan.test.sh @@ -51,7 +51,9 @@ for f in fs: r=json.load(open(os.path.join(d,f))) assert set(r)=={"name","task","tier","group"} and r["group"]=="good" and "\n" not in r["task"] and len(r["task"].encode())<=1024, r m=json.load(open(os.path.join(d,"bakery-market.json")))["task"] -assert "send` to bakery-lead" in m and m.startswith("Wear the `market-researcher` agent") and "Charter" in m, m +# The report goes in a file named after the sender: two crews naming it after the lead overwrote +# each other in the live v0.8.19 probe, and one report was lost with nothing reporting it. +assert "send` to bakery-lead" in m and "spawn-inbox/bakery-market-report.json" in m and m.startswith("Wear the `market-researcher` agent") and "Charter" in m, m PY python3 - "$T/inbox" "$ROOT/hooks/context" <<'PY' && ok "every launched task is fingerprinted, so it reads as inbox-delivered, not typed" || no "a launched task is not in the bus log" import json,os,sys