chore: address v3 review follow-ups

Author: adamwdraper

.github/workflows/ci.yml

@@ -15,7 +15,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [18, 20, 22]
+        node-version: [20, 22]
 
     steps:
       - name: Checkout
@@ -27,11 +27,14 @@ jobs:
           node-version: ${{ matrix.node-version }}
 
       - name: Install dependencies
-        run: npm install --no-package-lock --no-audit --no-fund
+        run: npm ci --no-audit --no-fund
 
       - name: Run tests
         run: npm test
 
+      - name: Verify generated artifacts are up to date
+        run: git diff --exit-code
+
   all-checks-pass:
     name: all-checks-pass
     runs-on: ubuntu-latest

Gruntfile.js

@@ -213,7 +213,7 @@ module.exports = function(grunt) {
 
         grunt.config('string-replace.numeral', {
             files: {
-                'src/numeral.js': 'src/numeral.js'
+                'src/numeral.ts': 'src/numeral.ts'
             },
             options: {
                 replacements: [

MIGRATION.md

@@ -6,13 +6,13 @@ Version `3.0.0` keeps the public runtime behavior from `2.0.x`, but modernizes t
 
 ### Breaking changes
 
-1. Node.js requirement is now `>=18`.
+1. Node.js requirement is now `>=20`.
 2. The project source of truth is now TypeScript in `src/**/*.ts`.
 
 ### Notable updates
 
 1. First-party TypeScript declarations are bundled via `numeral.d.ts`.
-2. CI now runs on GitHub Actions against Node `18`, `20`, and `22`.
+2. CI now runs on GitHub Actions against Node `20` and `22`.
 3. Core build/test scripts now compile TypeScript before running Grunt tasks.
 
 ### New development commands

README.md

@@ -12,7 +12,7 @@ A javascript library for formatting and manipulating numbers.
 # v3 Notes
 
 1. `3.0.0` is a TypeScript rewrite with behavior preserved from `2.0.x`.
-2. Node.js support is now `>=18`.
+2. Node.js support is now `>=20`.
 3. First-party types are bundled in `numeral.d.ts`.
 4. See `MIGRATION.md` for upgrade details.
 
@@ -61,13 +61,13 @@ See [the english unit tests](https://github.com/adamwdraper/Numeral-js/blob/mast
 
 ### 3.0.0
 
-Breaking change: Node.js engines set to `>=18`
+Breaking change: Node.js engines set to `>=20`
 
 Breaking change: Source of truth moved to TypeScript (`src/**/*.ts`)
 
 Added: Bundled TypeScript types (`numeral.d.ts`)
 
-Added: GitHub Actions CI for Node 18/20/22
+Added: GitHub Actions CI for Node 20/22
 
 ### 2.0.6
 

locales.js

@@ -771,7 +771,7 @@
             if (number === 0) { // special case for zero
                 return '\'ıncı';
             }
-            var a = number % 10, b = number % 100 - a, c = number >= 100 ? 100 : null;
+            var a = number % 10, b = number % 100 - a, c = number >= 100 ? 100 : -1;
             return suffixes[a] || suffixes[b] || suffixes[c];
         },
         currency: {

locales/tr.js

@@ -47,7 +47,7 @@
             if (number === 0) { // special case for zero
                 return '\'ıncı';
             }
-            var a = number % 10, b = number % 100 - a, c = number >= 100 ? 100 : null;
+            var a = number % 10, b = number % 100 - a, c = number >= 100 ? 100 : -1;
             return suffixes[a] || suffixes[b] || suffixes[c];
         },
         currency: {

numeral.js

@@ -87,7 +87,7 @@
     numeral._ = _ = {
         // formats numbers separators, decimals places, signs, abbreviations
         numberToFormat: function (value, format, roundingFunction) {
-            var locale = locales[numeral.options.currentLocale], negP = false, optDec = false, leadingCount = 0, abbr = '', trillion = 1000000000000, billion = 1000000000, million = 1000000, thousand = 1000, decimal = '', neg = false, abbrForce, abs, int, precision, signed, thousands, output;
+            var locale = locales[numeral.options.currentLocale], negP = false, optDec = false, leadingCount = 0, abbr = '', trillion = 1000000000000, billion = 1000000000, million = 1000000, thousand = 1000, decimal = '', neg = false, abbrForce, abs, int, precision, signed = -1, thousands, output;
             // make sure we never format a null value
             value = value || 0;
             abs = Math.abs(value);
@@ -307,7 +307,8 @@
          * problems for accounting- and finance-related software.
          */
         toFixed: function (value, maxDecimals, roundingFunction, optionals) {
-            var splitValue = value.toString().split('.'), minDecimals = maxDecimals - (optionals || 0), boundedPrecision, optionalsRegExp, power, output;
+            optionals = optionals || 0;
+            var splitValue = value.toString().split('.'), minDecimals = maxDecimals - optionals, boundedPrecision, optionalsRegExp, power, output;
             // Use the smallest precision value possible to avoid errors from floating point representation
             if (splitValue.length === 2) {
                 boundedPrecision = Math.min(Math.max(splitValue[1].length, minDecimals), maxDecimals);