Videos not marking complete on ended

[KayConceicao]

Subject of the issue/enhancement/features

When a user watches the video to end it doesn't mark complete as per JSON set up.

Your environment

• version (Framework): 5.25.0
• which browser and its version: Chrome - latest
• device(s) + operating system(s): Laptop - windows

Steps to reproduce

Embed a YouTube video from a private YT account and set up to mark as complete when ended. Watch video to end.

Expected behaviour

The video should mark complete once ended.

Actual behaviour

Component only marks complete when transcript is seen.

Screenshots (if you can)

[oliverfoster]

Are there any console logs/warnings/errors?

Existing issue is marked here

adapt-youtube/js/YouTubeView.js

Lines 103 to 111 in c263295

	/**
	* this seems to have issues in Chrome if the user is logged into YouTube (possibly any Google account) - the API just doesn't broadcast the events
	* but instead throws the error:
	* Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('https://www.youtube.com') does not match the recipient window's origin ('http://www.youtube.com').
	* This is documented here:
	* https://code.google.com/p/gdata-issues/issues/detail?id=5788
	* but I haven't managed to get any of the workarounds to work... :-(
	*/
	onPlayerStateChange(e) {

[swashbuck]

Updated issue link: https://issuetracker.google.com/issues/35174286 (redirected from https://code.google.com/p/gdata-issues/issues/detail?id=5788 / Internal Server Error)

[swashbuck]

Tried to reproduce on Framework 5.56.2 with adapt-youtube v3.3.2, in Chrome signed into a Google account and again in an Incognito window. Tested both an unlisted and a private video with _setCompletionOn: "ended".

In every case where the video can actually play, it marks complete on ending as expected. The postMessage / origin error referenced at lines 103-111 never appears; the only YouTube console output is INFO: YouTube iframe API loaded.

The old gdata-issues link in that code comment now redirects to https://issuetracker.google.com/issues/35174286, which is closed as "Won't Fix / Not Reproducible" (last activity 2020). That original error was an http/https origin mismatch, unlikely to occur now that the page and the YouTube embed are both served over https. We couldn't trigger it.

The only case that doesn't complete is a private video viewed by someone without access: the embed shows "This video is private", so it can't play and never reaches ENDED. That's expected, and doesn't match the original "watches the video to the end" report.

So this no longer appears reproducible. Will close via PR #44 (code comment update) as cannot-reproduce. If anyone can still reproduce it on current versions, please reopen with console output.

Posted via collaboration with Claude Code