Skip to content

Natural-language search e2e suite always skips: manifest guard checks the wrong path #2090

Description

@akijakya

Problem Statement

tests/e2e/local/15_nl_search_test.go never runs. Its BeforeAll guard checks for the extractor manifest at the wrong path, so the suite skips in every environment, including the e2e:test:local:local job CI runs.

The guard looks for the manifest directly under .agntcy/oasf-sdk:

manifest := filepath.Join(home, ".agntcy", "oasf-sdk", "manifest.json")
if _, err := os.Stat(manifest); err != nil {
    ginkgo.Skip("OASF extractor not provisioned — run `dirctl init` to enable natural-language search tests")
}

But dirctl init provisions into ~/.agntcy/oasf-sdk/extractor/, per extractor.DefaultAssetDir in utils/extractor/config.go:31:

return filepath.Join(home, ".agntcy", "oasf-sdk", "extractor")

tests/e2e/local/16_extractor_enricher_test.go:38 gets this right and checks filepath.Join(home, ".agntcy", "oasf-sdk", "extractor", "manifest.json").

Confirmed on a machine that has run dirctl init: ~/.agntcy/oasf-sdk/extractor/manifest.json exists, ~/.agntcy/oasf-sdk/manifest.json does not. Because the skip is silent, the suite has reported green while executing nothing since it was added in #1770.

Proposed Solution

Point the guard at the same path 16_extractor_enricher_test.go uses, then confirm the suite actually executes and passes rather than skipping.

Worth doing as its own change rather than folding into unrelated work: it re-enables a suite that has not run in a long time, so any assertions that have drifted since #1770 will surface for the first time and deserve their own review.

Acceptance criteria

  • The guard checks the same manifest path dirctl init provisions and 16_extractor_enricher_test.go checks
  • The suite runs to completion on a provisioned machine instead of skipping
  • A skip still happens cleanly when the extractor genuinely is not provisioned

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomerskind/bugCategorizes issue or PR as related to a bug.kind/testCategorizes issue or PR as related to testing.

    Type

    Projects

    • Status
      Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions