From d749b45467ea917b6b58ab5c30b2a59d34de7574 Mon Sep 17 00:00:00 2001 From: Tony Hegyes Date: Thu, 29 Oct 2026 10:59:26 +0100 Subject: [PATCH] Drop the redundant public from the fixtures' set-only properties consumer-a, consumer-b and the core persona declared their kernel and migration runner as public protected(set), while a set-only visibility already reads as public. The packages write protected(set) alone, and the style guide's rule covers plugin code, so the fixtures that model a plugin's anatomy follow it as well. Assisted-by: Claude Code:claude-opus-5-5 --- tests/Fixtures/consumer-a/src/Plugin.php | 4 ++-- tests/Fixtures/consumer-b/src/Plugin.php | 2 +- tests/Fixtures/personas/core/src/Plugin.php | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Fixtures/consumer-a/src/Plugin.php b/tests/Fixtures/consumer-a/src/Plugin.php index f434539..b116a5b 100644 --- a/tests/Fixtures/consumer-a/src/Plugin.php +++ b/tests/Fixtures/consumer-a/src/Plugin.php @@ -89,7 +89,7 @@ final class Plugin { * * @var MigrationRunner|null */ - public protected(set) ?MigrationRunner $migrations = null; + protected(set) ?MigrationRunner $migrations = null; /** * The kernel, once the composition built it, which tells which components loaded and which were gated off. @@ -99,7 +99,7 @@ final class Plugin { * * @var PluginKernel|null */ - public protected(set) ?PluginKernel $kernel = null; + protected(set) ?PluginKernel $kernel = null; /** * The logger every part of the plugin writes to. diff --git a/tests/Fixtures/consumer-b/src/Plugin.php b/tests/Fixtures/consumer-b/src/Plugin.php index 7fe19ad..2e19aaf 100644 --- a/tests/Fixtures/consumer-b/src/Plugin.php +++ b/tests/Fixtures/consumer-b/src/Plugin.php @@ -71,7 +71,7 @@ final class Plugin { * * @var PluginKernel|null */ - public protected(set) ?PluginKernel $kernel = null; + protected(set) ?PluginKernel $kernel = null; /** * The logger every part of the plugin writes to. diff --git a/tests/Fixtures/personas/core/src/Plugin.php b/tests/Fixtures/personas/core/src/Plugin.php index ad143ee..b32a760 100644 --- a/tests/Fixtures/personas/core/src/Plugin.php +++ b/tests/Fixtures/personas/core/src/Plugin.php @@ -73,7 +73,7 @@ final class Plugin { * * @var PluginKernel|null */ - public protected(set) ?PluginKernel $kernel = null; + protected(set) ?PluginKernel $kernel = null; /** * The logger every part of the plugin writes to.