Types exports in @amplitude/analytics-types are out of date

[dxprog]

Expected Behavior

Expect that @amplitude/analytics-types exports match the current functionalities found in other packages. Example: AutocaptureOptions should have webVitals, which is properly exported in @amplitude/analytics-core.

If this package is deprecated or on the way to being deprecated, other packages need to export the types that are currently exported in @amplitude/analytics-types. Example: ValidPropertyType is exported by the types package, but not from @amplitude/analytics-core even though that type is redefined in that package.

Current Behavior

To use modern features and keep proper typing, now multiple packages with identically named exported types need to be imported to get the correct types.

Possible Solution

Steps to Reproduce

1. npm i @amplitude/analytics-types@2.11.1 @amplitude/analytics-browser@2.34.0
2. In a TS file:

import type { AutocaptureOptions } from '@amplitude/analytics-types';
const autocaptureOptions: AutocaptureOptions = {
  attribution: true,
  webVitals: true,
};

3. Type error: webVitals does not exist in type AutocaptureOptions

Environment

• JS SDK Version: 2.34.0
• Installation Method: npm
• Browser and Version: N/A

[daniel-graham-amplitude]

Thanks @dxprog . I'll make a note to add ValidPropertyType to analytics-core. I just had a look and I think that's the only non-internally used type that was missed. I'll also look into marking analytics-types as deprecated so that

One tip: instead of importing from @amplitude/analytics-core you can import the types directly from @amplitude/analytics-browser

import { Types } from '@amplitude/analytics-browser';
const autocaptureOptions: Types.AutocaptureOptions = { webVitals: true, ... }

The original impetus for moving the types over was so that you don't need to install an additional package to use analytics-browser.